HBase
  1. HBase
  2. HBASE-10163

Example Thrift DemoClient is flaky

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.96.2, 0.99.0
    • Component/s: Thrift
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      DemoClient for thrift under hbase-examples is failing sometimes because of earlier delete eclipses future puts with same timestamp.

      row: 00006, cols: unused: => DELETE_ME;
      row: 00006, cols: entry:num => -1;
      row: 00006, cols: entry:num => 6; entry:sqr => 36;
      row: 00006, cols: entry:num => 6; entry:sqr => 36;
      row: 00006, values: 6; -1;
      
      row: 00005, cols: unused: => DELETE_ME;
      row: 00005, values:
      FATAL: wrong # of versions
      

      Similar to the one we have, we can add another small sleep between delete and subsequent put.

        Activity

        Hide
        Enis Soztutar added a comment -

        simple patch.

        Show
        Enis Soztutar added a comment - simple patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12618689/hbase-10163_v1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618689/hbase-10163_v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8166//console This message is automatically generated.
        Hide
        Sergey Shelukhin added a comment -

        Maybe add explicit timestamps?

        Show
        Sergey Shelukhin added a comment - Maybe add explicit timestamps?
        Hide
        Enis Soztutar added a comment -

        Maybe add explicit timestamps?

        Unfortunately, Thrift API has different methods for doing puts with and without timestamps:

        client.mutateRow(ByteBuffer.wrap(t), ByteBuffer.wrap(row), mutations, dummyAttributes);
        ..
        client.mutateRowTs(ByteBuffer.wrap(t), ByteBuffer.wrap(row), mutations, 1, dummyAttributes);
        

        In DemoClient, we are using both of these to test them separately.

        Show
        Enis Soztutar added a comment - Maybe add explicit timestamps? Unfortunately, Thrift API has different methods for doing puts with and without timestamps: client.mutateRow(ByteBuffer.wrap(t), ByteBuffer.wrap(row), mutations, dummyAttributes); .. client.mutateRowTs(ByteBuffer.wrap(t), ByteBuffer.wrap(row), mutations, 1, dummyAttributes); In DemoClient, we are using both of these to test them separately.
        Hide
        Sergey Shelukhin added a comment -

        +1

        Show
        Sergey Shelukhin added a comment - +1
        Hide
        Enis Soztutar added a comment -

        Committed this. Thanks for review Sergey.

        Show
        Enis Soztutar added a comment - Committed this. Thanks for review Sergey.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #8 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/8/)
        HBASE-10163 Example Thrift DemoClient is flaky (enis: rev 1551385)

        • /hbase/trunk/hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/DemoClient.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #8 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/8/ ) HBASE-10163 Example Thrift DemoClient is flaky (enis: rev 1551385) /hbase/trunk/hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/DemoClient.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in hbase-0.96 #227 (See https://builds.apache.org/job/hbase-0.96/227/)
        HBASE-10163 Example Thrift DemoClient is flaky (enis: rev 1551388)

        • /hbase/branches/0.96/hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/DemoClient.java
        Show
        Hudson added a comment - SUCCESS: Integrated in hbase-0.96 #227 (See https://builds.apache.org/job/hbase-0.96/227/ ) HBASE-10163 Example Thrift DemoClient is flaky (enis: rev 1551388) /hbase/branches/0.96/hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/DemoClient.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in hbase-0.96-hadoop2 #151 (See https://builds.apache.org/job/hbase-0.96-hadoop2/151/)
        HBASE-10163 Example Thrift DemoClient is flaky (enis: rev 1551388)

        • /hbase/branches/0.96/hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/DemoClient.java
        Show
        Hudson added a comment - SUCCESS: Integrated in hbase-0.96-hadoop2 #151 (See https://builds.apache.org/job/hbase-0.96-hadoop2/151/ ) HBASE-10163 Example Thrift DemoClient is flaky (enis: rev 1551388) /hbase/branches/0.96/hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/DemoClient.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #4729 (See https://builds.apache.org/job/HBase-TRUNK/4729/)
        HBASE-10163 Example Thrift DemoClient is flaky (enis: rev 1551385)

        • /hbase/trunk/hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/DemoClient.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #4729 (See https://builds.apache.org/job/HBase-TRUNK/4729/ ) HBASE-10163 Example Thrift DemoClient is flaky (enis: rev 1551385) /hbase/trunk/hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/DemoClient.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #16 (See https://builds.apache.org/job/HBase-0.98/16/)
        HBASE-10163 Example Thrift DemoClient is flaky (enis: rev 1551387)

        • /hbase/branches/0.98/hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/DemoClient.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #16 (See https://builds.apache.org/job/HBase-0.98/16/ ) HBASE-10163 Example Thrift DemoClient is flaky (enis: rev 1551387) /hbase/branches/0.98/hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/DemoClient.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #13 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/13/)
        HBASE-10163 Example Thrift DemoClient is flaky (enis: rev 1551387)

        • /hbase/branches/0.98/hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/DemoClient.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #13 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/13/ ) HBASE-10163 Example Thrift DemoClient is flaky (enis: rev 1551387) /hbase/branches/0.98/hbase-examples/src/main/java/org/apache/hadoop/hbase/thrift/DemoClient.java
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

          People

          • Assignee:
            Enis Soztutar
            Reporter:
            Enis Soztutar
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development