HBase
  1. HBase
  2. HBASE-10159

Replaced deprecated interface Closeable

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.96.2, 0.99.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Hadoop interface Closeable has been deprecated for quite some time to favor java.io.Closeable. Since we support only hadoop 1.0 and above now, we can replace the deprecated Closeable with the java one. We can also clean up some hack we did as well, for example, HBASE-10029.

      https://github.com/apache/hadoop-common/blob/branch-1.0/src/core/org/apache/hadoop/io/Closeable.java

      1. trunk-10159_v2.patch
        2 kB
        Jimmy Xiang
      2. trunk-10159.patch
        3 kB
        Jimmy Xiang

        Issue Links

          Activity

          Hide
          Enis Soztutar added a comment -

          Closing this issue after 0.99.0 release.

          Show
          Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in hbase-0.96-hadoop2 #154 (See https://builds.apache.org/job/hbase-0.96-hadoop2/154/)
          HBASE-10159 Replaced deprecated interface Closeable (jxiang: rev 1551820)

          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java
          Show
          Hudson added a comment - FAILURE: Integrated in hbase-0.96-hadoop2 #154 (See https://builds.apache.org/job/hbase-0.96-hadoop2/154/ ) HBASE-10159 Replaced deprecated interface Closeable (jxiang: rev 1551820) /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in hbase-0.96 #232 (See https://builds.apache.org/job/hbase-0.96/232/)
          HBASE-10159 Replaced deprecated interface Closeable (jxiang: rev 1551820)

          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java
          Show
          Hudson added a comment - SUCCESS: Integrated in hbase-0.96 #232 (See https://builds.apache.org/job/hbase-0.96/232/ ) HBASE-10159 Replaced deprecated interface Closeable (jxiang: rev 1551820) /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.98 #20 (See https://builds.apache.org/job/HBase-0.98/20/)
          HBASE-10159 Replaced deprecated interface Closeable (jxiang: rev 1551770)

          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.98 #20 (See https://builds.apache.org/job/HBase-0.98/20/ ) HBASE-10159 Replaced deprecated interface Closeable (jxiang: rev 1551770) /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #16 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/16/)
          HBASE-10159 Replaced deprecated interface Closeable (jxiang: rev 1551770)

          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #16 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/16/ ) HBASE-10159 Replaced deprecated interface Closeable (jxiang: rev 1551770) /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #9 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/9/)
          HBASE-10159 Replaced deprecated interface Closeable (jxiang: rev 1551631)

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #9 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/9/ ) HBASE-10159 Replaced deprecated interface Closeable (jxiang: rev 1551631) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #4733 (See https://builds.apache.org/job/HBase-TRUNK/4733/)
          HBASE-10159 Replaced deprecated interface Closeable (jxiang: rev 1551631)

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #4733 (See https://builds.apache.org/job/HBase-TRUNK/4733/ ) HBASE-10159 Replaced deprecated interface Closeable (jxiang: rev 1551631) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java
          Hide
          Jimmy Xiang added a comment -

          Integrated into trunk. Thanks Stack for the review.

          Show
          Jimmy Xiang added a comment - Integrated into trunk. Thanks Stack for the review.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12619005/trunk-10159_v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          -1 core tests. The patch failed these unit tests:

          -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.TestAcidGuarantees.testScanAtomicity(TestAcidGuarantees.java:341)

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619005/trunk-10159_v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.TestAcidGuarantees.testScanAtomicity(TestAcidGuarantees.java:341) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8193//console This message is automatically generated.
          Hide
          stack added a comment -

          lgtm

          Show
          stack added a comment - lgtm
          Hide
          Jimmy Xiang added a comment -

          Attached v2.

          Show
          Jimmy Xiang added a comment - Attached v2.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12618668/trunk-10159.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.TestSplitLogWorker

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618668/trunk-10159.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestSplitLogWorker Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8165//console This message is automatically generated.
          Hide
          stack added a comment -

          +1 if hadoopqa is good w/ it.

          Show
          stack added a comment - +1 if hadoopqa is good w/ it.
          Hide
          Jimmy Xiang added a comment -

          It turns out only HFileSystem uses this deprecated interface.

          Show
          Jimmy Xiang added a comment - It turns out only HFileSystem uses this deprecated interface.

            People

            • Assignee:
              Jimmy Xiang
              Reporter:
              Jimmy Xiang
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development