HBase
  1. HBase
  2. HBASE-10148

[VisibilityController] Tolerate regions in recovery

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.98.0
    • Fix Version/s: 0.98.0, 0.99.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Ted Yu reports that enabling distributed log replay by default, like:

      Index: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
      ===================================================================
      --- hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java	(revision 1550575)
      +++ hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java	(working copy)
      @@ -794,7 +794,7 @@
      
         /** Conf key that enables unflushed WAL edits directly being replayed to region servers */
         public static final String DISTRIBUTED_LOG_REPLAY_KEY = "hbase.master.distributed.log.replay";
      -  public static final boolean DEFAULT_DISTRIBUTED_LOG_REPLAY_CONFIG = false;
      +  public static final boolean DEFAULT_DISTRIBUTED_LOG_REPLAY_CONFIG = true;
         public static final String DISALLOW_WRITES_IN_RECOVERING =
             "hbase.regionserver.disallow.writes.when.recovering";
         public static final boolean DEFAULT_DISALLOW_WRITES_IN_RECOVERING_CONFIG = false;
      

      causes TestVisibilityController#testAddVisibilityLabelsOnRSRestart to fail. It reveals an issue with label operations if the label table is recovering:

      2013-12-12 14:53:53,133 DEBUG [RpcServer.handler=2,port=58108] visibility.VisibilityController(1046): Adding the label XYZ2013-12-12 14:53:53,137 ERROR [RpcServer.handler=2,port=58108] visibility.VisibilityController(1074): org.apache.hadoop.hbase.exceptions.RegionInRecoveryException: hbase:labels,,1386888826648.f14a399ba85cbb42c2c3b7547bf17c65. is recovering
      2013-12-12 14:53:53,151 DEBUG [main] visibility.TestVisibilityLabels(405): response from addLabels: result {
        exception {
          name: "org.apache.hadoop.hbase.exceptions.RegionInRecoveryException"
          value: "org.apache.hadoop.hbase.exceptions.RegionInRecoveryException: hbase:labels,,1386888826648.f14a399ba85cbb42c2c3b7547bf17c65. is recovering at org.apache.hadoop.hbase.regionserver.HRegion.startRegionOperation(HRegion.java:5555) at org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:1763) at org.apache.hadoop.hbase.regionserver.HRegion.getScanner(HRegion.java:1749) at org.apache.hadoop.hbase.security.visibility.VisibilityController.getExistingLabelsWithAuths(VisibilityController.java:1096) at org.apache.hadoop.hbase.security.visibility.VisibilityController.postBatchMutate(VisibilityController.java:672)"
      

      Should we try to ride over this?

      1. HBASE-10148.patch
        11 kB
        Anoop Sam John
      2. HBASE-10148_V3.patch
        12 kB
        Anoop Sam John
      3. HBASE-10148_V2.patch
        12 kB
        Anoop Sam John

        Issue Links

          Activity

          Hide
          Ted Yu added a comment -

          Riding over the recovery is feasible.
          HRegion has this method:

            public boolean isRecovering() {
          
          Show
          Ted Yu added a comment - Riding over the recovery is feasible. HRegion has this method: public boolean isRecovering() {
          Hide
          Anoop Sam John added a comment -

          The issue is very clear now.
          When log replay is in place, postOpen() hook is getting called before any replay. In case of Visibility , we use this hook to read the existing labels and initialize the cache. So here what happens is the cache is getting no items at all. Also we calculate the next ordinal no# for adding label in this postOpen(). It comes as 1 again. While doing the 2 new entries write, it gets ordinals as 1 and 2 replacing some old labels !!!

          That is why the test fails with number of labels after adding 2 new labels (already 6 in place) as 6 only.

          Similar issue is there with AccessController also in which the existing data is cached in postOpen(). If some unflushed acls are in place, then those will be lost to get added into the cache (up on RS restart)..

          I am trying with possible solutions.

          Can we think of a hook with replay like postReplay() or so?

          Show
          Anoop Sam John added a comment - The issue is very clear now. When log replay is in place, postOpen() hook is getting called before any replay. In case of Visibility , we use this hook to read the existing labels and initialize the cache. So here what happens is the cache is getting no items at all. Also we calculate the next ordinal no# for adding label in this postOpen(). It comes as 1 again. While doing the 2 new entries write, it gets ordinals as 1 and 2 replacing some old labels !!! That is why the test fails with number of labels after adding 2 new labels (already 6 in place) as 6 only. Similar issue is there with AccessController also in which the existing data is cached in postOpen(). If some unflushed acls are in place, then those will be lost to get added into the cache (up on RS restart).. I am trying with possible solutions. Can we think of a hook with replay like postReplay() or so?
          Hide
          Andrew Purtell added a comment -

          Yes, a hook like postReplay could work. So we would check in postOpen if the region isn't ready yet and defer to the new hook to finish init. This also means we need to deny access to everything but the superuser until init is finished, but as long as we document this as he price one pays for security this should be ok.

          Show
          Andrew Purtell added a comment - Yes, a hook like postReplay could work. So we would check in postOpen if the region isn't ready yet and defer to the new hook to finish init. This also means we need to deny access to everything but the superuser until init is finished, but as long as we document this as he price one pays for security this should be ok.
          Hide
          Anoop Sam John added a comment -

          Yes exactly these way I am fixing this... Let me give patch with the new hook and some small changes in the replay flow.. I will give it in another Jira and this Jira will change only VisibilityController..
          Also Andy will you open a Jira for the corresponding change in the AccessController ?

          Show
          Anoop Sam John added a comment - Yes exactly these way I am fixing this... Let me give patch with the new hook and some small changes in the replay flow.. I will give it in another Jira and this Jira will change only VisibilityController.. Also Andy will you open a Jira for the corresponding change in the AccessController ?
          Hide
          Ted Yu added a comment -

          The following change may be needed so that VisibilityController can determine whether to wait for replay to complete:

          Index: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
          ===================================================================
          --- hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java	(revision 1550767)
          +++ hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java	(working copy)
          @@ -143,14 +143,14 @@
                 }
          
                 // check if we need set current region in recovering state
          -      region.setRecovering(false);
                 Map<String, HRegion> recoveringRegions = this.rsServices.getRecoveringRegions();
                 if (recoveringRegions != null && !recoveringRegions.isEmpty()
                     && recoveringRegions.containsKey(region.getRegionInfo().getEncodedName())) {
                   region.setRecovering(true);
                   recoveringRegions.put(region.getRegionInfo().getEncodedName(), region);
          -      }
          +      } else region.setRecovering(false);
          
          +
                 boolean failed = true;
                 if (tickleOpening("post_region_open")) {
                   if (updateMeta(region)) {
          
          Show
          Ted Yu added a comment - The following change may be needed so that VisibilityController can determine whether to wait for replay to complete: Index: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java =================================================================== --- hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java (revision 1550767) +++ hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java (working copy) @@ -143,14 +143,14 @@ } // check if we need set current region in recovering state - region.setRecovering( false ); Map< String , HRegion> recoveringRegions = this .rsServices.getRecoveringRegions(); if (recoveringRegions != null && !recoveringRegions.isEmpty() && recoveringRegions.containsKey(region.getRegionInfo().getEncodedName())) { region.setRecovering( true ); recoveringRegions.put(region.getRegionInfo().getEncodedName(), region); - } + } else region.setRecovering( false ); + boolean failed = true ; if (tickleOpening( "post_region_open" )) { if (updateMeta(region)) {
          Hide
          Andrew Purtell added a comment -

          Also Andy will you open a Jira for the corresponding change in the AccessController ?

          See HBASE-10161

          Show
          Andrew Purtell added a comment - Also Andy will you open a Jira for the corresponding change in the AccessController ? See HBASE-10161
          Hide
          Andrew Purtell added a comment -

          Hey Anoop Sam John I see now you already opened HBASE-10160. I'm going to close that as a dup since you asked me to open an issue and then went ahead and did it yourself.

          Show
          Andrew Purtell added a comment - Hey Anoop Sam John I see now you already opened HBASE-10160 . I'm going to close that as a dup since you asked me to open an issue and then went ahead and did it yourself.
          Hide
          Anoop Sam John added a comment - - edited

          No problems Andy..I should have been waiting for some more time I will attach a fix once we conclude on the new hook and HBASE-10155.

          Show
          Anoop Sam John added a comment - - edited No problems Andy..I should have been waiting for some more time I will attach a fix once we conclude on the new hook and HBASE-10155 .
          Hide
          Andrew Purtell added a comment -

          Patch is basically ok.

          +          new RegionInRecoveryException("Labels table is recovering"), response);
          

          We should say something about the VisibilityController not yet being initialized instead.

          In TestVisibilityLabels, waitForLabelsRegionAvailability could be rewritten using Predicates with timeouts.

          Show
          Andrew Purtell added a comment - Patch is basically ok. + new RegionInRecoveryException("Labels table is recovering"), response); We should say something about the VisibilityController not yet being initialized instead. In TestVisibilityLabels, waitForLabelsRegionAvailability could be rewritten using Predicates with timeouts.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12619008/HBASE-10148.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619008/HBASE-10148.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8194//console This message is automatically generated.
          Hide
          ramkrishna.s.vasudevan added a comment -

          Patch looks good to me apart from that log msg as told by Andy.

          Show
          ramkrishna.s.vasudevan added a comment - Patch looks good to me apart from that log msg as told by Andy.
          Hide
          Anoop Sam John added a comment - - edited

          Patch fixing comments

          Show
          Anoop Sam John added a comment - - edited Patch fixing comments
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12619042/HBASE-10148_V2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.replication.TestReplicationSyncUpTool

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619042/HBASE-10148_V2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplicationSyncUpTool Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8200//console This message is automatically generated.
          Hide
          Anoop Sam John added a comment -

          Don't think failure in TestReplicationSyncUpTool is related to this patch

          Show
          Anoop Sam John added a comment - Don't think failure in TestReplicationSyncUpTool is related to this patch
          Hide
          Anoop Sam John added a comment -

          ramkrishna.s.vasudevan, Andrew Purtell you guys fine with patch V2 ?

          Show
          Anoop Sam John added a comment - ramkrishna.s.vasudevan , Andrew Purtell you guys fine with patch V2 ?
          Hide
          ramkrishna.s.vasudevan added a comment -

          +1

          Show
          ramkrishna.s.vasudevan added a comment - +1
          Hide
          Andrew Purtell added a comment - - edited

          I don't think RegionInRecoveryException is the correct exception to throw. The CP is not initialized yet. There could be other causes besides the region being in recovery, such as an RPC before the CP is initialized.

          Show
          Andrew Purtell added a comment - - edited I don't think RegionInRecoveryException is the correct exception to throw. The CP is not initialized yet. There could be other causes besides the region being in recovery, such as an RPC before the CP is initialized.
          Hide
          Anoop Sam John added a comment -

          Got ur concern now Andy.. There is CoprocessorException , can we use that?

          Show
          Anoop Sam John added a comment - Got ur concern now Andy.. There is CoprocessorException , can we use that?
          Hide
          Andrew Purtell added a comment -

          There is CoprocessorException , can we use that

          Sounds good to me.

          Show
          Andrew Purtell added a comment - There is CoprocessorException , can we use that Sounds good to me.
          Hide
          Andrew Purtell added a comment -

          +1 on V3 patch

          Show
          Andrew Purtell added a comment - +1 on V3 patch
          Hide
          Anoop Sam John added a comment -

          Woww.. that is super fast... Thanks Andy...
          Will commit once QA passes with V3 patch.

          Show
          Anoop Sam John added a comment - Woww.. that is super fast... Thanks Andy... Will commit once QA passes with V3 patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12619247/HBASE-10148_V3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.security.visibility.TestVisibilityLabels

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619247/HBASE-10148_V3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.security.visibility.TestVisibilityLabels Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8208//console This message is automatically generated.
          Hide
          Anoop Sam John added a comment -

          Attaching again for QA to start

          Show
          Anoop Sam John added a comment - Attaching again for QA to start
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12619263/HBASE-10148_V3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12619263/HBASE-10148_V3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8210//console This message is automatically generated.
          Hide
          Anoop Sam John added a comment -

          org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort passing locally.

          Show
          Anoop Sam John added a comment - org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort passing locally.
          Hide
          Anoop Sam John added a comment -

          Committed to trunk and 0.98. Thanks for the reviews

          Show
          Anoop Sam John added a comment - Committed to trunk and 0.98. Thanks for the reviews
          Hide
          Andrew Purtell added a comment -

          Thanks Anoop.

          Show
          Andrew Purtell added a comment - Thanks Anoop.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #18 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/18/)
          HBASE-10148 [VisibilityController] Tolerate regions in recovery (anoopsamjohn: rev 1552020)

          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
          • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #18 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/18/ ) HBASE-10148 [VisibilityController] Tolerate regions in recovery (anoopsamjohn: rev 1552020) /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98 #21 (See https://builds.apache.org/job/HBase-0.98/21/)
          HBASE-10148 [VisibilityController] Tolerate regions in recovery (anoopsamjohn: rev 1552020)

          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
          • /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #21 (See https://builds.apache.org/job/HBase-0.98/21/ ) HBASE-10148 [VisibilityController] Tolerate regions in recovery (anoopsamjohn: rev 1552020) /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java /hbase/branches/0.98/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #4736 (See https://builds.apache.org/job/HBase-TRUNK/4736/)
          HBASE-10148 [VisibilityController] Tolerate regions in recovery (anoopsamjohn: rev 1552021)

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4736 (See https://builds.apache.org/job/HBase-TRUNK/4736/ ) HBASE-10148 [VisibilityController] Tolerate regions in recovery (anoopsamjohn: rev 1552021) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #11 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/11/)
          HBASE-10148 [VisibilityController] Tolerate regions in recovery (anoopsamjohn: rev 1552021)

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
          • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #11 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/11/ ) HBASE-10148 [VisibilityController] Tolerate regions in recovery (anoopsamjohn: rev 1552021) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java

            People

            • Assignee:
              Anoop Sam John
              Reporter:
              Andrew Purtell
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development