HBase
  1. HBase
  2. HBASE-10125

KeyValue(Cell c) copy constructor doesn't copy tags data

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.98.0
    • Fix Version/s: 0.98.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I happened to come across this:

        public KeyValue(Cell c) {
          this(c.getRowArray(), c.getRowOffset(), (int)c.getRowLength(),
              c.getFamilyArray(), c.getFamilyOffset(), (int)c.getFamilyLength(), 
              c.getQualifierArray(), c.getQualifierOffset(), (int) c.getQualifierLength(),
              c.getTimestamp(), Type.codeToType(c.getTypeByte()), 
              c.getValueArray(), c.getValueOffset(), c.getValueLength());
        }
      
      1. hbase-10125.patch
        1 kB
        Jeffrey Zhong

        Activity

        Hide
        Ted Yu added a comment -

        lgtm

        Nice finding, Jeff.

        Show
        Ted Yu added a comment - lgtm Nice finding, Jeff.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12618165/hbase-10125.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618165/hbase-10125.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8130//console This message is automatically generated.
        Hide
        Andrew Purtell added a comment -

        Nice one, blocker for 0.98

        Show
        Andrew Purtell added a comment - Nice one, blocker for 0.98
        Hide
        ramkrishna.s.vasudevan added a comment -

        Good find. Is this a blocker?
        Currenly not used any where in the src code except for one test case I suppose.

        Show
        ramkrishna.s.vasudevan added a comment - Good find. Is this a blocker? Currenly not used any where in the src code except for one test case I suppose.
        Hide
        Andrew Purtell added a comment -

        I made it a blocker because of the potential for accidents.

        Show
        Andrew Purtell added a comment - I made it a blocker because of the potential for accidents.
        Hide
        Jeffrey Zhong added a comment -

        Thanks for the reviews! I've integrated the small fix into trunk & 0.98 branch. Thanks.

        Show
        Jeffrey Zhong added a comment - Thanks for the reviews! I've integrated the small fix into trunk & 0.98 branch. Thanks.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #4 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/4/)
        HBASE-10125: KeyValue(Cell c) copy constructor doesn't copy tags data (jeffreyz: rev 1550222)

        • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #4 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/4/ ) HBASE-10125 : KeyValue(Cell c) copy constructor doesn't copy tags data (jeffreyz: rev 1550222) /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #6 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/6/)
        HBASE-10125: KeyValue(Cell c) copy constructor doesn't copy tags data (jeffreyz: rev 1550224)

        • /hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #6 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/6/ ) HBASE-10125 : KeyValue(Cell c) copy constructor doesn't copy tags data (jeffreyz: rev 1550224) /hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #4720 (See https://builds.apache.org/job/HBase-TRUNK/4720/)
        HBASE-10125: KeyValue(Cell c) copy constructor doesn't copy tags data (jeffreyz: rev 1550222)

        • /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4720 (See https://builds.apache.org/job/HBase-TRUNK/4720/ ) HBASE-10125 : KeyValue(Cell c) copy constructor doesn't copy tags data (jeffreyz: rev 1550222) /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-0.98 #8 (See https://builds.apache.org/job/HBase-0.98/8/)
        HBASE-10125: KeyValue(Cell c) copy constructor doesn't copy tags data (jeffreyz: rev 1550224)

        • /hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-0.98 #8 (See https://builds.apache.org/job/HBase-0.98/8/ ) HBASE-10125 : KeyValue(Cell c) copy constructor doesn't copy tags data (jeffreyz: rev 1550224) /hbase/branches/0.98/hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java

          People

          • Assignee:
            Jeffrey Zhong
            Reporter:
            Jeffrey Zhong
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development