HBase
  1. HBase
  2. HBASE-10098

[WINDOWS] pass in native library directory from hadoop for unit tests

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.96.2, 0.99.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      On windows, Hadoop depends on native libraries for doing it's job. The bin scripts already handle finding hadoop's native libs and adding them to java.library.path, but for running HBase's unit tests, we need to pass them in.

      1. hbase-10098_v3.patch
        0.8 kB
        Enis Soztutar
      2. hbase-10098_v2.patch
        0.7 kB
        Enis Soztutar
      3. hbase-10098_v1.patch
        1 kB
        Enis Soztutar

        Activity

        Hide
        Enis Soztutar added a comment -

        Simple patch, allowing to pass -Dhadoop.library.path, which is passed as surefire forked processes as -Djava.library.path.

        Show
        Enis Soztutar added a comment - Simple patch, allowing to pass -Dhadoop.library.path, which is passed as surefire forked processes as -Djava.library.path.
        Hide
        Nick Dimiduk added a comment -

        Does this override an existing value of java.library.path with the value of hadoop.library.path? Can they be concatenated?

        Show
        Nick Dimiduk added a comment - Does this override an existing value of java.library.path with the value of hadoop.library.path? Can they be concatenated?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12617452/hbase-10098_v1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12617452/hbase-10098_v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8074//console This message is automatically generated.
        Hide
        Enis Soztutar added a comment -

        This is the args that we pass to the maven's child process which is forked to the unit test. I don't think maven passes it's own arguments to the child task.

        Show
        Enis Soztutar added a comment - This is the args that we pass to the maven's child process which is forked to the unit test. I don't think maven passes it's own arguments to the child task.
        Hide
        Nick Dimiduk added a comment -

        Okay. Would it be useful to propagate the parent process arguments in addition to what you have here?

        +1.

        Show
        Nick Dimiduk added a comment - Okay. Would it be useful to propagate the parent process arguments in addition to what you have here? +1.
        Hide
        Enis Soztutar added a comment -

        Okay. Would it be useful to propagate the parent process arguments in addition to what you have here?

        Makes sense. v2 patch adds that.

        Show
        Enis Soztutar added a comment - Okay. Would it be useful to propagate the parent process arguments in addition to what you have here? Makes sense. v2 patch adds that.
        Hide
        Nick Dimiduk added a comment -

        lgtm.

        Show
        Nick Dimiduk added a comment - lgtm.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12617488/hbase-10098_v2.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8078//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12617488/hbase-10098_v2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8078//console This message is automatically generated.
        Hide
        Enis Soztutar added a comment -

        Committed this. Thanks Nick for review.

        Show
        Enis Soztutar added a comment - Committed this. Thanks Nick for review.
        Hide
        Enis Soztutar added a comment -

        Attaching committed patch, which applies cleanly.

        Show
        Enis Soztutar added a comment - Attaching committed patch, which applies cleanly.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in hbase-0.96-hadoop2 #151 (See https://builds.apache.org/job/hbase-0.96-hadoop2/151/)
        HBASE-10098 [WINDOWS] pass in native library directory from hadoop for unit tests (enis: rev 1551430)

        • /hbase/branches/0.96/pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in hbase-0.96-hadoop2 #151 (See https://builds.apache.org/job/hbase-0.96-hadoop2/151/ ) HBASE-10098 [WINDOWS] pass in native library directory from hadoop for unit tests (enis: rev 1551430) /hbase/branches/0.96/pom.xml
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #4729 (See https://builds.apache.org/job/HBase-TRUNK/4729/)
        HBASE-10098 [WINDOWS] pass in native library directory from hadoop for unit tests (enis: rev 1551425)

        • /hbase/trunk/pom.xml
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #4729 (See https://builds.apache.org/job/HBase-TRUNK/4729/ ) HBASE-10098 [WINDOWS] pass in native library directory from hadoop for unit tests (enis: rev 1551425) /hbase/trunk/pom.xml
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #16 (See https://builds.apache.org/job/HBase-0.98/16/)
        HBASE-10098 [WINDOWS] pass in native library directory from hadoop for unit tests (enis: rev 1551429)

        • /hbase/branches/0.98/pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #16 (See https://builds.apache.org/job/HBase-0.98/16/ ) HBASE-10098 [WINDOWS] pass in native library directory from hadoop for unit tests (enis: rev 1551429) /hbase/branches/0.98/pom.xml
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #13 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/13/)
        HBASE-10098 [WINDOWS] pass in native library directory from hadoop for unit tests (enis: rev 1551429)

        • /hbase/branches/0.98/pom.xml
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #13 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/13/ ) HBASE-10098 [WINDOWS] pass in native library directory from hadoop for unit tests (enis: rev 1551429) /hbase/branches/0.98/pom.xml
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96 #228 (See https://builds.apache.org/job/hbase-0.96/228/)
        HBASE-10098 [WINDOWS] pass in native library directory from hadoop for unit tests (enis: rev 1551430)

        • /hbase/branches/0.96/pom.xml
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96 #228 (See https://builds.apache.org/job/hbase-0.96/228/ ) HBASE-10098 [WINDOWS] pass in native library directory from hadoop for unit tests (enis: rev 1551430) /hbase/branches/0.96/pom.xml
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #9 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/9/)
        HBASE-10098 [WINDOWS] pass in native library directory from hadoop for unit tests (enis: rev 1551425)

        • /hbase/trunk/pom.xml
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #9 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/9/ ) HBASE-10098 [WINDOWS] pass in native library directory from hadoop for unit tests (enis: rev 1551425) /hbase/trunk/pom.xml
        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

          People

          • Assignee:
            Enis Soztutar
            Reporter:
            Enis Soztutar
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development