Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-10093

Unregister ReplicationSource metric bean when the replication source thread is terminated

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.94.14
    • Fix Version/s: 0.94.15
    • Component/s: Replication
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Each replication source thread will register a metric bean to show its statistics. The source threads will be terminated when region server exit and the metric beans will be removed. However, replication source thread may also be terminated when user removing the peer explicitly or it just takes a recover queue and finished replicating the queued HLogs. In these situations, the metric bean won't be unregistered and user may be confused to always see the statistics from terminated replication source threads. Maybe, it is more clear to remove the metric bean after replication source thread terminated? Then, the statistics will only from active replication sources.

        Activity

        Hide
        cuijianwei Jianwei Cui added a comment -

        This patch will make replication source stop report metrics when be terminated.

        Show
        cuijianwei Jianwei Cui added a comment - This patch will make replication source stop report metrics when be terminated.
        Hide
        andylee andylee added a comment -

        +1,A improvement for replication metrics.

        Show
        andylee andylee added a comment - +1,A improvement for replication metrics.
        Hide
        lhofhansl Lars Hofhansl added a comment -

        Good find. Let me take a closer look tomorrow.

        Show
        lhofhansl Lars Hofhansl added a comment - Good find. Let me take a closer look tomorrow.
        Hide
        lhofhansl Lars Hofhansl added a comment -

        Committed to 0.94. Thanks for the patch.

        Show
        lhofhansl Lars Hofhansl added a comment - Committed to 0.94. Thanks for the patch.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94-security #354 (See https://builds.apache.org/job/HBase-0.94-security/354/)
        HBASE-10093 Unregister ReplicationSource metric bean when the replication source thread is terminated (cuijianwei) (larsh: rev 1548802)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceMetrics.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationStatistics.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.94-security #354 (See https://builds.apache.org/job/HBase-0.94-security/354/ ) HBASE-10093 Unregister ReplicationSource metric bean when the replication source thread is terminated (cuijianwei) (larsh: rev 1548802) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceMetrics.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationStatistics.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in HBase-0.94 #1220 (See https://builds.apache.org/job/HBase-0.94/1220/)
        HBASE-10093 Unregister ReplicationSource metric bean when the replication source thread is terminated (cuijianwei) (larsh: rev 1548802)

        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceMetrics.java
        • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationStatistics.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.94 #1220 (See https://builds.apache.org/job/HBase-0.94/1220/ ) HBASE-10093 Unregister ReplicationSource metric bean when the replication source thread is terminated (cuijianwei) (larsh: rev 1548802) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceMetrics.java /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationStatistics.java

          People

          • Assignee:
            cuijianwei Jianwei Cui
            Reporter:
            cuijianwei Jianwei Cui
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development