HBase
  1. HBase
  2. HBASE-10084

[WINDOWS] bin\hbase.cmd should allow whitespaces in java.library.path and classpath

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.98.0, 0.96.2, 0.99.0
    • Component/s: scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In case CLASSPATH or java.library.path from hadoop or HBASE_HOME contains directories with names containing whitespaces, the bin script splits out errors. We can fix the ws handling hopefully once and for all (or not)

        Activity

        Hide
        Enis Soztutar added a comment -

        Closing this issue after 0.99.0 release.

        Show
        Enis Soztutar added a comment - Closing this issue after 0.99.0 release.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #9 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/9/)
        HBASE-10084 [WINDOWS] bin\hbase.cmd should allow whitespaces in java.library.path and classpath (enis: rev 1551433)

        • /hbase/trunk/bin/hbase-config.cmd
        • /hbase/trunk/bin/hbase.cmd
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK-on-Hadoop-1.1 #9 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/9/ ) HBASE-10084 [WINDOWS] bin\hbase.cmd should allow whitespaces in java.library.path and classpath (enis: rev 1551433) /hbase/trunk/bin/hbase-config.cmd /hbase/trunk/bin/hbase.cmd
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #4730 (See https://builds.apache.org/job/HBase-TRUNK/4730/)
        HBASE-10084 [WINDOWS] bin\hbase.cmd should allow whitespaces in java.library.path and classpath (enis: rev 1551433)

        • /hbase/trunk/bin/hbase-config.cmd
        • /hbase/trunk/bin/hbase.cmd
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #4730 (See https://builds.apache.org/job/HBase-TRUNK/4730/ ) HBASE-10084 [WINDOWS] bin\hbase.cmd should allow whitespaces in java.library.path and classpath (enis: rev 1551433) /hbase/trunk/bin/hbase-config.cmd /hbase/trunk/bin/hbase.cmd
        Hide
        Hudson added a comment -

        FAILURE: Integrated in hbase-0.96 #228 (See https://builds.apache.org/job/hbase-0.96/228/)
        HBASE-10084 [WINDOWS] bin\hbase.cmd should allow whitespaces in java.library.path and classpath (enis: rev 1551436)

        • /hbase/branches/0.96/bin/hbase-config.cmd
        • /hbase/branches/0.96/bin/hbase.cmd
        Show
        Hudson added a comment - FAILURE: Integrated in hbase-0.96 #228 (See https://builds.apache.org/job/hbase-0.96/228/ ) HBASE-10084 [WINDOWS] bin\hbase.cmd should allow whitespaces in java.library.path and classpath (enis: rev 1551436) /hbase/branches/0.96/bin/hbase-config.cmd /hbase/branches/0.96/bin/hbase.cmd
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #13 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/13/)
        HBASE-10084 [WINDOWS] bin\hbase.cmd should allow whitespaces in java.library.path and classpath (enis: rev 1551435)

        • /hbase/branches/0.98/bin/hbase-config.cmd
        • /hbase/branches/0.98/bin/hbase.cmd
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #13 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/13/ ) HBASE-10084 [WINDOWS] bin\hbase.cmd should allow whitespaces in java.library.path and classpath (enis: rev 1551435) /hbase/branches/0.98/bin/hbase-config.cmd /hbase/branches/0.98/bin/hbase.cmd
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-0.98 #16 (See https://builds.apache.org/job/HBase-0.98/16/)
        HBASE-10084 [WINDOWS] bin\hbase.cmd should allow whitespaces in java.library.path and classpath (enis: rev 1551435)

        • /hbase/branches/0.98/bin/hbase-config.cmd
        • /hbase/branches/0.98/bin/hbase.cmd
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #16 (See https://builds.apache.org/job/HBase-0.98/16/ ) HBASE-10084 [WINDOWS] bin\hbase.cmd should allow whitespaces in java.library.path and classpath (enis: rev 1551435) /hbase/branches/0.98/bin/hbase-config.cmd /hbase/branches/0.98/bin/hbase.cmd
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in hbase-0.96-hadoop2 #151 (See https://builds.apache.org/job/hbase-0.96-hadoop2/151/)
        HBASE-10084 [WINDOWS] bin\hbase.cmd should allow whitespaces in java.library.path and classpath (enis: rev 1551436)

        • /hbase/branches/0.96/bin/hbase-config.cmd
        • /hbase/branches/0.96/bin/hbase.cmd
        Show
        Hudson added a comment - SUCCESS: Integrated in hbase-0.96-hadoop2 #151 (See https://builds.apache.org/job/hbase-0.96-hadoop2/151/ ) HBASE-10084 [WINDOWS] bin\hbase.cmd should allow whitespaces in java.library.path and classpath (enis: rev 1551436) /hbase/branches/0.96/bin/hbase-config.cmd /hbase/branches/0.96/bin/hbase.cmd
        Hide
        Enis Soztutar added a comment -

        Committed this. Thanks Sergey for review.

        Show
        Enis Soztutar added a comment - Committed this. Thanks Sergey for review.
        Hide
        Sergey Shelukhin added a comment -

        +1

        Show
        Sergey Shelukhin added a comment - +1
        Hide
        Enis Soztutar added a comment -

        Thanks for looking.
        We don't use %CD% in the classpath, and the linux script does not add it. I removed that to keep the script consistent across platforms.

        @J-M, agreed, although it is not common to have whitespaces in the directory names in linux. We can do it in a follow up issue.

        Show
        Enis Soztutar added a comment - Thanks for looking. We don't use %CD% in the classpath, and the linux script does not add it. I removed that to keep the script consistent across platforms. @J-M, agreed, although it is not common to have whitespaces in the directory names in linux. We can do it in a follow up issue.
        Hide
        Sergey Shelukhin added a comment -

        Why did some code, like %CD%, usage of in_dev_env, got removed? otherwise looks reasonable. nit from existing code - comments in cmd file speak about sh file.
        Do you want to respond to J-M's comment?

        Show
        Sergey Shelukhin added a comment - Why did some code, like %CD%, usage of in_dev_env, got removed? otherwise looks reasonable. nit from existing code - comments in cmd file speak about sh file. Do you want to respond to J-M's comment?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12617106/hbase-10084_v1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12617106/hbase-10084_v1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8060//console This message is automatically generated.
        Hide
        Enis Soztutar added a comment -

        This should do the trick. I've tested it with a JAVA_HOME and HBASE_HOME containing spaces.

        Show
        Enis Soztutar added a comment - This should do the trick. I've tested it with a JAVA_HOME and HBASE_HOME containing spaces.
        Hide
        Jean-Marc Spaggiari added a comment -

        I don't think this is specific to window$. Even under Linux I think we should allow whitespaces in the different paths.

        Show
        Jean-Marc Spaggiari added a comment - I don't think this is specific to window$. Even under Linux I think we should allow whitespaces in the different paths.

          People

          • Assignee:
            Enis Soztutar
            Reporter:
            Enis Soztutar
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development