HBase
  1. HBase
  2. HBASE-10004

Some fixes for scoping sequence Ids to region level

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.98.0
    • Fix Version/s: 0.98.0
    • Component/s: wal
    • Labels:
      None

      Description

      While looking at trunk, I figured out some issues related to fix provided in HBASE-8741. This jira is to fix them:

      1) Not so helpful log message in FSHLog#getFileNumFromFileName.

      2) HLogPE verify method, the region:sequenceId map was not getting updated.

      3) reverse use of assertEquals arguments in TestHLog#testFindMemStoresEligibleForFlush.

      1. 10004.patch
        4 kB
        Himanshu Vashishtha
      2. 10004.patch
        4 kB
        Himanshu Vashishtha

        Activity

        Hide
        Himanshu Vashishtha added a comment -

        Attached is a patch to fix them. Ran TestHLog multiple times; Ran HLogPE with 5 threads for 10000 iterations multiple times. They all pass.

        Show
        Himanshu Vashishtha added a comment - Attached is a patch to fix them. Ran TestHLog multiple times; Ran HLogPE with 5 threads for 10000 iterations multiple times. They all pass.
        Hide
        Himanshu Vashishtha added a comment -

        With correct formatting.

        Show
        Himanshu Vashishtha added a comment - With correct formatting.
        Hide
        Matteo Bertozzi added a comment -

        +1 looks good to me

        Show
        Matteo Bertozzi added a comment - +1 looks good to me
        Hide
        Himanshu Vashishtha added a comment -

        Thanks for the review Matteo.

        Show
        Himanshu Vashishtha added a comment - Thanks for the review Matteo.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12614671/10004.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

        +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.

        -1 javadoc. The javadoc tool appears to have generated 9 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 lineLengths. The patch does not introduce lines longer than 100

        -1 site. The patch appears to cause mvn site goal to fail.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12614671/10004.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 6 new or modified tests. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop2.0 . The patch compiles against the hadoop 2.0 profile. -1 javadoc . The javadoc tool appears to have generated 9 warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/7937//console This message is automatically generated.
        Hide
        Matteo Bertozzi added a comment -

        committed to trunk, thanks for the patch!

        Show
        Matteo Bertozzi added a comment - committed to trunk, thanks for the patch!
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #4689 (See https://builds.apache.org/job/HBase-TRUNK/4689/)
        HBASE-10004 Some fixes for scoping sequence Ids to region level (Himanshu Vashishtha) (mbertozzi: rev 1543658)

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #4689 (See https://builds.apache.org/job/HBase-TRUNK/4689/ ) HBASE-10004 Some fixes for scoping sequence Ids to region level (Himanshu Vashishtha) (mbertozzi: rev 1543658) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #845 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/845/)
        HBASE-10004 Some fixes for scoping sequence Ids to region level (Himanshu Vashishtha) (mbertozzi: rev 1543658)

        • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java
        • /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #845 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/845/ ) HBASE-10004 Some fixes for scoping sequence Ids to region level (Himanshu Vashishtha) (mbertozzi: rev 1543658) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSHLog.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/HLogPerformanceEvaluation.java /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java

          People

          • Assignee:
            Himanshu Vashishtha
            Reporter:
            Himanshu Vashishtha
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development