Harmony
  1. Harmony
  2. HARMONY-92

Suggestion: Move com.ibm.platform from NIO to LUNI

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Classlib
    • Labels:
      None

      Description

      Hello Tim,

      As we discussed in JIRA 27 and JIRA 42, I suggest we move the packages com.ibm.platform and com.ibm.platform.struct from NIO to LUNI component. As these packages are used by java.net, as well as java.nio.channels. I will post the proposed fix soon

      1. refactor_platform.zip
        131 kB
        Richard Liang
      2. new.refactor.tar.gz
        29 kB
        Mark Hindess
      3. 06.remove-obsolete.sh
        0.4 kB
        Mark Hindess

        Issue Links

          Activity

          Hide
          Tim Ellison added a comment -

          Verified by Mark

          Show
          Tim Ellison added a comment - Verified by Mark
          Hide
          Mark Hindess added a comment -

          Looks good. Thanks Tim.

          Show
          Mark Hindess added a comment - Looks good. Thanks Tim.
          Hide
          Tim Ellison added a comment -

          Mark / Richard,

          Thanks for the patches & instructions.

          The 'platform' code has been moved from NIO to LUNI at repo revision 383849.

          Please check that the patches were applied as you expected.

          Show
          Tim Ellison added a comment - Mark / Richard, Thanks for the patches & instructions. The 'platform' code has been moved from NIO to LUNI at repo revision 383849. Please check that the patches were applied as you expected.
          Hide
          Richard Liang added a comment -

          Hello Mark,

          I think your patch is what I can though I just re-play your patch manually because I have no permission to check-in
          Thanks a lot.

          Show
          Richard Liang added a comment - Hello Mark, I think your patch is what I can though I just re-play your patch manually because I have no permission to check-in Thanks a lot.
          Hide
          Mark Hindess added a comment -

          If you apply my changes then a number of files are no longer required. The 06 script removes them.

          Show
          Mark Hindess added a comment - If you apply my changes then a number of files are no longer required. The 06 script removes them.
          Hide
          Mark Hindess added a comment -

          I've created a new version of these changes (from scratch to avoid provenance issues giving Geir headaches).

          There are scripts and patches numbered in order that they should be applied. It's broken down in to two stages - the nio to luni move and the rename. Check the README for details.

          Richard, let me know if I've missed anything. Thanks.

          Show
          Mark Hindess added a comment - I've created a new version of these changes (from scratch to avoid provenance issues giving Geir headaches). There are scripts and patches numbered in order that they should be applied. It's broken down in to two stages - the nio to luni move and the rename. Check the README for details. Richard, let me know if I've missed anything. Thanks.
          Hide
          Richard Liang added a comment -

          Hello,
          Here is the patch for this issue.

          1. For java source, it's more convenient to use Eclipse's refact->move, rename (You can also copy files from the attachment)
          2. For native source, please copy files from the attachment, then apply the patch file.
          (Though there are only some copy, paste, delete, and rename operations, we have done it for you.)

          Thanks a lot.

          Show
          Richard Liang added a comment - Hello, Here is the patch for this issue. 1. For java source, it's more convenient to use Eclipse's refact->move, rename (You can also copy files from the attachment) 2. For native source, please copy files from the attachment, then apply the patch file. (Though there are only some copy, paste, delete, and rename operations, we have done it for you.) Thanks a lot.
          Hide
          Richard Liang added a comment -

          According to the "package naming convention" (http://incubator.apache.org/harmony/subcomponents/classlibrary/pkgnaming.html), I suggest we rename com.ibm.platform to org.apache.harmony.luni.platform, and com.ibm.platform.struct to org.apache.harmony.luni.platform.struct

          Any comments?

          Show
          Richard Liang added a comment - According to the "package naming convention" ( http://incubator.apache.org/harmony/subcomponents/classlibrary/pkgnaming.html ), I suggest we rename com.ibm.platform to org.apache.harmony.luni.platform, and com.ibm.platform.struct to org.apache.harmony.luni.platform.struct Any comments?

            People

            • Assignee:
              Tim Ellison
              Reporter:
              Richard Liang
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development