Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0M15
    • Component/s: Classlib
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      Spec - http://java.sun.com/j2se/1.4.2/docs/api/javax/imageio/ImageTypeSpecifier.html#createIndexed(byte[], byte[], byte[], byte[], int, int)

      The implementation is really straight forward, after validate the parameters. Use IndexColorModel to instantiate ColorModel, and create compatible SampleModel

        Activity

        Lang Yang created issue -
        Lang Yang made changes -
        Field Original Value New Value
        Attachment HARMONY-6562.diff [ 12448176 ]
        Hide
        Tim Ellison added a comment -

        Thanks Lang.

        I applied your patch to the imageio module at repo revision r958590.

        I merged the test case into the class created for HARMONY-6563, and updated the manifest with a new module dependency.

        Please check it was applied as you expected.

        Show
        Tim Ellison added a comment - Thanks Lang. I applied your patch to the imageio module at repo revision r958590. I merged the test case into the class created for HARMONY-6563 , and updated the manifest with a new module dependency. Please check it was applied as you expected.
        Tim Ellison made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Tim Ellison [ tellison ]
        Fix Version/s 5.0M15 [ 12315054 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Harmony-1.5-head-linux-x86_64 #868 (See http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/868/)
        Apply patch for HARMONY-6562 (Implement ImageTypeSpecifier.createIndexed())
        Add new dependency on BigInteger (via IndexColorModel constructor)

        Show
        Hudson added a comment - Integrated in Harmony-1.5-head-linux-x86_64 #868 (See http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/868/ ) Apply patch for HARMONY-6562 (Implement ImageTypeSpecifier.createIndexed()) Add new dependency on BigInteger (via IndexColorModel constructor)
        Hide
        Hudson added a comment -

        Integrated in Harmony-select-1.5-head-linux-x86_64 #44 (See http://hudson.zones.apache.org/hudson/job/Harmony-select-1.5-head-linux-x86_64/44/)
        Apply patch for HARMONY-6562 (Implement ImageTypeSpecifier.createIndexed())
        Add new dependency on BigInteger (via IndexColorModel constructor)

        Show
        Hudson added a comment - Integrated in Harmony-select-1.5-head-linux-x86_64 #44 (See http://hudson.zones.apache.org/hudson/job/Harmony-select-1.5-head-linux-x86_64/44/ ) Apply patch for HARMONY-6562 (Implement ImageTypeSpecifier.createIndexed()) Add new dependency on BigInteger (via IndexColorModel constructor)
        Hide
        Mark Hindess added a comment -

        FYI: The assertEquals statements in the test in this patch had the actual and expected values the wrong way around. I've fixed this in commit r958660.

        Show
        Mark Hindess added a comment - FYI: The assertEquals statements in the test in this patch had the actual and expected values the wrong way around. I've fixed this in commit r958660.
        Hide
        Lang Yang added a comment -

        Thanks Tim and Mark! The patch has been applied correct.

        Show
        Lang Yang added a comment - Thanks Tim and Mark! The patch has been applied correct.
        Lang Yang made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        8h 27m 1 Tim Ellison 28/Jun/10 15:32
        Resolved Resolved Closed Closed
        7d 13h 51m 1 Lang Yang 06/Jul/10 05:23

          People

          • Assignee:
            Tim Ellison
            Reporter:
            Lang Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development