Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0M15
    • Component/s: Classlib
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      Implemented method ServiceRegistry.deregisterServiceProvider(java.lang.Object, java.lang.Class)

      Spec - http://java.sun.com/j2se/1.4.2/docs/api/javax/imageio/spi/ServiceRegistry.html#deregisterServiceProvider(java.lang.Object, java.lang.Class)

        Activity

        Lang Yang created issue -
        Lang Yang made changes -
        Field Original Value New Value
        Attachment patch.diff [ 12445230 ]
        Lang Yang made changes -
        Attachment patch.diff [ 12445230 ]
        Lang Yang made changes -
        Attachment HARMONY-6518.diff [ 12446767 ]
        Tim Ellison made changes -
        Assignee Tim Ellison [ tellison ]
        Hide
        Tim Ellison added a comment -

        Thanks Lang.

        Patch applied to imageio module at repo revision r953364.

        Please check it was applied as you expected.

        p.s. we tend to use (foo == null) rather than the other way around, though I understand why you may do it that way. Better to follow the established style, and in any case removeProvider(Object,Class) has it both ways round!

        Show
        Tim Ellison added a comment - Thanks Lang. Patch applied to imageio module at repo revision r953364. Please check it was applied as you expected. p.s. we tend to use (foo == null) rather than the other way around, though I understand why you may do it that way. Better to follow the established style, and in any case removeProvider(Object,Class) has it both ways round!
        Tim Ellison made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 5.0M15 [ 12315054 ]
        Resolution Fixed [ 1 ]
        Hide
        Alexei Fedotov added a comment -

        Tim, JFYI, I'm currently applying HARMONY-6507.

        Show
        Alexei Fedotov added a comment - Tim, JFYI, I'm currently applying HARMONY-6507 .
        Hide
        Hudson added a comment -

        Integrated in Harmony-1.5-head-linux-x86_64 #840 (See http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/840/)
        Apply patch for HARMONY-6518 (Implementation of method deregisterServiceProvider(java.lang.Object, java.lang.Class))

        Show
        Hudson added a comment - Integrated in Harmony-1.5-head-linux-x86_64 #840 (See http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/840/ ) Apply patch for HARMONY-6518 (Implementation of method deregisterServiceProvider(java.lang.Object, java.lang.Class))
        Hide
        Lang Yang added a comment -

        Thanks Tim. It was applied as expected.

        Also thanks for that tip, I saw that expression several times in the existing implementation, so thought it's ok to use it. Anyway, as you have mentioned, I will follow the established style

        Show
        Lang Yang added a comment - Thanks Tim. It was applied as expected. Also thanks for that tip, I saw that expression several times in the existing implementation, so thought it's ok to use it. Anyway, as you have mentioned, I will follow the established style
        Hide
        Hudson added a comment -

        Integrated in Harmony-select-1.5-head-linux-x86_64 #28 (See http://hudson.zones.apache.org/hudson/job/Harmony-select-1.5-head-linux-x86_64/28/)
        Apply patch for HARMONY-6518 (Implementation of method deregisterServiceProvider(java.lang.Object, java.lang.Class))

        Show
        Hudson added a comment - Integrated in Harmony-select-1.5-head-linux-x86_64 #28 (See http://hudson.zones.apache.org/hudson/job/Harmony-select-1.5-head-linux-x86_64/28/ ) Apply patch for HARMONY-6518 (Implementation of method deregisterServiceProvider(java.lang.Object, java.lang.Class))
        Lang Yang made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        19d 12h 40m 1 Tim Ellison 10/Jun/10 17:02
        Resolved Resolved Closed Closed
        25d 12h 24m 1 Lang Yang 06/Jul/10 05:27

          People

          • Assignee:
            Tim Ellison
            Reporter:
            Lang Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development