Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0M15
    • Component/s: Classlib
    • Labels:
    • Patch Info:
      Patch Available

      Description

      Implemented methods ImageWriterSpi.isOwnWriter() and ImageReaderSpi.isOwnReader().

      description of ImageWriterSpi.isOwnWriter() - http://java.sun.com/j2se/1.4.2/docs/api/javax/imageio/spi/ImageWriterSpi.html#isOwnWriter(javax.imageio.ImageWriter)
      description of ImageWriterSpi.isOwnReader() - http://java.sun.com/j2se/1.4.2/docs/api/javax/imageio/spi/ImageReaderSpi.html#isOwnReader(javax.imageio.ImageReader)

      I have also changed strings imageio.96 to "writer == null!" and imageio.97 to "reader == null!" to make it consistent with SUN JDK.

        Activity

        Hide
        Hudson added a comment -

        Integrated in Harmony-1.5-head-linux-x86_64 #844 (See http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/844/)
        Committed Lang's patch for HARMONY-6509: implementation of ImageReaderSpi.isOwnReader() and ImageWriterSpi.isOwnWriter().

        Show
        Hudson added a comment - Integrated in Harmony-1.5-head-linux-x86_64 #844 (See http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/844/ ) Committed Lang's patch for HARMONY-6509 : implementation of ImageReaderSpi.isOwnReader() and ImageWriterSpi.isOwnWriter().
        Hide
        Hudson added a comment -

        Integrated in Harmony-select-1.5-head-linux-x86_64 #30 (See http://hudson.zones.apache.org/hudson/job/Harmony-select-1.5-head-linux-x86_64/30/)
        Committed Lang's patch for HARMONY-6509: implementation of ImageReaderSpi.isOwnReader() and ImageWriterSpi.isOwnWriter().

        Show
        Hudson added a comment - Integrated in Harmony-select-1.5-head-linux-x86_64 #30 (See http://hudson.zones.apache.org/hudson/job/Harmony-select-1.5-head-linux-x86_64/30/ ) Committed Lang's patch for HARMONY-6509 : implementation of ImageReaderSpi.isOwnReader() and ImageWriterSpi.isOwnWriter().
        Hide
        Alexei Fedotov added a comment -

        Adjusted tests to pass on RI, committed the patch except localization changes at r9533447. (Sorry, I personally find existing messages more descriptive and don't like exclamation marks.)

        Lang, please verify that the patch is applied correctly.

        Show
        Alexei Fedotov added a comment - Adjusted tests to pass on RI, committed the patch except localization changes at r9533447. (Sorry, I personally find existing messages more descriptive and don't like exclamation marks.) Lang, please verify that the patch is applied correctly.
        Hide
        Alexei Fedotov added a comment -

        Lang, please double think of using strings rather than localized exception messages. Internationalization is a common convention for Harmony.

        Show
        Alexei Fedotov added a comment - Lang, please double think of using strings rather than localized exception messages. Internationalization is a common convention for Harmony.
        Hide
        Lang Yang added a comment -

        The test case passed successful on both Harmony and RI JREs.

        Show
        Lang Yang added a comment - The test case passed successful on both Harmony and RI JREs.

          People

          • Assignee:
            Alexei Fedotov
            Reporter:
            Lang Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development