Implemented almost 100% of the tool, only need the -show option. Which I'll be adding later.
We generally mark issues "Patch Available" and leave them open. The committer will resolve it when they make the commit to SVN and then ask you to confirm that it has been applied correctly by closing the issue.
Mark, can I implement -show with swing rather than awt?
Right know sun impl has some bugs, for example it won't close the window. I think they didn't and a handler there. Anyway can I also fix this bug and do on swing?/?
Thanks Marcos - I have applied your patch at repo revision r935528. I made some slight modifications - adding Apache license headers to the test files and also moving the test cases from org.apache.harmony.tests.tool.serialver to org.apache.harmony.tests.tools.serialver package so they were alongside existing tests. I also added a line to the samsa\build.xml to create the serialver executable. Please can you check you are happy with the modifications I have made and that the tool works as expected? Also, have you had any luck progressing with the -show option?
The patch is perfect.
I forgot to submit the -show part. I'll be sending already!! But before sending I want to question something... I'm getting a strange window display when using the JFrame on Harmony, it's kinda strange it's seems theres a problem when running swing. I've attached a screenshot for more info. RI also attached.
Thanks in advance,
Thanks Marcos - great to hear you will have a patch for the -show option too. Is the Harmony screenshot screenshot1.png? It does look a little different to the RI - does it work ok even though the display is different? There is still a little work to be done in the area of swing for Harmony, but as long as your tool works and displays ok (it does not need to be identical to the RI) then that will be fine.
Yeah, the screen1 is from Harmony :3.
The tool works flawless. Only prob is the swing part, but it doensn't interfere with the functionality.
The patch is attached.
Thanks Marcos! I have applied the patch at repo revision r936264 - please check that it was applied as expected and close this defect if you are happy it is resolved.
Thanks Oliver, it's resolved