Harmony
  1. Harmony
  2. HARMONY-6458

[classlib] [portlib] unix/hysock.c hysock_bind has redundant code

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 6.0M1, 5.0M13
    • Fix Version/s: 6.0M3, 5.0M15
    • Component/s: None
    • Labels:
      None

      Description

      hysock_bind on unix has an #ifdef SIN6_LEN section that defines a length variable that is not used.

        Activity

        Hide
        Mark Hindess added a comment -

        Removed by refactoring.

        Show
        Mark Hindess added a comment - Removed by refactoring.
        Hide
        Hudson added a comment -

        Integrated in Harmony-select-1.5-head-linux-x86_64 #19 (See http://hudson.zones.apache.org/hudson/job/Harmony-select-1.5-head-linux-x86_64/19/)
        Fix FreeBSD socket problem - it requires the sin_len field to be correct.
        "ant -Dexclude.module=awt,swing test" now passes 99.27% of 17597 tests.

        This indirectly fixes "HARMONY-6458 [classlib] [portlib] unix/hysock.c
        hysock_bind has redundant code".

        Show
        Hudson added a comment - Integrated in Harmony-select-1.5-head-linux-x86_64 #19 (See http://hudson.zones.apache.org/hudson/job/Harmony-select-1.5-head-linux-x86_64/19/ ) Fix FreeBSD socket problem - it requires the sin_len field to be correct. "ant -Dexclude.module=awt,swing test" now passes 99.27% of 17597 tests. This indirectly fixes " HARMONY-6458 [classlib] [portlib] unix/hysock.c hysock_bind has redundant code".
        Hide
        Mark Hindess added a comment -

        Fixed (indirectly) by commit r952336.

        Show
        Mark Hindess added a comment - Fixed (indirectly) by commit r952336.
        Hide
        Hudson added a comment -

        Integrated in Harmony-1.5-head-linux-x86_64 #827 (See http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/827/)
        Fix FreeBSD socket problem - it requires the sin_len field to be correct.
        "ant -Dexclude.module=awt,swing test" now passes 99.27% of 17597 tests.

        This indirectly fixes "HARMONY-6458 [classlib] [portlib] unix/hysock.c
        hysock_bind has redundant code".

        Show
        Hudson added a comment - Integrated in Harmony-1.5-head-linux-x86_64 #827 (See http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/827/ ) Fix FreeBSD socket problem - it requires the sin_len field to be correct. "ant -Dexclude.module=awt,swing test" now passes 99.27% of 17597 tests. This indirectly fixes " HARMONY-6458 [classlib] [portlib] unix/hysock.c hysock_bind has redundant code".
        Hide
        Mark Hindess added a comment -

        I've not had time to look at these and they aren't urgent so I'm deferring fixing them until the next release.

        Show
        Mark Hindess added a comment - I've not had time to look at these and they aren't urgent so I'm deferring fixing them until the next release.

          People

          • Assignee:
            Mark Hindess
            Reporter:
            Mark Hindess
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development