[HARMONY-6356] [classlib][lang-managment] Improvements to lang-management classes from findbugs

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 5.0M12
• Component/s: Classlib
• Environment: all
• Patch Info: Patch Available
• Estimated Complexity: Novice
• Assignee: Oliver Deakin
• Reporter: Catherine Hope
• Created: 15/Oct/09 13:54
• Updated: 19/Oct/09 10:47
• Resolved: 16/Oct/09 12:30

Description

Improvements to lang-management classes from running findbugs, and exclusions list.

Most changes are performance suggestions, e.g. Boolean.valueOf and removing new String(<existing String>), and some redundant logic, e.g. String fileNameValue = (fileName == null) ? null : new String(fileName)

The exclude is for returning a mutable object from java.lang.management.ThreadInfo.getStackTrace(), but I checked the RI and it does the same, so I didn't make any changes:
StackTraceElement[] stack1 = ti.getStackTrace();
String dummyData = "dummy";
StackTraceElement dummyElement = new StackTraceElement(dummyData, dummyData, dummyData, 0);
stack1[0] = dummyElement;
StackTraceElement[] stack2 = ti.getStackTrace();
assertNotSame(stack1[0], stack2[0]); // this fails on Sun and Harmony