[HARMONY-6323] [classlib] [luni] Simplify and speed-up collection shuffle, add a non-probabilistic test

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 5.0M12
• Component/s: Classlib
• Environment: SVN Revision 801399
• Patch Info: Patch Available
• Estimated Complexity: Moderate
• Assignee: Tim Ellison
• Reporter: Jesse Wilson
• Created: 27/Aug/09 23:48
• Updated: 06/Sep/09 05:56
• Resolved: 04/Sep/09 12:33

Description

Shuffle needlessly tests Random.nextInt() for a negative value
It iterates from index N-1 to 0, which means it always swaps index 0 with itself needlessly.
It is only tested with probabilistic tests, the patch adds a proper test. Note that the attached test also passes on the RI.