Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0M10
    • Component/s: Classlib
    • Labels:
      None
    • Environment:
      SVN Revision: 768351
    • Patch Info:
      Patch Available
    • Estimated Complexity:
      Novice

      Description

      Improvements to the NIO Javadocs from Android.
      http://developer.android.com/reference/java/nio/package-summary.html

      1. NIO_Javadoc_from_Android.patch
        505 kB
        Jesse Wilson
      2. NIO_Javadoc_from_Android_2.patch
        486 kB
        Jesse Wilson
      3. NIO_Javadoc_from_Android_3.patch
        5 kB
        Jesse Wilson

        Activity

        Jesse Wilson created issue -
        Jesse Wilson made changes -
        Field Original Value New Value
        Attachment NIO_Javadoc_from_Android.patch [ 12406408 ]
        Tim Ellison made changes -
        Assignee Tim Ellison [ tellison ]
        Tim Ellison made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Tim Ellison added a comment -

        Thanks Jesse.

        I've applied the patches that relate to the NIO module in repo revision r768919.

        The patch you attached also includes updates to the LOGGING module. Please confirm that it was you intention to contribute those patches too (since you didn't mention them int he description). If it's ok I'll apply them too.

        Show
        Tim Ellison added a comment - Thanks Jesse. I've applied the patches that relate to the NIO module in repo revision r768919. The patch you attached also includes updates to the LOGGING module. Please confirm that it was you intention to contribute those patches too (since you didn't mention them int he description). If it's ok I'll apply them too.
        Hide
        Jesse Wilson added a comment -

        Same as the previous patch, but with logging Javadoc updates removed. Those were inadvertently included in this patch rather than the logging patch.

        I've resubmitted those four files to the logging Javadoc issue here:
        https://issues.apache.org/jira/browse/HARMONY-6176

        Show
        Jesse Wilson added a comment - Same as the previous patch, but with logging Javadoc updates removed. Those were inadvertently included in this patch rather than the logging patch. I've resubmitted those four files to the logging Javadoc issue here: https://issues.apache.org/jira/browse/HARMONY-6176
        Jesse Wilson made changes -
        Attachment NIO_Javadoc_from_Android_2.patch [ 12406550 ]
        Hide
        Tim Ellison added a comment -

        OK, this issue should be fully resolved by the r768919 commit.

        Please verify.

        Show
        Tim Ellison added a comment - OK, this issue should be fully resolved by the r768919 commit. Please verify.
        Tim Ellison made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Jesse Wilson added a comment -

        Unfortunately, I believe Tim's CL omits one file:
        working_classlib/modules/nio/src/main/java/common/java/nio/channels/spi/AbstractSelector.java

        I think this was in the original patch, but I'll reattach another with just this file.

        Show
        Jesse Wilson added a comment - Unfortunately, I believe Tim's CL omits one file: working_classlib/modules/nio/src/main/java/common/java/nio/channels/spi/AbstractSelector.java I think this was in the original patch, but I'll reattach another with just this file.
        Jesse Wilson made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Jesse Wilson made changes -
        Attachment NIO_Javadoc_from_Android_3.patch [ 12406558 ]
        Hide
        Tim Ellison added a comment -

        Oops, thanks for spotting that Jesse.

        The AbstractSelector was committed at repo revision r769135.

        Please check I got it right this time <g>

        Show
        Tim Ellison added a comment - Oops, thanks for spotting that Jesse. The AbstractSelector was committed at repo revision r769135. Please check I got it right this time <g>
        Tim Ellison made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Jesse Wilson added a comment -

        Looks good to me.

        Show
        Jesse Wilson added a comment - Looks good to me.
        Jesse Wilson made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Tim Ellison
            Reporter:
            Jesse Wilson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.5h
              0.5h
              Remaining:
              Remaining Estimate - 0.5h
              0.5h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development