Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: VM
    • Labels:
      None
    • Patch Info:
      Patch Available
    • Estimated Complexity:
      Moderate

      Description

      localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

        Issue Links

          Activity

          Hide
          Alexei Fedotov added a comment -

          Fixed at 680117. No objection to close.

          Show
          Alexei Fedotov added a comment - Fixed at 680117. No objection to close.
          Hide
          Senaka Fernando added a comment -

          Hi Alexei,

          The "ant clean build" which should in theory alarm the miss-use of ',' in place of '<<' doesn't seem to trigger. I believe the behaviour looks a bit different on my system. As I said before, I did not see a build error due to this. The possibilities are that the clean does not in fact clean code in that area.

          The patch seems to be applied ok. There is a mismatch in WARN053 in the harmony.properties and working_vm/vm/gc_gen/src/common/large_pages.cpp. You've corrected one but left the other intact.

          I will add to this issue, further modifications which will replace remaining references to DIE with LDIE. Some instances are straightforward where as some aren't, I will post to the list as I progress.

          Regards,
          Senaka

          Show
          Senaka Fernando added a comment - Hi Alexei, The "ant clean build" which should in theory alarm the miss-use of ',' in place of '<<' doesn't seem to trigger. I believe the behaviour looks a bit different on my system. As I said before, I did not see a build error due to this. The possibilities are that the clean does not in fact clean code in that area. The patch seems to be applied ok. There is a mismatch in WARN053 in the harmony.properties and working_vm/vm/gc_gen/src/common/large_pages.cpp. You've corrected one but left the other intact. I will add to this issue, further modifications which will replace remaining references to DIE with LDIE. Some instances are straightforward where as some aren't, I will post to the list as I progress. Regards, Senaka
          Hide
          Alexei Fedotov added a comment -

          Committed at 680117 with few compilation fixes. Senaka, please, check that the patch is applied as expected.

          Show
          Alexei Fedotov added a comment - Committed at 680117 with few compilation fixes. Senaka, please, check that the patch is applied as expected.
          Hide
          Senaka Fernando added a comment -

          Hi Alexei,

          Sorry about the LDIE085 issue. I have made a blunder in the diff. I had to remove certain portions from the diff since they were not related to this issue. While doing that a mysterious line has been added. ... Will have that corrected.

          Thanks,
          Senaka

          Show
          Senaka Fernando added a comment - Hi Alexei, Sorry about the LDIE085 issue. I have made a blunder in the diff. I had to remove certain portions from the diff since they were not related to this issue. While doing that a mysterious line has been added. ... Will have that corrected. Thanks, Senaka
          Hide
          Alexei Fedotov added a comment -

          Senaka,
          Why LDIE085 appears twice at the patch for working_vm/vm/vmcore/src/init/harmony.properties?

          BTW, replacing clog.h with cxxlog.h in the low-level code is pretty unsafe operation because DRLVM does not handle stack unwinding in a C++-like way. I could not see any particular problems right now but would suggest discussing such changes on the list before making them (and better avoid making potentially unsafe changes).

          Show
          Alexei Fedotov added a comment - Senaka, Why LDIE085 appears twice at the patch for working_vm/vm/vmcore/src/init/harmony.properties? BTW, replacing clog.h with cxxlog.h in the low-level code is pretty unsafe operation because DRLVM does not handle stack unwinding in a C++-like way. I could not see any particular problems right now but would suggest discussing such changes on the list before making them (and better avoid making potentially unsafe changes).
          Hide
          Alexei Fedotov added a comment -

          My problem was a known issue. I need to find four msvc debugging dlls to make things wok.

          Show
          Alexei Fedotov added a comment - My problem was a known issue. I need to find four msvc debugging dlls to make things wok.
          Hide
          Alexei Fedotov added a comment -

          I could not make a debug version of DRLVM work: got crash with 53 error code. Fortunately I got a Microsoft "heroes" pack with MSVC debugger - if it would work, I would locate a crash. Otherwise I'm to revive my Linux.

          Show
          Alexei Fedotov added a comment - I could not make a debug version of DRLVM work: got crash with 53 error code. Fortunately I got a Microsoft "heroes" pack with MSVC debugger - if it would work, I would locate a crash. Otherwise I'm to revive my Linux.
          Hide
          Senaka Fernando added a comment -

          Hi Alexei,

          I found that the classloader.cpp infact had an error. I'm still in search of the other two. However, 'ant test' and 'ant test2' don't seem to work with or with out the patch. I doubt whether I'm missing anything here.

          Also, I'm on a Ubuntu Hardy using gcc version 4.2.3 (Ubuntu 4.2.3-2ubuntu7).

          Regards,
          Senaka

          Show
          Senaka Fernando added a comment - Hi Alexei, I found that the classloader.cpp infact had an error. I'm still in search of the other two. However, 'ant test' and 'ant test2' don't seem to work with or with out the patch. I doubt whether I'm missing anything here. Also, I'm on a Ubuntu Hardy using gcc version 4.2.3 (Ubuntu 4.2.3-2ubuntu7). Regards, Senaka
          Hide
          Alexei Fedotov added a comment -

          Senaka, threading module does not support LDIE. The submitted patches for VM should pass "ant test" for any of supported platforms, i.e. you have to run a small set of tests before submitting the patch.

          Show
          Alexei Fedotov added a comment - Senaka, threading module does not support LDIE. The submitted patches for VM should pass "ant test" for any of supported platforms, i.e. you have to run a small set of tests before submitting the patch.

            People

            • Assignee:
              Alexei Fedotov
              Reporter:
              Senaka Fernando
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development