Harmony
  1. Harmony
  2. HARMONY-4659

[testing] JEdit automated GUI tests use obsolete workaround for java.awt.Toolkit

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: build - test - ci
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      With HARMONY-4423 fixed, the additional workaround patch to java.awt.Toolkit that is used in jEdit automated GUI tests (see HARMONY-3633) becomes useless and may be removed.

      The attached patch removes all extra stuff needed for that workaround from jEdit tests framework. When applying please remove the bt-2/tests/jedit_test/src/patches/harmony directory, the patch updates build.xml, build.properties and readme.txt accordingly.

      1. Harmony-4659.patch
        7 kB
        Vasily Zakharov
      2. Harmony-4659-2.patch
        1 kB
        Vasily Zakharov

        Issue Links

          Activity

          Hide
          Vasily Zakharov added a comment -

          I've updated a patch a bit to perform normally with empty test.vmarg.bootclasspath. Now the patched tests work on Linux also.

          Show
          Vasily Zakharov added a comment - I've updated a patch a bit to perform normally with empty test.vmarg.bootclasspath. Now the patched tests work on Linux also.
          Hide
          Stepan Mishura added a comment -

          Thanks Vasily - the patch was applied to BTI branch 2.0 at r571136.
          Please check that the patch was applied as you expected.

          Show
          Stepan Mishura added a comment - Thanks Vasily - the patch was applied to BTI branch 2.0 at r571136. Please check that the patch was applied as you expected.
          Hide
          Vasily Zakharov added a comment -

          Stepan, thank you very much! The patch is ok, but for some reason (my mistake, sorry) a couple of minor changes didn't make it to the patch. Could you please apply Harmony-4659-2.patch as well to fix them? Thank you!

          Also please totally remove the bt-2/tests/jedit_test/src/patches/harmony directory - I can't create a patch for it. Thank you!

          Show
          Vasily Zakharov added a comment - Stepan, thank you very much! The patch is ok, but for some reason (my mistake, sorry) a couple of minor changes didn't make it to the patch. Could you please apply Harmony-4659-2.patch as well to fix them? Thank you! Also please totally remove the bt-2/tests/jedit_test/src/patches/harmony directory - I can't create a patch for it. Thank you!
          Hide
          Stepan Mishura added a comment -

          Done at r572224. Please check that everything looks as expected.

          Show
          Stepan Mishura added a comment - Done at r572224. Please check that everything looks as expected.
          Hide
          Vasily Zakharov added a comment -

          Stepan, thank you very much, everything is fine now.

          Show
          Vasily Zakharov added a comment - Stepan, thank you very much, everything is fine now.

            People

            • Assignee:
              Stepan Mishura
              Reporter:
              Vasily Zakharov
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development