Harmony
  1. Harmony
  2. HARMONY-43

Performance enhancement for nio buffers bulk get/put methods

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Classlib
    • Labels:
      None

      Description

      The performance of some bulk get/put methods can be enhanced. I will post the patches one by one.

      1. CharBuffer_patch.txt
        9 kB
        Richard Liang
      2. OtherBuffer_patch.txt
        39 kB
        Richard Liang

        Activity

        Richard Liang created issue -
        Hide
        Richard Liang added a comment -

        This patch is created against java.nio which will affect the following files:
        java.nio.CharBuffer
        java.nio.CharArrayBuffer
        java.nio.CharSequenceAdapter
        java.nio.CharToByteBufferAdapter
        java.nio.ReadOnlyCharArrayBuffer
        java.nio.ReadWriteCharArrayBuffer

        Show
        Richard Liang added a comment - This patch is created against java.nio which will affect the following files: java.nio.CharBuffer java.nio.CharArrayBuffer java.nio.CharSequenceAdapter java.nio.CharToByteBufferAdapter java.nio.ReadOnlyCharArrayBuffer java.nio.ReadWriteCharArrayBuffer
        Richard Liang made changes -
        Field Original Value New Value
        Attachment CharBuffer_patch.txt [ 12322312 ]
        Tim Ellison made changes -
        Assignee Tim Ellison [ tellison ]
        Tim Ellison made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Tim Ellison added a comment -

        Richard,

        Thanks for these enhancements. Committed in NIO module at repo revision 371957.

        Show
        Tim Ellison added a comment - Richard, Thanks for these enhancements. Committed in NIO module at repo revision 371957.
        Tim Ellison made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Richard Liang added a comment -

        Hello Tim,
        Here is the patch file for all other buffers (except for CharBuffer). The changes are just similar to those of CharBuffer.

        Would you please try to apply the patch? Thanks a lot.

        Show
        Richard Liang added a comment - Hello Tim, Here is the patch file for all other buffers (except for CharBuffer). The changes are just similar to those of CharBuffer. Would you please try to apply the patch? Thanks a lot.
        Richard Liang made changes -
        Attachment OtherBuffer_patch.txt [ 12322351 ]
        Hide
        Tim Ellison added a comment -

        Thanks Ricahrd, I'll review them now.

        Show
        Tim Ellison added a comment - Thanks Ricahrd, I'll review them now.
        Hide
        Tim Ellison added a comment -

        Re-opened to capture further changes by Richard.

        Show
        Tim Ellison added a comment - Re-opened to capture further changes by Richard.
        Tim Ellison made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Tim Ellison added a comment -

        Richard,

        Thanks for the bulk operation enhancements. They have been applied to the NIO module at repo revision 372498.

        Show
        Tim Ellison added a comment - Richard, Thanks for the bulk operation enhancements. They have been applied to the NIO module at repo revision 372498.
        Tim Ellison made changes -
        Resolution Fixed [ 1 ]
        Status Reopened [ 4 ] Resolved [ 5 ]
        Hide
        Richard Liang added a comment -

        Tim,
        The fix is good. Please close this JIRA. Thanks a lot.

        Show
        Richard Liang added a comment - Tim, The fix is good. Please close this JIRA. Thanks a lot.
        Hide
        Tim Ellison added a comment -

        Verified by Richard

        Show
        Tim Ellison added a comment - Verified by Richard
        Tim Ellison made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        33m 15s 1 Tim Ellison 25/Jan/06 02:24
        In Progress In Progress Resolved Resolved
        2m 14s 1 Tim Ellison 25/Jan/06 02:26
        Resolved Resolved Reopened Reopened
        1d 16h 55m 1 Tim Ellison 26/Jan/06 19:21
        Reopened Reopened Resolved Resolved
        3m 52s 1 Tim Ellison 26/Jan/06 19:25
        Resolved Resolved Closed Closed
        32d 25m 1 Tim Ellison 27/Feb/06 19:50

          People

          • Assignee:
            Tim Ellison
            Reporter:
            Richard Liang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development