Harmony
  1. Harmony
  2. HARMONY-41

NIO: java.nio.channels.spi and java.nio.channels.Channels, Pipe, Selector have not been implemented

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Classlib
    • Labels:
      None

      Description

      There are only stubs for these classes in Harmony. Hopefully, I can contribute my implementation soon. Thanks a lot.

      1. Harmony41-1.zip
        9 kB
        Paulex Yang
      2. Harmony41-2.ZIP
        11 kB
        Paulex Yang
      3. Harmony41-3.ZIP
        8 kB
        Paulex Yang
      4. Harmony41-4.zip
        11 kB
        Paulex Yang

        Issue Links

          Activity

          George Harley made changes -
          Resolution Fixed [ 1 ]
          Status Reopened [ 4 ] Closed [ 6 ]
          Hide
          George Harley added a comment -

          All verified by Paulex. Further work in this area to be opened in separate issues....

          Show
          George Harley added a comment - All verified by Paulex. Further work in this area to be opened in separate issues....
          Hide
          Paulex Yang added a comment -

          Hi, George, all patches are well applied, thank you very much. And I think so, it is time to close this JIRA now.

          Show
          Paulex Yang added a comment - Hi, George, all patches are well applied, thank you very much. And I think so, it is time to close this JIRA now.
          Hide
          George Harley added a comment -

          Hi Paulex,

          Selector implementation patch committed in revision 415279. Please could you check that it has all been applied as expected. If all is well then perhaps, as you suggested in your previous append, it is time to close this issue and raise new ones for further changes in this area.

          Many thanks for this enhancement.

          Best regards,
          George

          Show
          George Harley added a comment - Hi Paulex, Selector implementation patch committed in revision 415279. Please could you check that it has all been applied as expected. If all is well then perhaps, as you suggested in your previous append, it is time to close this issue and raise new ones for further changes in this area. Many thanks for this enhancement. Best regards, George
          Paulex Yang made changes -
          Attachment Harmony41-4.zip [ 12335487 ]
          Hide
          Paulex Yang added a comment -

          Please try the last patch for this issue - the Selector's implementation. There are still some issues about Selector left, such as the interruption, etc, and some of these issues are under discussion on the mailing list, I think they are worthing of separated JIRAs.

          Thanks a lot.

          Show
          Paulex Yang added a comment - Please try the last patch for this issue - the Selector's implementation. There are still some issues about Selector left, such as the interruption, etc, and some of these issues are under discussion on the mailing list, I think they are worthing of separated JIRAs. Thanks a lot.
          Hide
          George Harley added a comment -

          Hi Paulex,

          Your third patch has been committed in revision 413627. Please could you verify that it has been applied as expected. Many thanks for this further enhancement. I look forward to seeing your Selector implementation.

          Best regards,
          George

          Show
          George Harley added a comment - Hi Paulex, Your third patch has been committed in revision 413627. Please could you verify that it has been applied as expected. Many thanks for this further enhancement. I look forward to seeing your Selector implementation. Best regards, George
          Paulex Yang made changes -
          Attachment Harmony41-3.ZIP [ 12335237 ]
          Hide
          Paulex Yang added a comment -

          Here goes the third patch, for Pipe's implementation and test. Please try it, thanks.

          I expect the next one can resolve this issue, and it will be the implementation of Selector.

          Show
          Paulex Yang added a comment - Here goes the third patch, for Pipe's implementation and test. Please try it, thanks. I expect the next one can resolve this issue, and it will be the implementation of Selector.
          Tim Ellison made changes -
          Link This issue incorporates HARMONY-582 [ HARMONY-582 ]
          George Harley made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Hide
          George Harley added a comment -

          D'oh ! Just remembered that in your comments you envisage another few patches being applied for this issue. Re-opening issue in anticipation.

          Best regards,
          George

          Show
          George Harley added a comment - D'oh ! Just remembered that in your comments you envisage another few patches being applied for this issue. Re-opening issue in anticipation. Best regards, George
          George Harley made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          Hide
          George Harley added a comment -

          Hi Paulex,

          Changes applied in revision 411920. Please could you verify that they have been committed as expected. Many thanks for this enhancement.

          Best regards,
          George

          Show
          George Harley added a comment - Hi Paulex, Changes applied in revision 411920. Please could you verify that they have been committed as expected. Many thanks for this enhancement. Best regards, George
          Paulex Yang made changes -
          Attachment Harmony41-2.ZIP [ 12334936 ]
          Hide
          Paulex Yang added a comment -

          Here goes the step 2 for the patches, including the completion of j.n.c.spi packages and tests. I expects two or three more patches are needed to fully fix this issue, say, Pipe, Selector and more tests. I'll go on to work on it if this one is acceptted. Thank you.

          Show
          Paulex Yang added a comment - Here goes the step 2 for the patches, including the completion of j.n.c.spi packages and tests. I expects two or three more patches are needed to fully fix this issue, say, Pipe, Selector and more tests. I'll go on to work on it if this one is acceptted. Thank you.
          Hide
          George Harley added a comment -

          Hi Paulex

          Your first patch was committed in revision 397925. Please could you verify that it has been applied as hoped (I internationalized a handful of messages in the IOUtils class). Keeping issue open in anticipation of your next step.

          Thanks very much for this enhancement !

          Best regards,
          George

          Show
          George Harley added a comment - Hi Paulex Your first patch was committed in revision 397925. Please could you verify that it has been applied as hoped (I internationalized a handful of messages in the IOUtils class). Keeping issue open in anticipation of your next step. Thanks very much for this enhancement ! Best regards, George
          George Harley made changes -
          Assignee George Harley [ georgeharley ]
          Paulex Yang made changes -
          Field Original Value New Value
          Attachment Harmony41-1.zip [ 12325810 ]
          Hide
          Paulex Yang added a comment -

          This JIRA covers many classes, and I'll try to provide patch in steps so that it is easier to fix for me as well as commiters. Here goes the first run, which contains implementation/test of java.nio.channels.Channels. Pls. try it, thx a lot.

          Show
          Paulex Yang added a comment - This JIRA covers many classes, and I'll try to provide patch in steps so that it is easier to fix for me as well as commiters . Here goes the first run, which contains implementation/test of java.nio.channels.Channels. Pls. try it, thx a lot.
          Richard Liang created issue -

            People

            • Assignee:
              George Harley
              Reporter:
              Richard Liang
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development