Uploaded image for project: 'Harmony'
  1. Harmony
  2. HARMONY-2802

[drlvm][doc] Improve documentation autogenerated from DRLVM sources.

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • DRLVM
    • None
    • Patch Available
    • Moderate

    Description

      I've created the patch to fix formatting in the following files located in include/ folder: vm.h, vm_util.h, jit_import_rt.h, common.h, jit_runtime_support.h, hycomp.h, ee_em_intf.h. Please be aware i've only fixed format of comments. Please find my comments on how to improve the same headers further:

      common.h
      -Add detailed description
      -Add brief description [@file]

      ee_em_intf.h
      -Are there any [OUT] parameters?

      hycomp.h
      -Add detailed description
      -Add brief description [@file]
      -Add Defines and Typedefs descriptions (where necessary)
      -There is the list of functions( or whatever) defining HY_PLATFORM_DOUBLE_ORDER
      I'm not sure they should be documented the way they are now...
      -Use @note for note text, but not just NOTE

      jit_import_rt.h
      -Seems to be fine

      jit_runtime_support.h
      -Add detailed description
      -Add brief description [@file]
      -Document functions, enums, typedefs (where the description is missing)
      -Use @note for note text, but not just NOTE
      -Group related functionalities together
      [Object creation routines; Exception throwing routines; Type access routines; Deprecated routines;etc
      ]
      using \ingroup, \defgroup, \addtogroup [<http://www.stack.nl/~dimitri/doxygen/grouping.html>
      ]
      -Use @return, @param where necessary

      vm.h
      -Add detailed description
      -Add brief description [@file]
      -Document certain classes, defines, functions, enums, typedefs (where the description is missing)
      -Use \ingroup, \defgroup to get rid of such notes as: begin class iterator related functions;
      end class-related functions; end class-related functions; end method signature-related functions
      -Define parameters as [in]/[out]
      -Use @return & @note (I've added some...)

      vm_util.h
      -Add detailed description
      -Add brief description [@file]
      -Document functions,classes, variables, typedefs(where the description is missing)
      -Can use \ingroup, \defgroup
      -Define parameters as [in]/[out]

      Attachments

        1. 3portFiles.patch
          42 kB
          Svetlana Konovalova
        2. build_fix.patch
          8 kB
          George Timoshenko
        3. DRLVMheadersPatch2.patch
          99 kB
          Svetlana Konovalova
        4. green.headers.patch
          120 kB
          Svetlana Konovalova
        5. H-2802Port.patch
          233 kB
          Svetlana Konovalova
        6. H-2802Port.patch
          267 kB
          Svetlana Konovalova
        7. HeadersPatch3.patch
          71 kB
          Svetlana Konovalova
        8. port.headers.patch
          191 kB
          Svetlana Konovalova
        9. PortHeaderFiles_update_February,9.patch
          237 kB
          Svetlana Konovalova
        10. VMCoreHeaders.patch
          108 kB
          Svetlana Konovalova

        Issue Links

          Activity

            People

              nadine_m Nadya Morozova
              sveta konovalova Svetlana Konovalova
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: