Harmony
  1. Harmony
  2. HARMONY-2594

[classlib][swing] javax.swing.text.StyledEditorKit.createInputAttributes(Element element, MutableAttributeSet set) doesn't throw NPE when any of arguments is null

    Details

    • Type: Bug Bug
    • Status: Reopened
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Classlib
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      Compatibility problem: On RI createInputAttributes(Element element,
      MutableAttributeSet set) throws NPE on RI when one of arguments is null.

      Test case to reproduce this but is to be attached

      1. H2594-StyledEditorKitTest.2.patch
        4 kB
        Alexey A. Ivanov
      2. H2594-StyledEditorKitTest.patch
        4 kB
        Dmitry Irlyanov
      3. stylededitorkit-patch.txt
        0.8 kB
        Alexander Simbirtsev
      4. Test.java
        3 kB
        Alexander Simbirtsev

        Issue Links

          Activity

          Hide
          Alexey A. Ivanov added a comment -

          Removed unnecessary inner/anonymous classes.
          Renamed the test cases added as regression tests.
          Commented out empty test cases.

          Please review and apply the new patch.

          Show
          Alexey A. Ivanov added a comment - Removed unnecessary inner/anonymous classes. Renamed the test cases added as regression tests. Commented out empty test cases. Please review and apply the new patch.
          Hide
          Alexander Simbirtsev added a comment -

          Reopening on demand

          Show
          Alexander Simbirtsev added a comment - Reopening on demand
          Hide
          Alexey A. Ivanov added a comment -

          Can anyone to reopen the issue to simplify the test cases provided for this issue?

          Show
          Alexey A. Ivanov added a comment - Can anyone to reopen the issue to simplify the test cases provided for this issue?
          Hide
          Mark Hindess added a comment -

          Verified. Thanks.

          Show
          Mark Hindess added a comment - Verified. Thanks.
          Hide
          Alexander Simbirtsev added a comment -

          sorry for inconveniences.
          works fine. thanks

          Show
          Alexander Simbirtsev added a comment - sorry for inconveniences. works fine. thanks
          Hide
          Mark Hindess added a comment -

          Applied patches in r495930. I removed the verbose stack trace from the test output. Please confirm they have been applied as expected.

          Show
          Mark Hindess added a comment - Applied patches in r495930. I removed the verbose stack trace from the test output. Please confirm they have been applied as expected.
          Hide
          Mark Hindess added a comment -

          Alexander, thanks for all the patches. In future, please can you create them from the top-level of classlib - without the C:/home/atsimbir/Harmony/classlib prefix - as suggested in the guidelines. Thanks.

          Show
          Mark Hindess added a comment - Alexander, thanks for all the patches. In future, please can you create them from the top-level of classlib - without the C:/home/atsimbir/Harmony/classlib prefix - as suggested in the guidelines. Thanks.
          Hide
          Dmitry Irlyanov added a comment -

          Patch to add Regression test

          Show
          Dmitry Irlyanov added a comment - Patch to add Regression test
          Hide
          Alexander Simbirtsev added a comment -

          Here's the proposed fix

          Show
          Alexander Simbirtsev added a comment - Here's the proposed fix
          Hide
          Alexander Simbirtsev added a comment -

          Code to reproduce this bug

          Show
          Alexander Simbirtsev added a comment - Code to reproduce this bug

            People

            • Assignee:
              Mark Hindess
              Reporter:
              Alexander Simbirtsev
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Development