Harmony
  1. Harmony
  2. HARMONY-244

[classlib][luni] Java 5 enhancements for java.lang.Double

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Classlib
    • Labels:
      None
    • Estimated Complexity:
      Moderate

      Description

      Patch for Java 5 enhancements to java.lang.Double.

      1. Double_java_5_patch.diff
        10 kB
        Nathan Beyer
      2. Double_java_5_no_cache.diff
        9 kB
        Nathan Beyer

        Activity

        Hide
        Nathan Beyer added a comment -

        After some thought, the caching that's implemented in the valueOf method of the attached diff may not be appropriate or valuable, so feel free to remove it.

        Show
        Nathan Beyer added a comment - After some thought, the caching that's implemented in the valueOf method of the attached diff may not be appropriate or valuable, so feel free to remove it.
        Hide
        Nathan Beyer added a comment -

        I've removed the caching piece from the orginial patch, which is available in the 'no_cache' patch.

        Show
        Nathan Beyer added a comment - I've removed the caching piece from the orginial patch, which is available in the 'no_cache' patch.
        Hide
        Tim Ellison added a comment -

        Thanks Nathan,

        I applied the non-chaching patch to java.lang.Double at repo revision 392229.

        Please check that the patch was applied as you expected.

        Show
        Tim Ellison added a comment - Thanks Nathan, I applied the non-chaching patch to java.lang.Double at repo revision 392229. Please check that the patch was applied as you expected.
        Hide
        Nathan Beyer added a comment -

        Looks good, thanks.

        Show
        Nathan Beyer added a comment - Looks good, thanks.
        Hide
        Tim Ellison added a comment -

        Verified by Nathan

        Show
        Tim Ellison added a comment - Verified by Nathan
        Hide
        Tim Ellison added a comment -

        Nathan,

        SUID added to modules\luni\src\main\java\java\lang\TypeNotPresentException.java at repo revision 395547.

        Please check that patch was applied as you expected before I close this issue.

        Show
        Tim Ellison added a comment - Nathan, SUID added to modules\luni\src\main\java\java\lang\TypeNotPresentException.java at repo revision 395547. Please check that patch was applied as you expected before I close this issue.
        Hide
        Nathan Beyer added a comment -

        I think you meant to post this here: http://issues.apache.org/jira/browse/HARMONY-288

        In any case, the patch was applied fine. Thanks.

        Show
        Nathan Beyer added a comment - I think you meant to post this here: http://issues.apache.org/jira/browse/HARMONY-288 In any case, the patch was applied fine. Thanks.

          People

          • Assignee:
            Tim Ellison
            Reporter:
            Nathan Beyer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development