Harmony
  1. Harmony
  2. HARMONY-239

[classlib][luni] Java 5 enhancements for java.lang.Float

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Classlib
    • Labels:
      None
    • Estimated Complexity:
      Moderate

      Description

      Patch for Java 5 enhancements to java.lang.Float.

      1. Float_java_5_patch.diff
        11 kB
        Nathan Beyer
      2. Float_java_5_no_cache.diff
        10 kB
        Nathan Beyer

        Activity

        Hide
        Nathan Beyer added a comment -

        After some thought, the caching that's implemented in the valueOf method of the attached diff may not be appropriate or valuable, so feel free to remove it.

        Show
        Nathan Beyer added a comment - After some thought, the caching that's implemented in the valueOf method of the attached diff may not be appropriate or valuable, so feel free to remove it.
        Hide
        Nathan Beyer added a comment -

        There was an issue with the cache that I put into the valueOf method, so I've removed it. The 'no cache' diff should reflect this, both in the class and test case.

        Show
        Nathan Beyer added a comment - There was an issue with the cache that I put into the valueOf method, so I've removed it. The 'no cache' diff should reflect this, both in the class and test case.
        Hide
        Tim Ellison added a comment -

        Thanks Nathan,

        The no cache patch looks better.
        Applied to LUNI module java.lang.Float at repo revision 390180.

        Please check that the patch was applied as you expected.

        Show
        Tim Ellison added a comment - Thanks Nathan, The no cache patch looks better. Applied to LUNI module java.lang.Float at repo revision 390180. Please check that the patch was applied as you expected.
        Hide
        Nathan Beyer added a comment -

        Looks good, thank you.

        Show
        Nathan Beyer added a comment - Looks good, thank you.
        Hide
        Tim Ellison added a comment -

        Verified by Nathan

        Show
        Tim Ellison added a comment - Verified by Nathan

          People

          • Assignee:
            Tim Ellison
            Reporter:
            Nathan Beyer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development