Harmony
  1. Harmony
  2. HARMONY-230

Some classes in java.io need to implement Appendable interface

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Classlib
    • Labels:
      None
    • Estimated Complexity:
      Novice

      Description

      As a new feature in java 5, Writer, PrintWriter, StringWriter and CharArrayWriter should implement interface Appendable.

      1. JIRA230.zip
        7 kB
        Paulex Yang
      2. java.io.Appendable.patch
        20 kB
        Paulex Yang
      3. java.io.Appendable_Test.patch
        5 kB
        Paulex Yang

        Activity

        Hide
        Paulex Yang added a comment -

        pls. try the patches for test and implementations, thx a lot.

        Show
        Paulex Yang added a comment - pls. try the patches for test and implementations, thx a lot.
        Hide
        George Harley added a comment -

        Hi Paulex,

        Thanks for the patches. Unfortunately, because the code changes are dependent on a 5.0 compiler (they correctly use method return type overriding) I cannot apply them to the source tree just yet.

        Best regards,
        George

        Show
        George Harley added a comment - Hi Paulex, Thanks for the patches. Unfortunately, because the code changes are dependent on a 5.0 compiler (they correctly use method return type overriding) I cannot apply them to the source tree just yet. Best regards, George
        Hide
        Paulex Yang added a comment -

        I also noticed that the patch for test are out of date and cannot be applied easily. I will attach a new version patches soon.

        Show
        Paulex Yang added a comment - I also noticed that the patch for test are out of date and cannot be applied easily. I will attach a new version patches soon.
        Hide
        Paulex Yang added a comment -

        I rewrote this patch in Java 1.4 syntax, and recreated patch based on new SVN revision. Pls. help to try, thx.

        Show
        Paulex Yang added a comment - I rewrote this patch in Java 1.4 syntax, and recreated patch based on new SVN revision. Pls. help to try, thx.
        Hide
        George Harley added a comment -

        Hi Paulex,

        Original (5.0 language) version of changes committed in revision 396703. Really sorry for taking to long to do this - I've been out of action for a few days now because of hardware problems.

        Please could you check that the patch has been applied to your satisfaction. Thanks for this enhancement.

        Best regards,
        George

        Show
        George Harley added a comment - Hi Paulex, Original (5.0 language) version of changes committed in revision 396703. Really sorry for taking to long to do this - I've been out of action for a few days now because of hardware problems. Please could you check that the patch has been applied to your satisfaction. Thanks for this enhancement. Best regards, George
        Hide
        Paulex Yang added a comment -

        looks fine, thank you, George.

        Show
        Paulex Yang added a comment - looks fine, thank you, George.
        Hide
        George Harley added a comment -

        Verified by Paulex.

        Show
        George Harley added a comment - Verified by Paulex.

          People

          • Assignee:
            George Harley
            Reporter:
            Paulex Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development