Harmony
  1. Harmony
  2. HARMONY-168

Java 5.0 methods missing in java.lang.StringBuffer class

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Classlib
    • Labels:
      None
    • Estimated Complexity:
      Novice

      Description

      The following Java 5.0 methods are missing in java.lang.StringBuffer class:

      StringBuffer(CharSequence)

      append(CharSequence)
      append(CharSequence, int, int)

      insert(int, CharSequence)
      insert(int, CharSequence, int, int)

      trimToSize()

      appendCodePoint(int)
      codePointAt(int)
      codePointBefore(int)
      codePointCount(int, int)
      offsetByCodePoints(int, int)

        Activity

        Hide
        Tim Ellison added a comment -

        Verified by Nathan / Vasily

        Show
        Tim Ellison added a comment - Verified by Nathan / Vasily
        Hide
        Vasily Zakharov added a comment -

        Yes, that exactly what I asked for. Nathan, Tim, thanks.

        Show
        Vasily Zakharov added a comment - Yes, that exactly what I asked for. Nathan, Tim, thanks.
        Hide
        Nathan Beyer added a comment -

        Applied as expected. Thanks.

        Show
        Nathan Beyer added a comment - Applied as expected. Thanks.
        Hide
        Tim Ellison added a comment -

        Thanks Nathan,

        Patch applied to LUNI module java.lang.StringBuffer at repo revision 384244.

        Please check that the patch was applied as you expected.

        Vasily: please check that this fully resolves your problem.

        Show
        Tim Ellison added a comment - Thanks Nathan, Patch applied to LUNI module java.lang.StringBuffer at repo revision 384244. Please check that the patch was applied as you expected. Vasily: please check that this fully resolves your problem.
        Hide
        Nathan Beyer added a comment -

        "StringBuffer_missing_methods.txt" is a patch for these missing methods and test methods for the respective test case class. Those methods that deal with Java 5/Unicode code points are implemented/not-implemented to be consistent with what's currently in StringBuilder and awaiting Java 5 code point support. Additionally, the Appendable interface isn't implemented yet, so I added a TODO for adding it once JLS3 bytecode support is enabled; in particular, support for covariant return types.

        Show
        Nathan Beyer added a comment - "StringBuffer_missing_methods.txt" is a patch for these missing methods and test methods for the respective test case class. Those methods that deal with Java 5/Unicode code points are implemented/not-implemented to be consistent with what's currently in StringBuilder and awaiting Java 5 code point support. Additionally, the Appendable interface isn't implemented yet, so I added a TODO for adding it once JLS3 bytecode support is enabled; in particular, support for covariant return types.

          People

          • Assignee:
            Tim Ellison
            Reporter:
            Vasily Zakharov
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development