Harmony
  1. Harmony
  2. HARMONY-163

Three types in java.util.jar are not implemented in Harmony

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Classlib
    • Labels:
      None
    • Estimated Complexity:
      Advanced

      Description

      Three types:
      public abstract class java/util/jar/Pack200
      public interface java/util/jar/Pack200$Packer
      public interface java/util/jar/Pack200$Unpacker
      are introduced in JSE 5, but not implemented in Harmony

      1. Pack200interface.patch
        10 kB
        Paulex Yang
      2. java.beans.PropertyChangeListener.patch
        6 kB
        Paulex Yang

        Activity

        Hide
        George Harley added a comment -

        Agreed that follow-on activities are to be done in new issue(s).

        Show
        George Harley added a comment - Agreed that follow-on activities are to be done in new issue(s).
        Hide
        Paulex Yang added a comment -

        That's fine, pls. close this JIRA. thx.

        Show
        Paulex Yang added a comment - That's fine, pls. close this JIRA. thx.
        Hide
        George Harley added a comment -

        Hi Paulex,

        OK, I understood that this was an incomplete addition to the code base (my commit comment was "awaiting default implementations and developer test code"). Given that the development of the default types and the PackFactory can be done separately - and potentially by other community members - it might be better to close this issue as fixed and open up a new JIRA explicitly for the completion of this work.

        That would be my preference anyway.

        Best regards,
        George

        Show
        George Harley added a comment - Hi Paulex, OK, I understood that this was an incomplete addition to the code base (my commit comment was "awaiting default implementations and developer test code"). Given that the development of the default types and the PackFactory can be done separately - and potentially by other community members - it might be better to close this issue as fixed and open up a new JIRA explicitly for the completion of this work. That would be my preference anyway. Best regards, George
        Hide
        Paulex Yang added a comment -

        Hi, George, looks fine, thank you.

        But I'm afraid this JIRA needs to reopened because it is just partly fixed(as I mentioned when attaching the patch). The default implementation of pack200.packer/unpacker are not implemented yet, because I consider it will be big work, so that I decided to defer it, and open for others' volunteer.

        Show
        Paulex Yang added a comment - Hi, George, looks fine, thank you. But I'm afraid this JIRA needs to reopened because it is just partly fixed(as I mentioned when attaching the patch). The default implementation of pack200.packer/unpacker are not implemented yet, because I consider it will be big work, so that I decided to defer it, and open for others' volunteer.
        Hide
        George Harley added a comment -

        Thank you Paulex,

        First part of the patch applied at revision level 391146. Obviously no need to apply the PropertyChangeListener patch since the corresponding type has since become available in the beans module.

        Please check that the patch was applied as you expected.

        Best regards,
        George

        Show
        George Harley added a comment - Thank you Paulex, First part of the patch applied at revision level 391146. Obviously no need to apply the PropertyChangeListener patch since the corresponding type has since become available in the beans module. Please check that the patch was applied as you expected. Best regards, George
        Hide
        Paulex Yang added a comment -

        The pack200interface.patch is a partly fix, because it only includes interfaces and abstract classes without default implementation and test. The other file, java.beans.PropertyChangeListener.patch is a interface required to compile, which should locate in beans component, but so far the component doesn't exist in SVN yet.

        Show
        Paulex Yang added a comment - The pack200interface.patch is a partly fix, because it only includes interfaces and abstract classes without default implementation and test. The other file, java.beans.PropertyChangeListener.patch is a interface required to compile, which should locate in beans component, but so far the component doesn't exist in SVN yet.

          People

          • Assignee:
            George Harley
            Reporter:
            Paulex Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development