Harmony
  1. Harmony
  2. HARMONY-160

Three JSE 5 methods are not implemented in java.util.zip.InflaterInputStream

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Classlib
    • Labels:
      None
    • Estimated Complexity:
      Moderate

      Description

      Three methods:
      java/util/zip/InflaterInputStream public markSupported()Z,
      java/util/zip/InflaterInputStream public mark(I)V,
      java/util/zip/InflaterInputStream public reset()V,
      are overridden in JSE 5, but they not implemented in Harmony

        Activity

        Paulex Yang created issue -
        Hide
        Paulex Yang added a comment -

        Would you pls. to try this patch? thx a lot.

        Show
        Paulex Yang added a comment - Would you pls. to try this patch? thx a lot.
        Paulex Yang made changes -
        Field Original Value New Value
        Attachment java.util.zip.inflaterinputStream.patch [ 12323663 ]
        Tim Ellison made changes -
        Assignee Tim Ellison [ tellison ]
        Hide
        Tim Ellison added a comment -

        Paulex,

        I've taken the methods you sent, but have expanded on the javadoc comments. It would also be good if you could send corresponding test cases for the new implementation (even these trivial methods).

        Fixed in ARCHIVE module java.util.zip.InflaterInputStream at repo revision 382809.

        Thanks.

        Show
        Tim Ellison added a comment - Paulex, I've taken the methods you sent, but have expanded on the javadoc comments. It would also be good if you could send corresponding test cases for the new implementation (even these trivial methods). Fixed in ARCHIVE module java.util.zip.InflaterInputStream at repo revision 382809. Thanks.
        Tim Ellison made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Paulex Yang added a comment -

        The prior fix is fine, thx. Here goes the patch for tests.

        Show
        Paulex Yang added a comment - The prior fix is fine, thx. Here goes the patch for tests.
        Paulex Yang made changes -
        Attachment java.util.zip.InflaterStreamTests.patch [ 12323756 ]
        Hide
        Tim Ellison added a comment -

        Need to check that the tests have been applied.

        Show
        Tim Ellison added a comment - Need to check that the tests have been applied.
        Tim Ellison made changes -
        Status Resolved [ 5 ] Reopened [ 4 ]
        Resolution Fixed [ 1 ]
        Hide
        Tim Ellison added a comment -

        Thanks Paulex,

        Added a modified version of your test patch to ARCHIVE module.

        Please check that the tests are acceptable to you.

        Show
        Tim Ellison added a comment - Thanks Paulex, Added a modified version of your test patch to ARCHIVE module. Please check that the tests are acceptable to you.
        Tim Ellison made changes -
        Resolution Fixed [ 1 ]
        Status Reopened [ 4 ] Resolved [ 5 ]
        Hide
        Paulex Yang added a comment -

        looks fine, thank you, Tim

        Show
        Paulex Yang added a comment - looks fine, thank you, Tim
        Hide
        Tim Ellison added a comment -

        Verified by Paulex.

        Show
        Tim Ellison added a comment - Verified by Paulex.
        Tim Ellison made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        7h 24m 1 Tim Ellison 03/Mar/06 22:43
        Resolved Resolved Reopened Reopened
        61d 20h 46m 1 Tim Ellison 04/May/06 20:29
        Reopened Reopened Resolved Resolved
        1d 6h 59m 1 Tim Ellison 06/May/06 03:29
        Resolved Resolved Closed Closed
        46d 16h 6m 1 Tim Ellison 21/Jun/06 19:35

          People

          • Assignee:
            Tim Ellison
            Reporter:
            Paulex Yang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development