Uploaded image for project: 'Harmony'
  1. Harmony
  2. HARMONY-1370

[classlib][luni] HttpsURLConnection enhancement allowing work over HTTP proxy server

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Classlib
    • Labels:
      None

      Description

      Provided patch allows HttpsURLConnection implementation to interact with remote secure server over HTTP proxy server. It also contains unit test for HttpsURLConnection implementation.

      The key_store.bks file is a binary file used by unit test. It should be placed in modules/luni/src/test/resources directory.

      1. https.patch
        55 kB
        Alexander Kleymenov
      2. https.patch2.txt
        54 kB
        Alexander Kleymenov
      3. https.patch3.txt
        54 kB
        Alexander Kleymenov
      4. https.proxy.patch.txt
        55 kB
        Alexander Kleymenov
      5. https.txt
        55 kB
        Alexander Kleymenov
      6. https-over-proxy-patch.txt
        55 kB
        Alexander Kleymenov
      7. key_store.bks
        1 kB
        Alexander Kleymenov
      8. key_store.bks
        1 kB
        Alexander Kleymenov
      9. patch-fix_head.txt
        1 kB
        Alexander Kleymenov

        Activity

        Hide
        san Alexander Kleymenov added a comment -

        Previously attached patch can not be retrieved. Patch is reattached with a new name.

        Show
        san Alexander Kleymenov added a comment - Previously attached patch can not be retrieved. Patch is reattached with a new name.
        Hide
        san Alexander Kleymenov added a comment -

        One more try..

        Show
        san Alexander Kleymenov added a comment - One more try..
        Hide
        san Alexander Kleymenov added a comment -

        And again..

        Show
        san Alexander Kleymenov added a comment - And again..
        Hide
        san Alexander Kleymenov added a comment -

        Reattach key store.

        Show
        san Alexander Kleymenov added a comment - Reattach key store.
        Hide
        san Alexander Kleymenov added a comment -

        The test from the previous patch has been rewritten not to use system property.
        This patch contains fixed test and all of the fixes from the previous patch.
        So previous patch should not be used.

        Thank You,
        Alexander

        Show
        san Alexander Kleymenov added a comment - The test from the previous patch has been rewritten not to use system property. This patch contains fixed test and all of the fixes from the previous patch. So previous patch should not be used. Thank You, Alexander
        Hide
        san Alexander Kleymenov added a comment -

        This patch fixes the unit test to use clearProperty after the test execution. Previous patch is obsolete.

        Show
        san Alexander Kleymenov added a comment - This patch fixes the unit test to use clearProperty after the test execution. Previous patch is obsolete.
        Hide
        mloenko Mikhail Loenko added a comment -

        applied in revision 452448
        Alexander, please check that it was applied as expected

        Show
        mloenko Mikhail Loenko added a comment - applied in revision 452448 Alexander, please check that it was applied as expected
        Hide
        san Alexander Kleymenov added a comment -

        Comment:
        Patch was applied as expected, but the test has been added with old license header.
        Please, apply additional patch to fix it. Thank You.

        Show
        san Alexander Kleymenov added a comment - Comment: Patch was applied as expected, but the test has been added with old license header. Please, apply additional patch to fix it. Thank You.
        Hide
        mloenko Mikhail Loenko added a comment -

        file header fixed in revision 465149

        Show
        mloenko Mikhail Loenko added a comment - file header fixed in revision 465149

          People

          • Assignee:
            mloenko Mikhail Loenko
            Reporter:
            san Alexander Kleymenov
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development