Harmony
  1. Harmony
  2. HARMONY-1370

[classlib][luni] HttpsURLConnection enhancement allowing work over HTTP proxy server

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Classlib
    • Labels:
      None

      Description

      Provided patch allows HttpsURLConnection implementation to interact with remote secure server over HTTP proxy server. It also contains unit test for HttpsURLConnection implementation.

      The key_store.bks file is a binary file used by unit test. It should be placed in modules/luni/src/test/resources directory.

      1. https.patch
        55 kB
        Alexander Kleymenov
      2. https.patch2.txt
        54 kB
        Alexander Kleymenov
      3. https.patch3.txt
        54 kB
        Alexander Kleymenov
      4. https.proxy.patch.txt
        55 kB
        Alexander Kleymenov
      5. https.txt
        55 kB
        Alexander Kleymenov
      6. https-over-proxy-patch.txt
        55 kB
        Alexander Kleymenov
      7. key_store.bks
        1 kB
        Alexander Kleymenov
      8. key_store.bks
        1 kB
        Alexander Kleymenov
      9. patch-fix_head.txt
        1 kB
        Alexander Kleymenov

        Activity

        Alexander Kleymenov created issue -
        Alexander Kleymenov made changes -
        Field Original Value New Value
        Attachment https-over-proxy-patch.txt [ 12340027 ]
        Alexander Kleymenov made changes -
        Attachment key_store.bks [ 12340028 ]
        Mikhail Loenko made changes -
        Assignee Mikhail Loenko [ mloenko ]
        Hide
        Alexander Kleymenov added a comment -

        Previously attached patch can not be retrieved. Patch is reattached with a new name.

        Show
        Alexander Kleymenov added a comment - Previously attached patch can not be retrieved. Patch is reattached with a new name.
        Alexander Kleymenov made changes -
        Attachment https.proxy.patch.txt [ 12340717 ]
        Hide
        Alexander Kleymenov added a comment -

        One more try..

        Show
        Alexander Kleymenov added a comment - One more try..
        Alexander Kleymenov made changes -
        Attachment https.patch [ 12340718 ]
        Hide
        Alexander Kleymenov added a comment -

        And again..

        Show
        Alexander Kleymenov added a comment - And again..
        Alexander Kleymenov made changes -
        Attachment https.txt [ 12340719 ]
        Hide
        Alexander Kleymenov added a comment -

        Reattach key store.

        Show
        Alexander Kleymenov added a comment - Reattach key store.
        Alexander Kleymenov made changes -
        Attachment key_store.bks [ 12340720 ]
        Hide
        Alexander Kleymenov added a comment -

        The test from the previous patch has been rewritten not to use system property.
        This patch contains fixed test and all of the fixes from the previous patch.
        So previous patch should not be used.

        Thank You,
        Alexander

        Show
        Alexander Kleymenov added a comment - The test from the previous patch has been rewritten not to use system property. This patch contains fixed test and all of the fixes from the previous patch. So previous patch should not be used. Thank You, Alexander
        Alexander Kleymenov made changes -
        Attachment https.patch2.txt [ 12340806 ]
        Hide
        Alexander Kleymenov added a comment -

        This patch fixes the unit test to use clearProperty after the test execution. Previous patch is obsolete.

        Show
        Alexander Kleymenov added a comment - This patch fixes the unit test to use clearProperty after the test execution. Previous patch is obsolete.
        Alexander Kleymenov made changes -
        Attachment https.patch3.txt [ 12341036 ]
        Hide
        Mikhail Loenko added a comment -

        applied in revision 452448
        Alexander, please check that it was applied as expected

        Show
        Mikhail Loenko added a comment - applied in revision 452448 Alexander, please check that it was applied as expected
        Mikhail Loenko made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Alexander Kleymenov added a comment -

        Comment:
        Patch was applied as expected, but the test has been added with old license header.
        Please, apply additional patch to fix it. Thank You.

        Show
        Alexander Kleymenov added a comment - Comment: Patch was applied as expected, but the test has been added with old license header. Please, apply additional patch to fix it. Thank You.
        Alexander Kleymenov made changes -
        Attachment patch-fix_head.txt [ 12342387 ]
        Hide
        Mikhail Loenko added a comment -

        file header fixed in revision 465149

        Show
        Mikhail Loenko added a comment - file header fixed in revision 465149
        Mikhail Loenko made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Mikhail Loenko
            Reporter:
            Alexander Kleymenov
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development