Harmony
  1. Harmony
  2. HARMONY-124

java.nio.charset.CharsetDecoder doesn't throw CoderMalfunctionError exception when decodeLoop threw unexpected exception.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Classlib
    • Labels:
      None

      Description

      public final CoderResult decode(ByteBuffer in, CharBuffer out, boolean endOfInput)
      As spec says, the method throws CoderMalfunctionError if an invocation of the decodeLoop method threw an unexpected exception.

      However, Harmony doesn't throws CoderMalfunctionError when decodeLoop method threw an unexpected exception.

      The following test cases pass on RI , but fail on Harmony.

      /*

      • Test malfunction decode(ByteBuffer)
        */
        public void testDecode_CoderMalfunctionError() throws Exception {
        MockMalfunctionCharset cs = new MockMalfunctionCharset("mock", null);
        try
        Unknown macro: { cs.newDecoder().onMalformedInput(CodingErrorAction.REPLACE) .onUnmappableCharacter(CodingErrorAction.REPLACE).decode(ByteBuffer.wrap(new byte[]{0x00,0x11}));
        fail("should throw CoderMalfunctionError");//NON-NLS-1$
        }catch(CoderMalfunctionError e){ //expected }
        }

        /*
        * Test malfunction decode(ByteBuffer)
        */
        public void testDecode_NoCoderMalfunctionError() throws Exception {
        MockMalfunctionCharset cs = new MockMalfunctionCharset("mock", null);
        try{
        cs.decode(ByteBuffer.wrap(new byte[]{0x00,0x11})); }

        catch(CoderMalfunctionError e)

        { fail("Charset.decode should return silently");//NON-NLS-1 }

        }
        /*

      • Mock charset class with malfunction decode & encode.
        */
        static final class MockMalfunctionCharset extends Charset {

      public MockMalfunctionCharset(String canonicalName, String[] aliases)

      { super(canonicalName, aliases); }

      public boolean contains(Charset cs)

      { return false; }

      public CharsetDecoder newDecoder()

      { return new MockMalfunctionDecoder(this); }

      public CharsetEncoder newEncoder()

      { return new MockMalfunctionEncoder(this); }

      }
      /*

      • Mock decoder. decodeLoop always throws unexpected exception.
        */
        static class MockMalfunctionDecoder extends java.nio.charset.CharsetDecoder {

      public MockMalfunctionDecoder(Charset cs)

      { super(cs, 1, 10); }

      protected CoderResult decodeLoop(ByteBuffer in, CharBuffer out)

      { throw new BufferOverflowException(); }
      }
      /*
      * Mock encoder. encodeLoop always throws unexpected exception.
      */
      static class MockMalfunctionEncoder extends java.nio.charset.CharsetEncoder {

      public MockMalfunctionEncoder(Charset cs) {
      super(cs, 1, 3, new byte[] { (byte) '?' });
      }

      protected CoderResult encodeLoop(CharBuffer in, ByteBuffer out) { throw new BufferOverflowException(); }

      }

      1. Charset_patch.txt
        0.7 kB
        Richard Liang
      2. CharsetDecoder_patch.txt
        1.0 kB
        Richard Liang

        Activity

        Hide
        Tim Ellison added a comment -

        Verified by Richard

        Show
        Tim Ellison added a comment - Verified by Richard
        Hide
        Richard Liang added a comment -

        Yes, Tim. The fix looks good. Please close this issue.
        Thanks a lot.

        Show
        Richard Liang added a comment - Yes, Tim. The fix looks good. Please close this issue. Thanks a lot.
        Hide
        Tim Ellison added a comment -

        Richard,

        The code has been fixed in NIO_CHAR java.nio.CharsetDecoder at repo revision 381665.

        Please check that the fix fully resolves your problem.

        Show
        Tim Ellison added a comment - Richard, The code has been fixed in NIO_CHAR java.nio.CharsetDecoder at repo revision 381665. Please check that the fix fully resolves your problem.
        Hide
        Richard Liang added a comment -

        Sorry, there are bugs in my test cases and patches.

        1. Refined test cases (the three Mock class are the same)

        /*

        • Test malfunction decode(ByteBuffer)
          */
          public void testDecode_CoderMalfunctionError() throws Exception {
          MockMalfunctionCharset cs = new MockMalfunctionCharset("Harmony-124-1", null);
          try
          Unknown macro: { cs.newDecoder().onMalformedInput(CodingErrorAction.REPLACE) .onUnmappableCharacter(CodingErrorAction.REPLACE).decode( ByteBuffer.wrap(new byte[] { 0x00, 0x11 }));
          fail("should throw CoderMalfunctionError");// NON-NLS-1$
          } catch (CoderMalfunctionError e) { // expected }
          }

          /*
          * Test malfunction decode(ByteBuffer)
          */
          public void testDecode_NoCoderMalfunctionError() throws Exception {
          MockMalfunctionCharset cs = new MockMalfunctionCharset("Harmony-124-2", null); //$NON-NLS-1$
          try {
          cs.decode(ByteBuffer.wrap(new byte[] { 0x00, 0x11 })); fail("Charset.decode should throw CoderMalfunctionError");// NON-NLS-1 }

          catch (CoderMalfunctionError e)

          { //expected }

          }

        2. The Charset_patch.txt is unnecessary, please just apply CharsetDecoder_patch.txt.

        Show
        Richard Liang added a comment - Sorry, there are bugs in my test cases and patches. 1. Refined test cases (the three Mock class are the same) /* Test malfunction decode(ByteBuffer) */ public void testDecode_CoderMalfunctionError() throws Exception { MockMalfunctionCharset cs = new MockMalfunctionCharset("Harmony-124-1", null); try Unknown macro: { cs.newDecoder().onMalformedInput(CodingErrorAction.REPLACE) .onUnmappableCharacter(CodingErrorAction.REPLACE).decode( ByteBuffer.wrap(new byte[] { 0x00, 0x11 })); fail("should throw CoderMalfunctionError");// NON-NLS-1$ } catch (CoderMalfunctionError e) { // expected } } /* * Test malfunction decode(ByteBuffer) */ public void testDecode_NoCoderMalfunctionError() throws Exception { MockMalfunctionCharset cs = new MockMalfunctionCharset("Harmony-124-2", null); //$NON-NLS-1$ try { cs.decode(ByteBuffer.wrap(new byte[] { 0x00, 0x11 })); fail("Charset.decode should throw CoderMalfunctionError");// NON-NLS-1 } catch (CoderMalfunctionError e) { //expected } } 2. The Charset_patch.txt is unnecessary, please just apply CharsetDecoder_patch.txt.
        Hide
        Richard Liang added a comment -

        The patches are attached.
        java.nio.charset.Charset.java and java.nio.charset.CharsetDecoder.java are modified.
        Could you please take a try to apply patches ?
        Charset_patch.txt is for java.nio.charset.Charset.java , and CharsetDecoder_patch.txt is for java.nio.charset.CharsetDecoder.java.
        You could simply click "team"->"apply patch" to apply these patches.

        Java spec doesn't point out clearly which expections are unexpected. To be compatible with RI, "BufferOverflowException" and "BufferUnderflowException" are treated as "unexpected exception" currently.

        Thank you!

        Show
        Richard Liang added a comment - The patches are attached. java.nio.charset.Charset.java and java.nio.charset.CharsetDecoder.java are modified. Could you please take a try to apply patches ? Charset_patch.txt is for java.nio.charset.Charset.java , and CharsetDecoder_patch.txt is for java.nio.charset.CharsetDecoder.java. You could simply click "team"->"apply patch" to apply these patches. Java spec doesn't point out clearly which expections are unexpected. To be compatible with RI, "BufferOverflowException" and "BufferUnderflowException" are treated as "unexpected exception" currently. Thank you!

          People

          • Assignee:
            Unassigned
            Reporter:
            Richard Liang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development