[HAMA-966] NioServerListener doesn't throw any exceptions.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.7.0
• Fix Version/s: 0.7.1
• Component/s: bsp core
• Assignee: JongYoon Lim
• Reporter: JongYoon Lim
• Created: 24/Jul/15 01:32
• Updated: 25/Jul/15 00:06
• Resolved: 24/Jul/15 07:39

Description

NioServerListener which extends Thread can't throw any exceptions because it swallows them in run() as follows.

try {
  // code for server bootstraping and binding
} catch (Exception e) {
  e.printStackTrace();
}

This results in that startServer() can't catch BindException and retry to start the server recursively. There can be two options.

• Option 1. Use Thread.UncaughtExceptionHandler.
• Option 2. Make NioServerListener extend Callable and use get() of Future to catch exceptions.

I think Option 2 looks better because the code could be more intuitive.