Uploaded image for project: 'Hama'
  1. Hama
  2. HAMA-776

localQueue is set as Send queue in init function of AbstractMessageManager

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.6.2
    • 0.6.3
    • bsp core
    • None

    Description

      In init method of AbstractMessageManager, the following codes found:

        public void init(TaskAttemptID attemptId, BSPPeer<?, ?, ?, ?, M> peer,
            Configuration conf, InetSocketAddress peerAddress) {
          ...
          this.peerAddress = peerAddress;
          this.localQueue = getSenderQueue();
          this.localQueueForNextIteration = getSynchronizedReceiverQueue();
          this.maxCachedConnections = conf.getInt(MAX_CACHED_CONNECTIONS_KEY, 100);
        }
      

      The localQueue should be a receiveQueue but it is assigned here, should it be changed as following?:

       this.localQueue = getSynchronizedReceiverQueue();
      

      Is there any special purpose here when set it as senderQueue?

      Attachments

        1. HAMA-776.patch
          0.7 kB
          MaoYuan Xian

        Activity

          People

            kennethxian MaoYuan Xian
            kennethxian MaoYuan Xian
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: