Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      need a shell to make hama's execution more easy.

      see details: http://wiki.apache.org/hama/Shell

      1. HAMA-62_v03.patch
        61 kB
        Edward J. Yoon
      2. HAMA-62_v02.patch
        85 kB
        Sijie Guo
      3. HAMA-62_v01.patch
        60 kB
        Edward J. Yoon
      4. HAMA-62.patch
        66 kB
        Sijie Guo
      5. javacc.jar
        268 kB
        Sijie Guo

        Activity

        Hide
        Sijie Guo added a comment -

        but the patch introduce new Findbugs warning, and hudson got -1. should I deal with these warnings?

        Show
        Sijie Guo added a comment - but the patch introduce new Findbugs warning, and hudson got -1. should I deal with these warnings?
        Hide
        Edward J. Yoon added a comment -

        I just committed this. Thanks Samuel.

        Show
        Edward J. Yoon added a comment - I just committed this. Thanks Samuel.
        Hide
        Hudson added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12390605/HAMA-62_v03.patch
        against trunk revision 697646.

        @author +1. The patch does not contain any @author tags.

        tests included +1. The patch appears to include 3 new or modified tests.

        javadoc +1. The javadoc tool did not generate any warning messages.

        javac +1. The applied patch does not generate any new javac compiler warnings.

        release audit +1. The applied patch does not generate any new release audit warnings.

        findbugs -1. The patch appears to introduce 84 new Findbugs warnings.

        core tests +1. The patch passed core unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/76/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/76/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/76/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/76/console

        This message is automatically generated.

        Show
        Hudson added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12390605/HAMA-62_v03.patch against trunk revision 697646. @author +1. The patch does not contain any @author tags. tests included +1. The patch appears to include 3 new or modified tests. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new javac compiler warnings. release audit +1. The applied patch does not generate any new release audit warnings. findbugs -1. The patch appears to introduce 84 new Findbugs warnings. core tests +1. The patch passed core unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/76/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/76/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/76/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/76/console This message is automatically generated.
        Hide
        Edward J. Yoon added a comment -

        Hmm. The v3 patch include only changes. BTW, the v2 seems deletes all and re-add all. (see build.xml part)

        Show
        Edward J. Yoon added a comment - Hmm. The v3 patch include only changes. BTW, the v2 seems deletes all and re-add all. (see build.xml part)
        Hide
        Sijie Guo added a comment -

        using "svn add " to add the files

        and using "svn diff " to generates the patch

        Show
        Sijie Guo added a comment - using "svn add " to add the files and using "svn diff " to generates the patch
        Hide
        Edward J. Yoon added a comment -

        How do you generate patch?

        Show
        Edward J. Yoon added a comment - How do you generate patch?
        Hide
        Edward J. Yoon added a comment -

        Rescheduling.

        Show
        Edward J. Yoon added a comment - Rescheduling.
        Hide
        Edward J. Yoon added a comment -

        Samuel, your patch seems odd.

        Show
        Edward J. Yoon added a comment - Samuel, your patch seems odd.
        Hide
        Sijie Guo added a comment -

        I feel so sorry about it.
        It seems that trunk revision of build.xml doesn't match.

        Show
        Sijie Guo added a comment - I feel so sorry about it. It seems that trunk revision of build.xml doesn't match.
        Hide
        Hudson added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12390603/HAMA-62_v02.patch
        against trunk revision 697646.

        @author +1. The patch does not contain any @author tags.

        tests included +1. The patch appears to include 12 new or modified tests.

        patch -1. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/75/console

        This message is automatically generated.

        Show
        Hudson added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12390603/HAMA-62_v02.patch against trunk revision 697646. @author +1. The patch does not contain any @author tags. tests included +1. The patch appears to include 12 new or modified tests. patch -1. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/75/console This message is automatically generated.
        Hide
        Sijie Guo added a comment -

        retry this.
        I add the dependency of javadoc to use javacc to generate the java files first.

        Show
        Sijie Guo added a comment - retry this. I add the dependency of javadoc to use javacc to generate the java files first.
        Hide
        Sijie Guo added a comment -

        Emm, I think that we should not add all the generated files to trunk.
        I think we can add some depends in <javadoc> target in build.xml

        sth like:
        <target name="javadoc" depends="cc-compile" ...>

        Show
        Sijie Guo added a comment - Emm, I think that we should not add all the generated files to trunk. I think we can add some depends in <javadoc> target in build.xml sth like: <target name="javadoc" depends="cc-compile" ...>
        Hide
        Sijie Guo added a comment -

        OK. I agree with you.

        Show
        Sijie Guo added a comment - OK. I agree with you.
        Hide
        Edward J. Yoon added a comment -

        OK..... Javadoc warnings are appeared. I think We should add an generated files to trunk, too.
        I would like to merge src-gen.dir and src.dir.


        [javadoc] /zonestorage/hudson/home/hudson/hudson/jobs/Hama-Patch/workspace/trunk/src/java/org/apache/hama/shell/HamaShellParser.java:29: package org.apache.hama.shell.parser.expression does not exist
        [javadoc] import org.apache.hama.shell.parser.expression.HamaExpressionParser;
        [javadoc] ^
        [javadoc] /zonestorage/hudson/home/hudson/hudson/jobs/Hama-Patch/workspace/trunk/src/java/org/apache/hama/shell/HamaShellParser.java:30: package org.apache.hama.shell.parser.script does not exist
        [javadoc] import org.apache.hama.shell.parser.script.HamaScriptParser;
        [javadoc] ^
        [javadoc] /zonestorage/hudson/home/hudson/hudson/jobs/Hama-Patch/workspace/trunk/src/java/org/apache/hama/shell/HamaShellParser.java:31: package org.apache.hama.shell.parser.script does not exist
        [javadoc] import org.apache.hama.shell.parser.script.HamaScriptParserTokenManager;
        [javadoc] ^
        [javadoc] /zonestorage/hudson/home/hudson/hudson/jobs/Hama-Patch/workspace/trunk/src/java/org/apache/hama/shell/HamaShellParser.java:33: cannot find symbol
        [javadoc] symbol: class HamaScriptParser
        [javadoc] public class HamaShellParser extends HamaScriptParser {
        [javadoc] ^
        [javadoc] /zonestorage/hudson/home/hudson/hudson/jobs/Hama-Patch/workspace/trunk/src/java/org/apache/hama/shell/HamaShellParser.java:43: cannot find symbol
        [javadoc] symbol : class HamaScriptParserTokenManager
        [javadoc] location: class org.apache.hama.shell.HamaShellParser
        [javadoc] public HamaShellParser(HamaScriptParserTokenManager tm, HamaShellEnv env,
        [javadoc] ^
        [javadoc] /zonestorage/hudson/home/hudson/hudson/jobs/Hama-Patch/workspace/trunk/src/java/org/apache/hama/shell/HamaShellParser.java:126: package org.apache.hama.shell.parser.expression does not exist
        [javadoc] org.apache.hama.shell.parser.expression.ParseException,
        [javadoc] ^
        [javadoc] /zonestorage/hudson/home/hudson/hudson/jobs/Hama-Patch/workspace/trunk/src/java/org/apache/hama/shell/HamaShellParser.java:127: package org.apache.hama.shell.parser.script does not exist
        [javadoc] org.apache.hama.shell.parser.script.ParseException {
        [javadoc] ^
        [javadoc] Standard Doclet version 1.6.0_06
        [javadoc] Building tree for all the packages and classes...
        [javadoc] Building index for all the packages and classes...
        [javadoc] Building index for all classes...
        [javadoc] Generating /zonestorage/hudson/home/hudson/hudson/jobs/Hama-Patch/workspace/trunk/build/docs/site/api/stylesheet.css...
        [javadoc] 7 warnings

        Show
        Edward J. Yoon added a comment - OK..... Javadoc warnings are appeared. I think We should add an generated files to trunk, too. I would like to merge src-gen.dir and src.dir. [javadoc] /zonestorage/hudson/home/hudson/hudson/jobs/Hama-Patch/workspace/trunk/src/java/org/apache/hama/shell/HamaShellParser.java:29: package org.apache.hama.shell.parser.expression does not exist [javadoc] import org.apache.hama.shell.parser.expression.HamaExpressionParser; [javadoc] ^ [javadoc] /zonestorage/hudson/home/hudson/hudson/jobs/Hama-Patch/workspace/trunk/src/java/org/apache/hama/shell/HamaShellParser.java:30: package org.apache.hama.shell.parser.script does not exist [javadoc] import org.apache.hama.shell.parser.script.HamaScriptParser; [javadoc] ^ [javadoc] /zonestorage/hudson/home/hudson/hudson/jobs/Hama-Patch/workspace/trunk/src/java/org/apache/hama/shell/HamaShellParser.java:31: package org.apache.hama.shell.parser.script does not exist [javadoc] import org.apache.hama.shell.parser.script.HamaScriptParserTokenManager; [javadoc] ^ [javadoc] /zonestorage/hudson/home/hudson/hudson/jobs/Hama-Patch/workspace/trunk/src/java/org/apache/hama/shell/HamaShellParser.java:33: cannot find symbol [javadoc] symbol: class HamaScriptParser [javadoc] public class HamaShellParser extends HamaScriptParser { [javadoc] ^ [javadoc] /zonestorage/hudson/home/hudson/hudson/jobs/Hama-Patch/workspace/trunk/src/java/org/apache/hama/shell/HamaShellParser.java:43: cannot find symbol [javadoc] symbol : class HamaScriptParserTokenManager [javadoc] location: class org.apache.hama.shell.HamaShellParser [javadoc] public HamaShellParser(HamaScriptParserTokenManager tm, HamaShellEnv env, [javadoc] ^ [javadoc] /zonestorage/hudson/home/hudson/hudson/jobs/Hama-Patch/workspace/trunk/src/java/org/apache/hama/shell/HamaShellParser.java:126: package org.apache.hama.shell.parser.expression does not exist [javadoc] org.apache.hama.shell.parser.expression.ParseException, [javadoc] ^ [javadoc] /zonestorage/hudson/home/hudson/hudson/jobs/Hama-Patch/workspace/trunk/src/java/org/apache/hama/shell/HamaShellParser.java:127: package org.apache.hama.shell.parser.script does not exist [javadoc] org.apache.hama.shell.parser.script.ParseException { [javadoc] ^ [javadoc] Standard Doclet version 1.6.0_06 [javadoc] Building tree for all the packages and classes... [javadoc] Building index for all the packages and classes... [javadoc] Building index for all classes... [javadoc] Generating /zonestorage/hudson/home/hudson/hudson/jobs/Hama-Patch/workspace/trunk/build/docs/site/api/stylesheet.css... [javadoc] 7 warnings
        Hide
        Hudson added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12390599/HAMA-62_v01.patch
        against trunk revision 697646.

        @author +1. The patch does not contain any @author tags.

        tests included +1. The patch appears to include 3 new or modified tests.

        javadoc -1. The javadoc tool appears to have generated 1 warning messages.

        javac +1. The applied patch does not generate any new javac compiler warnings.

        release audit +1. The applied patch does not generate any new release audit warnings.

        findbugs -1. The patch appears to introduce 84 new Findbugs warnings.

        core tests +1. The patch passed core unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/74/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/74/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/74/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/74/console

        This message is automatically generated.

        Show
        Hudson added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12390599/HAMA-62_v01.patch against trunk revision 697646. @author +1. The patch does not contain any @author tags. tests included +1. The patch appears to include 3 new or modified tests. javadoc -1. The javadoc tool appears to have generated 1 warning messages. javac +1. The applied patch does not generate any new javac compiler warnings. release audit +1. The applied patch does not generate any new release audit warnings. findbugs -1. The patch appears to introduce 84 new Findbugs warnings. core tests +1. The patch passed core unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/74/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/74/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/74/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/74/console This message is automatically generated.
        Hide
        Edward J. Yoon added a comment -

        Re-trying.

        Show
        Edward J. Yoon added a comment - Re-trying.
        Hide
        Sijie Guo added a comment -

        It seems that sth is wrong when patching "build.xml".

        Show
        Sijie Guo added a comment - It seems that sth is wrong when patching "build.xml".
        Hide
        Hudson added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12390589/HAMA-62.patch
        against trunk revision 697646.

        @author +1. The patch does not contain any @author tags.

        tests included +1. The patch appears to include 3 new or modified tests.

        patch -1. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/73/console

        This message is automatically generated.

        Show
        Hudson added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12390589/HAMA-62.patch against trunk revision 697646. @author +1. The patch does not contain any @author tags. tests included +1. The patch appears to include 3 new or modified tests. patch -1. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/73/console This message is automatically generated.
        Hide
        Edward J. Yoon added a comment -

        Looks great!! I committed javacc.jar. Let's try to get this.

        Show
        Edward J. Yoon added a comment - Looks great!! I committed javacc.jar. Let's try to get this.
        Hide
        Sijie Guo added a comment -

        hama shell uses the javacc to parse the scripts.

        Show
        Sijie Guo added a comment - hama shell uses the javacc to parse the scripts.
        Hide
        Edward J. Yoon added a comment -

        I would assign this to samuel.

        Show
        Edward J. Yoon added a comment - I would assign this to samuel.

          People

          • Assignee:
            Sijie Guo
            Reporter:
            Sijie Guo
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development