Details
-
Sub-task
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
0.5.0
-
None
-
None
Description
Suraj and I had a bit of discussion about incoming and outgoing message buffering and scalability.
Currently everything lies on the heap, causing huge amounts of GC and waste of memory. We can do better.
Therefore we need to extract an abstract Messenger class which is directly under the interface but over the compressor class.
It should abstract the use of the queues in the back (currently lot of duplicated code) and it should be backed by a sequencefile on local disk.
Once sync() starts it should return a message iterator for combining and then gets put into a message bundle which is send over RPC.
On the other side we get a bundle and looping over it putting everything into the heap making it much larger than it needs to be. Here we can also flush on disk because we are just using a queue-like method to the user-side.
Plus points:
In case we have enough heap (see our new metric system), we can also implement a buffering technology that is not flushing everything to disk.
Open questions:
I don't know how much slower the whole system gets, but it would save alot of memory. Maybe we should first evaluate if it is really needed.
In any case, the refactoring of the duplicate code in the messengers is needed.
