Details

    • Type: Wish Wish
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      While add new features, I made dirty codes. I wasn't sure that everything is really OK e.g., http://markmail.org/thread/w33zjwrmldfcdqtr but now I confirmed.

      It's time to refactoring all code.

      1. trivial01.patch
        2 kB
        Edward J. Yoon

        Activity

        Edward J. Yoon made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Edward J. Yoon [ udanax ]
        Resolution Won't Fix [ 2 ]
        Hide
        Edward J. Yoon added a comment -

        won't fix.

        Show
        Edward J. Yoon added a comment - won't fix.
        Edward J. Yoon made changes -
        Fix Version/s 0.4.0 [ 12316526 ]
        Affects Version/s 0.3.0 [ 12315100 ]
        Hide
        Thomas Jungblut added a comment -

        You can commit this, seems trivial to me.

        But please let this open, we should take care of the things I mentioned before.
        Anyways, there is a lot of refactoring besides that.

        Show
        Thomas Jungblut added a comment - You can commit this, seems trivial to me. But please let this open, we should take care of the things I mentioned before. Anyways, there is a lot of refactoring besides that.
        Hide
        Edward J. Yoon added a comment -

        Build passes. I'm commit to trunk.

        .jar
        [INFO] Installing /home/edward/workspace/hama-trunk/examples/dependency-reduced-pom.xml to /home/edward/.m2/repository/org/apache/hama/hama-examples/0.4.0-incubating-SNAPSHOT/hama-examples-0.4.0-incubating-SNAPSHOT.pom
        [INFO] ------------------------------------------------------------------------
        [INFO] Reactor Summary:
        [INFO] 
        [INFO] Apache Hama parent POM ............................ SUCCESS [0.658s]
        [INFO] Apache Hama Core .................................. SUCCESS [46.109s]
        [INFO] Apache Hama Graph Package ......................... SUCCESS [0.228s]
        [INFO] Apache Hama Examples .............................. SUCCESS [4.587s]
        [INFO] ------------------------------------------------------------------------
        [INFO] BUILD SUCCESS
        [INFO] ------------------------------------------------------------------------
        
        Show
        Edward J. Yoon added a comment - Build passes. I'm commit to trunk. .jar [INFO] Installing /home/edward/workspace/hama-trunk/examples/dependency-reduced-pom.xml to /home/edward/.m2/repository/org/apache/hama/hama-examples/0.4.0-incubating-SNAPSHOT/hama-examples-0.4.0-incubating-SNAPSHOT.pom [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Apache Hama parent POM ............................ SUCCESS [0.658s] [INFO] Apache Hama Core .................................. SUCCESS [46.109s] [INFO] Apache Hama Graph Package ......................... SUCCESS [0.228s] [INFO] Apache Hama Examples .............................. SUCCESS [4.587s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------
        Edward J. Yoon made changes -
        Field Original Value New Value
        Attachment trivial01.patch [ 12503609 ]
        Hide
        Edward J. Yoon added a comment -

        This patch deletes unnecessary file.

        Show
        Edward J. Yoon added a comment - This patch deletes unnecessary file.
        Hide
        Thomas Jungblut added a comment -

        We should finalize the classes and methods in a task, e.G. the peer.
        Finzalizing them will give us a bit more performance if we don't need inheritance there.

        But I guess we should first implement HAMA-461.

        Show
        Thomas Jungblut added a comment - We should finalize the classes and methods in a task, e.G. the peer. Finzalizing them will give us a bit more performance if we don't need inheritance there. But I guess we should first implement HAMA-461 .
        Hide
        Thomas Jungblut added a comment -

        It is fine, we all hack to get things running.

        Do you have concrete things that could be done?

        Show
        Thomas Jungblut added a comment - It is fine, we all hack to get things running. Do you have concrete things that could be done?
        Edward J. Yoon created issue -

          People

          • Assignee:
            Edward J. Yoon
            Reporter:
            Edward J. Yoon
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development