Hadoop Common
  1. Hadoop Common
  2. HADOOP-9907

Webapp http://hostname:port/metrics link is not working

    Details

    • Type: Bug Bug
    • Status: Patch Available
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: 2.3.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      This link is not working which just shows a blank page.

      1. HADOOP-9907.patch
        5 kB
        Akira AJISAKA

        Activity

        Hide
        Akira AJISAKA added a comment -

        I verified "/metrics" link is not working and "/jmx?qry=Hadoop:*" works with Hadoop 1.2.1.
        Should I create a patch for branch-1 also?

        Show
        Akira AJISAKA added a comment - I verified "/metrics" link is not working and "/jmx?qry=Hadoop:*" works with Hadoop 1.2.1. Should I create a patch for branch-1 also?
        Hide
        Vinod Kumar Vavilapalli added a comment -

        This isn't a blocker for 2.4. It's been around since the first release of 2.x line, not specifically a blocker for 2.4.

        Coming to the fix, let's make sure how jmx and /metrics are different in the 1.x lines. If they are equivalent, then the approach is fine, but let's check that first.

        Show
        Vinod Kumar Vavilapalli added a comment - This isn't a blocker for 2.4. It's been around since the first release of 2.x line, not specifically a blocker for 2.4. Coming to the fix, let's make sure how jmx and /metrics are different in the 1.x lines. If they are equivalent, then the approach is fine, but let's check that first.
        Hide
        Jian He added a comment -

        We can fix that separately in MR, patch looks good to me

        Show
        Jian He added a comment - We can fix that separately in MR, patch looks good to me
        Hide
        Jian He added a comment -

        Hi Akira AJISAKA, thanks for the patch.
        Seems like an existing bug, if I click the "server metrics" link on MR web app page, it will be redirected to the RM's "server metrics " instead of its own. Similarly the link for "/stacks".

        Show
        Jian He added a comment - Hi Akira AJISAKA , thanks for the patch. Seems like an existing bug, if I click the "server metrics" link on MR web app page, it will be redirected to the RM's "server metrics " instead of its own. Similarly the link for "/stacks".
        Hide
        Akira AJISAKA added a comment -

        This patch is just to move the link target, so new tests are not needed. In addition, the failures are not related to the patch.

        Show
        Akira AJISAKA added a comment - This patch is just to move the link target, so new tests are not needed. In addition, the failures are not related to the patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12637332/HADOOP-9907.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

        org.apache.hadoop.mapreduce.v2.app.TestFetchFailure
        org.apache.hadoop.mapreduce.v2.app.TestMRAppMaster
        org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3725//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3725//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637332/HADOOP-9907.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: org.apache.hadoop.mapreduce.v2.app.TestFetchFailure org.apache.hadoop.mapreduce.v2.app.TestMRAppMaster org.apache.hadoop.hdfs.server.namenode.TestCacheDirectives +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3725//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3725//console This message is automatically generated.
        Hide
        Akira AJISAKA added a comment -

        Attaching a patch to move the link target to /jmx?qry=Hadoop:*. I confirmed the link worked locally.

        Show
        Akira AJISAKA added a comment - Attaching a patch to move the link target to /jmx?qry=Hadoop:* . I confirmed the link worked locally.
        Hide
        Akira AJISAKA added a comment -

        I suggest moving the target to /jmx?qry=Hadoop:* to fix the dead link.

        Show
        Akira AJISAKA added a comment - I suggest moving the target to /jmx?qry=Hadoop:* to fix the dead link.
        Hide
        Harsh J added a comment -

        Wasn't the /jmx endpoint supposed to replace the /metrics going forward?

        @Xuan - I believe that servlet only serves MetricsV1, not V2?

        Show
        Harsh J added a comment - Wasn't the /jmx endpoint supposed to replace the /metrics going forward? @Xuan - I believe that servlet only serves MetricsV1, not V2?
        Hide
        Xuan Gong added a comment -
            addServlet("metrics", "/metrics", MetricsServlet.class);
        

        Does this line mean we have already added the metrics into httpServer ?

        Show
        Xuan Gong added a comment - addServlet( "metrics" , "/metrics" , MetricsServlet.class); Does this line mean we have already added the metrics into httpServer ?
        Hide
        Vinod Kumar Vavilapalli added a comment -

        Quick code walk-through with Jian He tells me that metrics2 was never integrated with the web-server. sigh.

        Show
        Vinod Kumar Vavilapalli added a comment - Quick code walk-through with Jian He tells me that metrics2 was never integrated with the web-server. sigh .

          People

          • Assignee:
            Akira AJISAKA
            Reporter:
            Jian He
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:

              Development