Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9822

create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.3.0
    • 2.8.0, 3.0.0-alpha1
    • None
    • Reviewed

    Description

      The magic number "16" is also used in ClientId.BYTE_LENGTH, so hard-coding magic number "16" is a bit confusing.

      Attachments

        1. HADOOP-9822.1.patch
          1 kB
          Tsuyoshi Ozawa
        2. HADOOP-9822.2.patch
          1 kB
          Tsuyoshi Ozawa
        3. HADOOP-9822.3.patch
          1 kB
          Tsuyoshi Ozawa
        4. HADOOP-9822.4.patch
          1 kB
          Tsuyoshi Ozawa

        Issue Links

          is related to

          Sub-task - The sub-task of the issue HDFS-5025 Record ClientId and CallId in EditLog to enable rebuilding retry cache in case of HA failover

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. HADOOP-9779 create constant RpcConstants.CLIENT_ID_LENGTH rather than hard-coding 16 everywhere

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            People

              ozawa Tsuyoshi Ozawa
              ozawa Tsuyoshi Ozawa
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: