Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9692

Improving log message when SequenceFile reader throws EOFException on zero-length file

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.3-alpha, 2.1.0-beta, 2.0.5-alpha
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      sequencefile reader throws EOFException on zero-length file, stacktrace as shown:

      Caused by: java.io.EOFException
      at java.io.DataInputStream.readFully(DataInputStream.java:180)
      at java.io.DataInputStream.readFully(DataInputStream.java:152)
      at org.apache.hadoop.io.SequenceFile$Reader.init(SequenceFile.java:1845)
      at org.apache.hadoop.io.SequenceFile$Reader.initialize(SequenceFile.java:1810)
      at org.apache.hadoop.io.SequenceFile$Reader.<init>(SequenceFile.java:1759)
      at org.apache.hadoop.io.SequenceFile$Reader.<init>(SequenceFile.java:1773)
      at org.apache.hadoop.mapred.SequenceFileRecordReader.<init>(SequenceFileRecordReader.java:49)
      at org.apache.hadoop.mapred.SequenceFileInputFormat.getRecordReader(SequenceFileInputFormat.java:64)
      at org.apache.hadoop.hive.ql.io.CombineHiveRecordReader.<init>(CombineHiveRecordReader.java:65)
      ... 16 more

      1. HADOOP-9692.patch
        1 kB
        Chu Tong
      2. HADOOP-9692.patch
        2 kB
        Chu Tong
      3. HADOOP-9692.patch
        2 kB
        Chu Tong
      4. HADOOP-9692.patch
        2 kB
        Chu Tong
      5. HADOOP-9692.patch
        2 kB
        Chu Tong
      6. HADOOP-9692.20151021.patch
        3 kB
        Zhe Zhang

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12590583/HADOOP-9692.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2722//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2722//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12590583/HADOOP-9692.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2722//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2722//console This message is automatically generated.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Thanks for contributing, Chu Tong!
        I reviewed your patch. Your fix seems to be OK.
        Additionally, could you add a test case for zero-length file to src/test/java/org/apache/hadoop/io/TestSequenceFile.java?

        Show
        ozawa Tsuyoshi Ozawa added a comment - Thanks for contributing, Chu Tong ! I reviewed your patch. Your fix seems to be OK. Additionally, could you add a test case for zero-length file to src/test/java/org/apache/hadoop/io/TestSequenceFile.java?
        Hide
        stayhf Chu Tong added a comment -

        will do

        Show
        stayhf Chu Tong added a comment - will do
        Hide
        stayhf Chu Tong added a comment -

        Update as suggested.

        Show
        stayhf Chu Tong added a comment - Update as suggested.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12590595/HADOOP-9692.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2726//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12590595/HADOOP-9692.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2726//console This message is automatically generated.
        Hide
        stayhf Chu Tong added a comment -

        oops, wrong upload, update with the right one

        Show
        stayhf Chu Tong added a comment - oops, wrong upload, update with the right one
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12590597/HADOOP-9692.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        -1 javac. The applied patch generated 1154 javac compiler warnings (more than the trunk's current 1153 warnings).

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2727//testReport/
        Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/2727//artifact/trunk/patchprocess/diffJavacWarnings.txt
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2727//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12590597/HADOOP-9692.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The applied patch generated 1154 javac compiler warnings (more than the trunk's current 1153 warnings). +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2727//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/2727//artifact/trunk/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2727//console This message is automatically generated.
        Hide
        stayhf Chu Tong added a comment -

        Resolve new warning

        Show
        stayhf Chu Tong added a comment - Resolve new warning
        Hide
        zjshen Zhijie Shen added a comment -

        Should we catch EOFException instead?

        +      } catch (Exception e) {
        

        Other IOException should be thrown to the callers.

        Show
        zjshen Zhijie Shen added a comment - Should we catch EOFException instead? + } catch (Exception e) { Other IOException should be thrown to the callers.
        Hide
        stayhf Chu Tong added a comment -

        There are two kinds of exception can be thrown here: IOException and EOFException, and both of them are because of the file can't be read correctly. Depending on how fine grind we want to go to, we can treat them both as file reading error or only catch EOFException and throws IOException.

        Show
        stayhf Chu Tong added a comment - There are two kinds of exception can be thrown here: IOException and EOFException, and both of them are because of the file can't be read correctly. Depending on how fine grind we want to go to, we can treat them both as file reading error or only catch EOFException and throws IOException.
        Hide
        zjshen Zhijie Shen added a comment -

        IMHO, IOException and EOFException needs to be treated differently. EOFException is a signal that indicate the end of the stream, such that what you're doing helps to surpass the case of reading a zero-length file. In contrast, IOException can be raised according to a number of other reasons. For example, the stream has already been closed before reading. If IOException is caught as well, reading a closed stream of a non-zero-length file is going to be regarded as reaching the end of stream as well. In this specific case, the function will enter the if block, and throw "not a SequenceFile" IOException instead, which I think it is not appropriate.

        Show
        zjshen Zhijie Shen added a comment - IMHO, IOException and EOFException needs to be treated differently. EOFException is a signal that indicate the end of the stream, such that what you're doing helps to surpass the case of reading a zero-length file. In contrast, IOException can be raised according to a number of other reasons. For example, the stream has already been closed before reading. If IOException is caught as well, reading a closed stream of a non-zero-length file is going to be regarded as reaching the end of stream as well. In this specific case, the function will enter the if block, and throw "not a SequenceFile" IOException instead, which I think it is not appropriate.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12590674/HADOOP-9692.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2729//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2729//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12590674/HADOOP-9692.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2729//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2729//console This message is automatically generated.
        Hide
        stayhf Chu Tong added a comment -

        I agree with you Zhijie, changed as suggested

        Show
        stayhf Chu Tong added a comment - I agree with you Zhijie, changed as suggested
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12590674/HADOOP-9692.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2731//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2731//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12590674/HADOOP-9692.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2731//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2731//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12590690/HADOOP-9692.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2734//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2734//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12590690/HADOOP-9692.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2734//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2734//console This message is automatically generated.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        +1 for the latest patch.

        Show
        ozawa Tsuyoshi Ozawa added a comment - +1 for the latest patch.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 30s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 27s There were no new javac warning messages.
        +1 javadoc 9m 33s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 5s The applied patch generated 1 new checkstyle issues (total was 280, now 280).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 common tests 23m 30s Tests passed in hadoop-common.
            60m 16s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12590690/HADOOP-9692.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / f1a152c
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6394/artifact/patchprocess/diffcheckstylehadoop-common.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6394/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6394/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6394/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 30s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 27s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 5s The applied patch generated 1 new checkstyle issues (total was 280, now 280). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 23m 30s Tests passed in hadoop-common.     60m 16s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12590690/HADOOP-9692.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f1a152c checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6394/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6394/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6394/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6394/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 34s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 29s There were no new javac warning messages.
        +1 javadoc 9m 36s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 5s The applied patch generated 1 new checkstyle issues (total was 279, now 279).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 common tests 22m 41s Tests passed in hadoop-common.
            59m 39s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12590690/HADOOP-9692.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 6ae2a0d
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6411/artifact/patchprocess/diffcheckstylehadoop-common.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6411/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6411/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6411/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 34s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 5s The applied patch generated 1 new checkstyle issues (total was 279, now 279). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 22m 41s Tests passed in hadoop-common.     59m 39s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12590690/HADOOP-9692.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6ae2a0d checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6411/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6411/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6411/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6411/console This message was automatically generated.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        +1, committing this shortly.

        Show
        ozawa Tsuyoshi Ozawa added a comment - +1, committing this shortly.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Rethinking of this before committing - I think we should re-throw EOFException with a message 'this " not a SequenceFile"' if EOFException is raised.

        Zhijie Shen what do you think?

        Show
        ozawa Tsuyoshi Ozawa added a comment - Rethinking of this before committing - I think we should re-throw EOFException with a message 'this " not a SequenceFile"' if EOFException is raised. Zhijie Shen what do you think?
        Hide
        zhz Zhe Zhang added a comment -

        Tsuyoshi Ozawa Zhijie Shen: Maybe we should quickly revisit the last pending question and reach a conclusion? Thanks!

        Show
        zhz Zhe Zhang added a comment - Tsuyoshi Ozawa Zhijie Shen : Maybe we should quickly revisit the last pending question and reach a conclusion? Thanks!
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 37s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 39s There were no new javac warning messages.
        +1 javadoc 9m 42s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 7s The applied patch generated 1 new checkstyle issues (total was 279, now 279).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 20s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 22m 30s Tests passed in hadoop-common.
            61m 47s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12590690/HADOOP-9692.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / f4ca530
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7212/artifact/patchprocess/diffcheckstylehadoop-common.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7212/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7212/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7212/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 37s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 39s There were no new javac warning messages. +1 javadoc 9m 42s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 7s The applied patch generated 1 new checkstyle issues (total was 279, now 279). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 20s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 30s Tests passed in hadoop-common.     61m 47s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12590690/HADOOP-9692.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / f4ca530 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7212/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7212/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7212/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7212/console This message was automatically generated.
        Hide
        zhz Zhe Zhang added a comment -

        Reading the patch again I agree with the suggestion from Tsuyoshi Ozawa. It makes sense to preserve the type of exception. I revised the patch a little bit.

        Tsuyoshi Ozawa Zhijie Shen Could you help with a quick re-review? Thanks!

        Show
        zhz Zhe Zhang added a comment - Reading the patch again I agree with the suggestion from Tsuyoshi Ozawa . It makes sense to preserve the type of exception. I revised the patch a little bit. Tsuyoshi Ozawa Zhijie Shen Could you help with a quick re-review? Thanks!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 36s docker + precommit patch detected.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 10m 22s trunk passed
        +1 compile 4m 26s trunk passed with JDK v1.8.0_60
        +1 compile 4m 10s trunk passed with JDK v1.7.0_79
        +1 checkstyle 0m 19s trunk passed
        +1 mvneclipse 0m 17s trunk passed
        +1 findbugs 1m 46s trunk passed
        +1 javadoc 0m 54s trunk passed with JDK v1.8.0_60
        +1 javadoc 1m 2s trunk passed with JDK v1.7.0_79
        +1 mvninstall 1m 33s the patch passed
        +1 compile 4m 17s the patch passed with JDK v1.8.0_60
        +1 javac 4m 17s the patch passed
        +1 compile 4m 8s the patch passed with JDK v1.7.0_79
        +1 javac 4m 8s the patch passed
        -1 checkstyle 0m 13s Patch generated 1 new checkstyle issues in hadoop-common-project/hadoop-common (total was 279, now 277).
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 1m 46s the patch passed
        +1 javadoc 0m 52s the patch passed with JDK v1.8.0_60
        +1 javadoc 1m 1s the patch passed with JDK v1.7.0_79
        -1 unit 6m 33s hadoop-common in the patch failed with JDK v1.8.0_60.
        +1 unit 6m 48s hadoop-common in the patch passed with JDK v1.7.0_79.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        52m 42s



        Reason Tests
        JDK v1.7.0_79 Failed junit tests hadoop.ipc.TestIPC



        Subsystem Report/Notes
        Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-21
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767837/HADOOP-9692.20151021.patch
        JIRA Issue HADOOP-9692
        Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile
        uname Linux 6c98b92a32e7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh
        git revision trunk / d759b4b
        Default Java 1.7.0_79
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7903/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7903/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
        unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7903/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
        JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7903/testReport/
        Max memory used 228MB
        Powered by Apache Yetus http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7903/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 36s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 10m 22s trunk passed +1 compile 4m 26s trunk passed with JDK v1.8.0_60 +1 compile 4m 10s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 19s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 1m 46s trunk passed +1 javadoc 0m 54s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 2s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 33s the patch passed +1 compile 4m 17s the patch passed with JDK v1.8.0_60 +1 javac 4m 17s the patch passed +1 compile 4m 8s the patch passed with JDK v1.7.0_79 +1 javac 4m 8s the patch passed -1 checkstyle 0m 13s Patch generated 1 new checkstyle issues in hadoop-common-project/hadoop-common (total was 279, now 277). +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 46s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 1s the patch passed with JDK v1.7.0_79 -1 unit 6m 33s hadoop-common in the patch failed with JDK v1.8.0_60. +1 unit 6m 48s hadoop-common in the patch passed with JDK v1.7.0_79. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 52m 42s Reason Tests JDK v1.7.0_79 Failed junit tests hadoop.ipc.TestIPC Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-21 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12767837/HADOOP-9692.20151021.patch JIRA Issue HADOOP-9692 Optional Tests asflicense javac javadoc mvninstall unit findbugs checkstyle compile uname Linux 6c98b92a32e7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh git revision trunk / d759b4b Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7903/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7903/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7903/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7903/testReport/ Max memory used 228MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7903/console This message was automatically generated.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        +1, checking this in.

        Show
        ozawa Tsuyoshi Ozawa added a comment - +1, checking this in.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Committed this to trunk and branch-2. Thanks Zhe Zhang and Chu Tong for your contribution, and thanks Zhijie Shen for your review!

        Show
        ozawa Tsuyoshi Ozawa added a comment - Committed this to trunk and branch-2. Thanks Zhe Zhang and Chu Tong for your contribution, and thanks Zhijie Shen for your review!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8687 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8687/)
        HADOOP-9692. SequenceFile reader throws EOFException on zero-length (ozawa: rev b5ca649bff01c906033d71c9f983b4cdaa71a9d1)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
          HADOOP-9692. Improving log message when SequenceFile reader throws (ozawa: rev 381610da620121c02073dbbaac669b80b41959b4)
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8687 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8687/ ) HADOOP-9692 . SequenceFile reader throws EOFException on zero-length (ozawa: rev b5ca649bff01c906033d71c9f983b4cdaa71a9d1) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java HADOOP-9692 . Improving log message when SequenceFile reader throws (ozawa: rev 381610da620121c02073dbbaac669b80b41959b4) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #582 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/582/)
        HADOOP-9692. SequenceFile reader throws EOFException on zero-length (ozawa: rev b5ca649bff01c906033d71c9f983b4cdaa71a9d1)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
          HADOOP-9692. Improving log message when SequenceFile reader throws (ozawa: rev 381610da620121c02073dbbaac669b80b41959b4)
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #582 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/582/ ) HADOOP-9692 . SequenceFile reader throws EOFException on zero-length (ozawa: rev b5ca649bff01c906033d71c9f983b4cdaa71a9d1) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java HADOOP-9692 . Improving log message when SequenceFile reader throws (ozawa: rev 381610da620121c02073dbbaac669b80b41959b4) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1303 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1303/)
        HADOOP-9692. SequenceFile reader throws EOFException on zero-length (ozawa: rev b5ca649bff01c906033d71c9f983b4cdaa71a9d1)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
          HADOOP-9692. Improving log message when SequenceFile reader throws (ozawa: rev 381610da620121c02073dbbaac669b80b41959b4)
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1303 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1303/ ) HADOOP-9692 . SequenceFile reader throws EOFException on zero-length (ozawa: rev b5ca649bff01c906033d71c9f983b4cdaa71a9d1) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java HADOOP-9692 . Improving log message when SequenceFile reader throws (ozawa: rev 381610da620121c02073dbbaac669b80b41959b4) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #567 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/567/)
        HADOOP-9692. SequenceFile reader throws EOFException on zero-length (ozawa: rev b5ca649bff01c906033d71c9f983b4cdaa71a9d1)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
          HADOOP-9692. Improving log message when SequenceFile reader throws (ozawa: rev 381610da620121c02073dbbaac669b80b41959b4)
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #567 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/567/ ) HADOOP-9692 . SequenceFile reader throws EOFException on zero-length (ozawa: rev b5ca649bff01c906033d71c9f983b4cdaa71a9d1) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt HADOOP-9692 . Improving log message when SequenceFile reader throws (ozawa: rev 381610da620121c02073dbbaac669b80b41959b4) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2514 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2514/)
        HADOOP-9692. SequenceFile reader throws EOFException on zero-length (ozawa: rev b5ca649bff01c906033d71c9f983b4cdaa71a9d1)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
          HADOOP-9692. Improving log message when SequenceFile reader throws (ozawa: rev 381610da620121c02073dbbaac669b80b41959b4)
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2514 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2514/ ) HADOOP-9692 . SequenceFile reader throws EOFException on zero-length (ozawa: rev b5ca649bff01c906033d71c9f983b4cdaa71a9d1) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java HADOOP-9692 . Improving log message when SequenceFile reader throws (ozawa: rev 381610da620121c02073dbbaac669b80b41959b4) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #525 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/525/)
        HADOOP-9692. SequenceFile reader throws EOFException on zero-length (ozawa: rev b5ca649bff01c906033d71c9f983b4cdaa71a9d1)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
          HADOOP-9692. Improving log message when SequenceFile reader throws (ozawa: rev 381610da620121c02073dbbaac669b80b41959b4)
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #525 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/525/ ) HADOOP-9692 . SequenceFile reader throws EOFException on zero-length (ozawa: rev b5ca649bff01c906033d71c9f983b4cdaa71a9d1) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt HADOOP-9692 . Improving log message when SequenceFile reader throws (ozawa: rev 381610da620121c02073dbbaac669b80b41959b4) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2462 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2462/)
        HADOOP-9692. SequenceFile reader throws EOFException on zero-length (ozawa: rev b5ca649bff01c906033d71c9f983b4cdaa71a9d1)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
          HADOOP-9692. Improving log message when SequenceFile reader throws (ozawa: rev 381610da620121c02073dbbaac669b80b41959b4)
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2462 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2462/ ) HADOOP-9692 . SequenceFile reader throws EOFException on zero-length (ozawa: rev b5ca649bff01c906033d71c9f983b4cdaa71a9d1) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java HADOOP-9692 . Improving log message when SequenceFile reader throws (ozawa: rev 381610da620121c02073dbbaac669b80b41959b4) hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        zhz Zhe Zhang added a comment -

        Thanks Tsuyoshi Ozawa for reviewing again!

        Show
        zhz Zhe Zhang added a comment - Thanks Tsuyoshi Ozawa for reviewing again!
        Hide
        zhz Zhe Zhang added a comment -

        Tsuyoshi Ozawa I find 2 git commits in trunk and the 2nd one (381610da620121c02073dbbaac669b80b41959b4) is just to update CHANGES.txt. But only this CHANGES.txt update was cherry-picked to branch-2. I'll try to cherry-pick the other commit too.

        Show
        zhz Zhe Zhang added a comment - Tsuyoshi Ozawa I find 2 git commits in trunk and the 2nd one (381610da620121c02073dbbaac669b80b41959b4) is just to update CHANGES.txt . But only this CHANGES.txt update was cherry-picked to branch-2. I'll try to cherry-pick the other commit too.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Zhe Zhang oh, that's my mistake. I'll fix it.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Zhe Zhang oh, that's my mistake. I'll fix it.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Done. Thank you for pinging me.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Done. Thank you for pinging me.
        Hide
        zhz Zhe Zhang added a comment -

        Thanks!

        Show
        zhz Zhe Zhang added a comment - Thanks!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8693 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8693/)
        Revert HADOOP-9692. (ozawa: rev 039a1f9e968690cb66af224858e6e64b4f0b2926)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
          HADOOP-9692. Improving log message when SequenceFile reader throws (ozawa: rev 513ec3de194f705ca342de16829e1f85be227e7f)
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8693 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8693/ ) Revert HADOOP-9692 . (ozawa: rev 039a1f9e968690cb66af224858e6e64b4f0b2926) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java HADOOP-9692 . Improving log message when SequenceFile reader throws (ozawa: rev 513ec3de194f705ca342de16829e1f85be227e7f) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #571 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/571/)
        Revert HADOOP-9692. (ozawa: rev 039a1f9e968690cb66af224858e6e64b4f0b2926)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
          HADOOP-9692. Improving log message when SequenceFile reader throws (ozawa: rev 513ec3de194f705ca342de16829e1f85be227e7f)
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #571 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/571/ ) Revert HADOOP-9692 . (ozawa: rev 039a1f9e968690cb66af224858e6e64b4f0b2926) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt HADOOP-9692 . Improving log message when SequenceFile reader throws (ozawa: rev 513ec3de194f705ca342de16829e1f85be227e7f) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1307 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1307/)
        Revert HADOOP-9692. (ozawa: rev 039a1f9e968690cb66af224858e6e64b4f0b2926)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
          HADOOP-9692. Improving log message when SequenceFile reader throws (ozawa: rev 513ec3de194f705ca342de16829e1f85be227e7f)
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1307 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1307/ ) Revert HADOOP-9692 . (ozawa: rev 039a1f9e968690cb66af224858e6e64b4f0b2926) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java HADOOP-9692 . Improving log message when SequenceFile reader throws (ozawa: rev 513ec3de194f705ca342de16829e1f85be227e7f) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #586 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/586/)
        Revert HADOOP-9692. (ozawa: rev 039a1f9e968690cb66af224858e6e64b4f0b2926)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
          HADOOP-9692. Improving log message when SequenceFile reader throws (ozawa: rev 513ec3de194f705ca342de16829e1f85be227e7f)
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #586 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/586/ ) Revert HADOOP-9692 . (ozawa: rev 039a1f9e968690cb66af224858e6e64b4f0b2926) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt HADOOP-9692 . Improving log message when SequenceFile reader throws (ozawa: rev 513ec3de194f705ca342de16829e1f85be227e7f) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2465 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2465/)
        Revert HADOOP-9692. (ozawa: rev 039a1f9e968690cb66af224858e6e64b4f0b2926)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
          HADOOP-9692. Improving log message when SequenceFile reader throws (ozawa: rev 513ec3de194f705ca342de16829e1f85be227e7f)
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2465 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2465/ ) Revert HADOOP-9692 . (ozawa: rev 039a1f9e968690cb66af224858e6e64b4f0b2926) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt HADOOP-9692 . Improving log message when SequenceFile reader throws (ozawa: rev 513ec3de194f705ca342de16829e1f85be227e7f) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2518 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2518/)
        Revert HADOOP-9692. (ozawa: rev 039a1f9e968690cb66af224858e6e64b4f0b2926)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
          HADOOP-9692. Improving log message when SequenceFile reader throws (ozawa: rev 513ec3de194f705ca342de16829e1f85be227e7f)
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2518 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2518/ ) Revert HADOOP-9692 . (ozawa: rev 039a1f9e968690cb66af224858e6e64b4f0b2926) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java HADOOP-9692 . Improving log message when SequenceFile reader throws (ozawa: rev 513ec3de194f705ca342de16829e1f85be227e7f) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #529 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/529/)
        Revert HADOOP-9692. (ozawa: rev 039a1f9e968690cb66af224858e6e64b4f0b2926)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
          HADOOP-9692. Improving log message when SequenceFile reader throws (ozawa: rev 513ec3de194f705ca342de16829e1f85be227e7f)
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #529 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/529/ ) Revert HADOOP-9692 . (ozawa: rev 039a1f9e968690cb66af224858e6e64b4f0b2926) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java HADOOP-9692 . Improving log message when SequenceFile reader throws (ozawa: rev 513ec3de194f705ca342de16829e1f85be227e7f) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/SequenceFile.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/TestSequenceFile.java hadoop-common-project/hadoop-common/CHANGES.txt

          People

          • Assignee:
            zhz Zhe Zhang
            Reporter:
            stayhf Chu Tong
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development