Hadoop Common
  1. Hadoop Common
  2. HADOOP-9543

TestFsShellReturnCode may fail in branch-1

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There is a hardcoded username "admin" in TestFsShellReturnCode. If "admin" does not exist in the local fs, the test may fail. Before HADOOP-9502, the failure of the command is ignored silently, i.e. the command returns success even if it indeed failed.

      1. c9543_20130502.patch
        1 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Tsz Wo Nicholas Sze created issue -
          Tsz Wo Nicholas Sze made changes -
          Field Original Value New Value
          Project Hadoop HDFS [ 12310942 ] Hadoop Common [ 12310240 ]
          Key HDFS-4790 HADOOP-9543
          Component/s test [ 12311440 ]
          Component/s test [ 12312916 ]
          Tsz Wo Nicholas Sze made changes -
          Link This issue relates to HADOOP-9502 [ HADOOP-9502 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          c9543_20130502.patch: uses current username

          Show
          Tsz Wo Nicholas Sze added a comment - c9543_20130502.patch: uses current username
          Tsz Wo Nicholas Sze made changes -
          Attachment c9543_20130502.patch [ 12581575 ]
          Hide
          Arpit Agarwal added a comment -

          +1

          Show
          Arpit Agarwal added a comment - +1
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Manually tested TestFsShellReturnCode. It passed in my machine after the patch.

          Show
          Tsz Wo Nicholas Sze added a comment - Manually tested TestFsShellReturnCode. It passed in my machine after the patch.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Thanks Arpit for reviewing the patch.

          I have committed this.

          Show
          Tsz Wo Nicholas Sze added a comment - Thanks Arpit for reviewing the patch. I have committed this.
          Tsz Wo Nicholas Sze made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 1.2.0 [ 12321659 ]
          Resolution Fixed [ 1 ]
          Hide
          Suresh Srinivas added a comment -

          +1 for the patch.

          Show
          Suresh Srinivas added a comment - +1 for the patch.
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop 1.2.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.
          Matt Foley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          1h 54m 1 Tsz Wo Nicholas Sze 02/May/13 21:47
          Resolved Resolved Closed Closed
          12d 8h 28m 1 Matt Foley 15/May/13 06:16

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development