Thank you very much for your comments, really sorry for late reply.
When isPosix is true, is it an error if any of gitAttribute and uidAttribute is null? or this is a valid scenario (in this case, no group will be found for the user)?
Good suggestion, it will be an improvement to check the configuration. Not only for posix, but also for normal ldap model. Do you think it is possible to let me file another jira to fix it.
change "POSIX_GIDNUMBER" to " POSIX_GIDNUMBER" (add a space to be consistent)
Good suggestion, I will fix it in next patch.
Line 371 you added to assign isPosix exceed 80 characters (some other lines that you did not touch in this file also exceeds 80 chars, up to you whether to fix all of them together or defer to later).
Yes, some code in this file even exceed 100 characters. These should be fixed. I will fix my new lines in next patch, do you think it is possible to let me file another jira to fix others.
Have you got chance to test it out in a real environment?
Yes, I created the posix user\group example in a real ldap environment, the Unit test is also created based on it.
why public static final String POSIX_USER = "posixAccount"; is not public static final String POSIX_USER = "posixUser";?
I will rename POSIX_USER to POSIX_ACCOUNT in next patch since posixAccount is on LDAP specification and we may can't change it. http://docs.oracle.com/cd/E19693-01/819-0986/6n3chgmli/index.html#NAME . Thank again for your good suggestion.