Hadoop Common
  1. Hadoop Common
  2. HADOOP-9467

Metrics2 record filtering (.record.filter.include/exclude) does not filter by name

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 3.0.0, 1-win, 2.0.4-alpha
    • Fix Version/s: 1.2.0, 2.0.4-alpha
    • Component/s: metrics
    • Labels:
      None

      Description

      Filtering by record considers only the record's tag for filtering and not the record's name.

      1. HADOOP-9467.1.patch
        6 kB
        Chris Nauroth
      2. HADOOP-9467-branch-1.1.patch
        6 kB
        Chris Nauroth

        Activity

        Hide
        Chris Nauroth added a comment -

        This changes the filtering to consider both record name and tags. I've also added unit tests to cover these cases.

        I've attached patches for trunk and branch-1. Please commit the branch-1 patch to branch-1-win also.

        Credit for this patch should go to both me and Ganeshan Iyer. Thanks!

        Show
        Chris Nauroth added a comment - This changes the filtering to consider both record name and tags. I've also added unit tests to cover these cases. I've attached patches for trunk and branch-1. Please commit the branch-1 patch to branch-1-win also. Credit for this patch should go to both me and Ganeshan Iyer. Thanks!
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12577955/HADOOP-9467.1.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2433//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2433//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12577955/HADOOP-9467.1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2433//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2433//console This message is automatically generated.
        Hide
        Luke Lu added a comment -

        The patches lgtm. +1. Thanks Chris and Ganeshan! Will commit shortly.

        Show
        Luke Lu added a comment - The patches lgtm. +1. Thanks Chris and Ganeshan! Will commit shortly.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3588 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3588/)
        HADOOP-9467. Metrics2 record filter should check name as well as tags. (Ganeshan Iyler via llu) (Revision 1466377)

        Result = SUCCESS
        llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1466377
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/MetricsFilter.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/filter/TestPatternFilter.java
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #3588 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3588/ ) HADOOP-9467 . Metrics2 record filter should check name as well as tags. (Ganeshan Iyler via llu) (Revision 1466377) Result = SUCCESS llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1466377 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/MetricsFilter.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/filter/TestPatternFilter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #179 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/179/)
        HADOOP-9467. Metrics2 record filter should check name as well as tags. (Ganeshan Iyler via llu) (Revision 1466377)

        Result = SUCCESS
        llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1466377
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/MetricsFilter.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/filter/TestPatternFilter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Yarn-trunk #179 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/179/ ) HADOOP-9467 . Metrics2 record filter should check name as well as tags. (Ganeshan Iyler via llu) (Revision 1466377) Result = SUCCESS llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1466377 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/MetricsFilter.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/filter/TestPatternFilter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1368 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1368/)
        HADOOP-9467. Metrics2 record filter should check name as well as tags. (Ganeshan Iyler via llu) (Revision 1466377)

        Result = FAILURE
        llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1466377
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/MetricsFilter.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/filter/TestPatternFilter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1368 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1368/ ) HADOOP-9467 . Metrics2 record filter should check name as well as tags. (Ganeshan Iyler via llu) (Revision 1466377) Result = FAILURE llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1466377 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/MetricsFilter.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/filter/TestPatternFilter.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1395 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1395/)
        HADOOP-9467. Metrics2 record filter should check name as well as tags. (Ganeshan Iyler via llu) (Revision 1466377)

        Result = SUCCESS
        llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1466377
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/MetricsFilter.java
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/filter/TestPatternFilter.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1395 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1395/ ) HADOOP-9467 . Metrics2 record filter should check name as well as tags. (Ganeshan Iyler via llu) (Revision 1466377) Result = SUCCESS llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1466377 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/MetricsFilter.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/filter/TestPatternFilter.java
        Hide
        Chris Nauroth added a comment -

        Luke, thank you for the quick review and commit!

        Show
        Chris Nauroth added a comment - Luke, thank you for the quick review and commit!
        Hide
        Suresh Srinivas added a comment -

        Luke, when committing please add both the contributors name. Can you please update the CHANGES.txt to include Chris's name?

        Show
        Suresh Srinivas added a comment - Luke, when committing please add both the contributors name. Can you please update the CHANGES.txt to include Chris's name?
        Hide
        Luke Lu added a comment -

        Sure, will do. Looks like I misread Chris' credit line

        Show
        Luke Lu added a comment - Sure, will do. Looks like I misread Chris' credit line
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3619 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3619/)
        Fix HADOOP-9467 attribution. (Revision 1468731)

        Result = SUCCESS
        llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1468731
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #3619 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3619/ ) Fix HADOOP-9467 attribution. (Revision 1468731) Result = SUCCESS llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1468731 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Chris Nauroth added a comment -

        No worries, Luke. Thanks for taking the time to correct it.

        Suresh, thank you for spotting this and requesting the correction. I hadn't noticed it myself.

        Show
        Chris Nauroth added a comment - No worries, Luke. Thanks for taking the time to correct it. Suresh, thank you for spotting this and requesting the correction. I hadn't noticed it myself.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #186 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/186/)
        Fix HADOOP-9467 attribution. (Revision 1468731)

        Result = SUCCESS
        llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1468731
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Yarn-trunk #186 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/186/ ) Fix HADOOP-9467 attribution. (Revision 1468731) Result = SUCCESS llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1468731 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1375 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1375/)
        Fix HADOOP-9467 attribution. (Revision 1468731)

        Result = FAILURE
        llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1468731
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1375 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1375/ ) Fix HADOOP-9467 attribution. (Revision 1468731) Result = FAILURE llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1468731 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1402 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1402/)
        Fix HADOOP-9467 attribution. (Revision 1468731)

        Result = SUCCESS
        llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1468731
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1402 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1402/ ) Fix HADOOP-9467 attribution. (Revision 1468731) Result = SUCCESS llu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1468731 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

          People

          • Assignee:
            Chris Nauroth
            Reporter:
            Chris Nauroth
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development