Amir, have you signed icla? See - http://www.apache.org/licenses/icla.txt. Once you sign the icla, I will add you as a contributor, assign this jira and commit the patch.

Minor comments:

1. Can you name fIBMJVM to IBMJVM?
2. Can you please use java conditional operator ?: instead of if else.

Good morning Suresh, yes I have signed and emailed icla. good suggestions, will make the modification .

Suresh, please review the latest patch.If it is acceptable, i will apply same changes into Branch2 patch. BTW, thanks for adding me as a contributor.

Instead duplicating the logic in 2 different classes, wouldn't make sense to have in the SSLFactory class a public static String getCertificateType() method?

Alejandro, I like the way you think and I am in complete agreement. Our goal was to minimize number of files impacted by IBM JAVA enablement process . Will gladly make recommended modifications. Will resubmit the patch after executing all unit testcases, for regression, on both IBM and Oracle JAVA.

modified trunk patch based on Alejandro recommendation.. please review, Thanks

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12575480/HADOOP-9430-trunk-v3.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2365//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2365//console

This message is automatically generated.

Minor update to the patch to format the lines to be with in 80 columns.

I committed the patch to trunk and branch-2. Thank you Amir!

Integrated in Hadoop-trunk-Commit #3531 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3531/)
HADOOP-9430. TestSSLFactory fails on IBM JVM. Contributed by Amir Sanjar. (Revision 1461268)

Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1461268
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/ReloadingX509TrustManager.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java

Integrated in Hadoop-Yarn-trunk #168 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/168/)
HADOOP-9430. TestSSLFactory fails on IBM JVM. Contributed by Amir Sanjar. (Revision 1461268)

Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1461268
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/ReloadingX509TrustManager.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java

Integrated in Hadoop-Hdfs-trunk #1357 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1357/)
HADOOP-9430. TestSSLFactory fails on IBM JVM. Contributed by Amir Sanjar. (Revision 1461268)

Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1461268
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/ReloadingX509TrustManager.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java

Integrated in Hadoop-Mapreduce-trunk #1385 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1385/)
HADOOP-9430. TestSSLFactory fails on IBM JVM. Contributed by Amir Sanjar. (Revision 1461268)

Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1461268
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/ReloadingX509TrustManager.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java