Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.3-alpha
    • Fix Version/s: 2.1.0-beta
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HADOOP-9430-trunk.patch
      2 kB
      Amir Sanjar
    2. HADOOP-9430-branch2.patch
      2 kB
      Tian Hong Wang
    3. HADOOP-9430-trunk-v2.patch
      2 kB
      Amir Sanjar
    4. HADOOP-9430-trunk-v3.patch
      3 kB
      Amir Sanjar
    5. HADOOP-9430.patch
      3 kB
      Suresh Srinivas

      Activity

      Hide
      Suresh Srinivas added a comment -

      Amir, have you signed icla? See - http://www.apache.org/licenses/icla.txt. Once you sign the icla, I will add you as a contributor, assign this jira and commit the patch.

      Minor comments:

      1. Can you name fIBMJVM to IBMJVM?
      2. Can you please use java conditional operator ?: instead of if else.
      Show
      Suresh Srinivas added a comment - Amir, have you signed icla? See - http://www.apache.org/licenses/icla.txt . Once you sign the icla, I will add you as a contributor, assign this jira and commit the patch. Minor comments: Can you name fIBMJVM to IBMJVM ? Can you please use java conditional operator ?: instead of if else.
      Hide
      Amir Sanjar added a comment -

      Good morning Suresh, yes I have signed and emailed icla. good suggestions, will make the modification .

      Show
      Amir Sanjar added a comment - Good morning Suresh, yes I have signed and emailed icla. good suggestions, will make the modification .
      Hide
      Amir Sanjar added a comment -

      Suresh, please review the latest patch.If it is acceptable, i will apply same changes into Branch2 patch. BTW, thanks for adding me as a contributor.

      Show
      Amir Sanjar added a comment - Suresh, please review the latest patch.If it is acceptable, i will apply same changes into Branch2 patch. BTW, thanks for adding me as a contributor.
      Hide
      Alejandro Abdelnur added a comment -

      Instead duplicating the logic in 2 different classes, wouldn't make sense to have in the SSLFactory class a public static String getCertificateType() method?

      Show
      Alejandro Abdelnur added a comment - Instead duplicating the logic in 2 different classes, wouldn't make sense to have in the SSLFactory class a public static String getCertificateType() method?
      Hide
      Amir Sanjar added a comment -

      Alejandro, I like the way you think and I am in complete agreement. Our goal was to minimize number of files impacted by IBM JAVA enablement process . Will gladly make recommended modifications. Will resubmit the patch after executing all unit testcases, for regression, on both IBM and Oracle JAVA.

      Show
      Amir Sanjar added a comment - Alejandro, I like the way you think and I am in complete agreement. Our goal was to minimize number of files impacted by IBM JAVA enablement process . Will gladly make recommended modifications. Will resubmit the patch after executing all unit testcases, for regression, on both IBM and Oracle JAVA.
      Hide
      Amir Sanjar added a comment -

      modified trunk patch based on Alejandro recommendation.. please review, Thanks

      Show
      Amir Sanjar added a comment - modified trunk patch based on Alejandro recommendation.. please review, Thanks
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12575480/HADOOP-9430-trunk-v3.patch
      against trunk revision .

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 eclipse:eclipse. The patch built with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2365//testReport/
      Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2365//console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12575480/HADOOP-9430-trunk-v3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2365//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2365//console This message is automatically generated.
      Hide
      Suresh Srinivas added a comment -

      Minor update to the patch to format the lines to be with in 80 columns.

      Show
      Suresh Srinivas added a comment - Minor update to the patch to format the lines to be with in 80 columns.
      Hide
      Suresh Srinivas added a comment -

      I committed the patch to trunk and branch-2. Thank you Amir!

      Show
      Suresh Srinivas added a comment - I committed the patch to trunk and branch-2. Thank you Amir!
      Hide
      Hudson added a comment -

      Integrated in Hadoop-trunk-Commit #3531 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3531/)
      HADOOP-9430. TestSSLFactory fails on IBM JVM. Contributed by Amir Sanjar. (Revision 1461268)

      Result = SUCCESS
      suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1461268
      Files :

      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/ReloadingX509TrustManager.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java
      Show
      Hudson added a comment - Integrated in Hadoop-trunk-Commit #3531 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3531/ ) HADOOP-9430 . TestSSLFactory fails on IBM JVM. Contributed by Amir Sanjar. (Revision 1461268) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1461268 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/ReloadingX509TrustManager.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Yarn-trunk #168 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/168/)
      HADOOP-9430. TestSSLFactory fails on IBM JVM. Contributed by Amir Sanjar. (Revision 1461268)

      Result = SUCCESS
      suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1461268
      Files :

      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/ReloadingX509TrustManager.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java
      Show
      Hudson added a comment - Integrated in Hadoop-Yarn-trunk #168 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/168/ ) HADOOP-9430 . TestSSLFactory fails on IBM JVM. Contributed by Amir Sanjar. (Revision 1461268) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1461268 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/ReloadingX509TrustManager.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk #1357 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1357/)
      HADOOP-9430. TestSSLFactory fails on IBM JVM. Contributed by Amir Sanjar. (Revision 1461268)

      Result = FAILURE
      suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1461268
      Files :

      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/ReloadingX509TrustManager.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java
      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1357 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1357/ ) HADOOP-9430 . TestSSLFactory fails on IBM JVM. Contributed by Amir Sanjar. (Revision 1461268) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1461268 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/ReloadingX509TrustManager.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk #1385 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1385/)
      HADOOP-9430. TestSSLFactory fails on IBM JVM. Contributed by Amir Sanjar. (Revision 1461268)

      Result = SUCCESS
      suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1461268
      Files :

      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/ReloadingX509TrustManager.java
      • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java
      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1385 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1385/ ) HADOOP-9430 . TestSSLFactory fails on IBM JVM. Contributed by Amir Sanjar. (Revision 1461268) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1461268 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/ReloadingX509TrustManager.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java

        People

        • Assignee:
          Unassigned
          Reporter:
          Amir Sanjar
        • Votes:
          0 Vote for this issue
          Watchers:
          6 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development