Hadoop Common
  1. Hadoop Common
  2. HADOOP-9181

Set daemon flag for HttpServer's QueuedThreadPool

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha, 3.0.0
    • Fix Version/s: 2.0.3-alpha, 0.23.6
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      we hit HBASE-6031 again, after looking into thread dump, it was caused by the threads from QueuedThreadPool are user thread, not daemon thread, so the hbase shutdownhook never be called and the hbase instance was hung.

      Furthermore, i saw daemon be set in fb-20 branch, let's set in trunk codebase as well, it should be safe

        Issue Links

          Activity

          Liang Xie created issue -
          Liang Xie made changes -
          Field Original Value New Value
          Attachment HADOOP-9181.txt [ 12563534 ]
          Liang Xie made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12563534/HADOOP-9181.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1952//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1952//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563534/HADOOP-9181.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1952//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1952//console This message is automatically generated.
          Suresh Srinivas made changes -
          Assignee liang xie [ xieliang007 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12563534/HADOOP-9181.txt
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1982//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563534/HADOOP-9181.txt against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1982//console This message is automatically generated.
          Hide
          Suresh Srinivas added a comment -

          +1 for the patch. Committed it to trunk and branch-2.

          Thank you Liang.

          Show
          Suresh Srinivas added a comment - +1 for the patch. Committed it to trunk and branch-2. Thank you Liang.
          Suresh Srinivas made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 2.0.3-alpha [ 12323273 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #3186 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3186/)
          HADOOP-9181. Set daemon flag for HttpServer's QueuedThreadPool. Contributed by Liang Xie. (Revision 1429810)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1429810
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-trunk-Commit #3186 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3186/ ) HADOOP-9181 . Set daemon flag for HttpServer's QueuedThreadPool. Contributed by Liang Xie. (Revision 1429810) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1429810 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #90 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/90/)
          HADOOP-9181. Set daemon flag for HttpServer's QueuedThreadPool. Contributed by Liang Xie. (Revision 1429810)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1429810
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Yarn-trunk #90 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/90/ ) HADOOP-9181 . Set daemon flag for HttpServer's QueuedThreadPool. Contributed by Liang Xie. (Revision 1429810) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1429810 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1279 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1279/)
          HADOOP-9181. Set daemon flag for HttpServer's QueuedThreadPool. Contributed by Liang Xie. (Revision 1429810)

          Result = FAILURE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1429810
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1279 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1279/ ) HADOOP-9181 . Set daemon flag for HttpServer's QueuedThreadPool. Contributed by Liang Xie. (Revision 1429810) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1429810 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1307 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1307/)
          HADOOP-9181. Set daemon flag for HttpServer's QueuedThreadPool. Contributed by Liang Xie. (Revision 1429810)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1429810
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1307 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1307/ ) HADOOP-9181 . Set daemon flag for HttpServer's QueuedThreadPool. Contributed by Liang Xie. (Revision 1429810) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1429810 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          Hide
          Thomas Graves added a comment -

          merged to branch-0.23

          Show
          Thomas Graves added a comment - merged to branch-0.23
          Thomas Graves made changes -
          Fix Version/s 0.23.6 [ 12323504 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #495 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/495/)
          HADOOP-9181. Set daemon flag for HttpServer's QueuedThreadPool (Liang Xie via tgraves) (Revision 1432972)

          Result = FAILURE
          tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432972
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #495 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/495/ ) HADOOP-9181 . Set daemon flag for HttpServer's QueuedThreadPool (Liang Xie via tgraves) (Revision 1432972) Result = FAILURE tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1432972 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
          Arpit Agarwal made changes -
          Link This issue relates to HDFS-4426 [ HDFS-4426 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          6m 21s 1 Liang Xie 07/Jan/13 09:31
          Patch Available Patch Available Resolved Resolved
          5h 7m 1 Suresh Srinivas 07/Jan/13 14:38
          Resolved Resolved Closed Closed
          38d 22h 33m 1 Arun C Murthy 15/Feb/13 13:12

            People

            • Assignee:
              Liang Xie
              Reporter:
              Liang Xie
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development