[HADOOP-9174] TestSecurityUtil fails on Open JDK 7

• Type: Test
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1-win
• Fix Version/s: 1.2.0
• Component/s: test
• Target Version/s: 1.2.0
• Hadoop Flags: Reviewed
• Assignee: Arpit Agarwal
• Reporter: Arpit Agarwal
• Created: 02/Jan/13 22:09
• Updated: 15/May/13 05:15
• Resolved: 02/Jan/13 23:05

Description

TestSecurityUtil.TestBuildTokenServiceSockAddr fails due to implicit dependency on the test case execution order.

Testcase: testBuildTokenServiceSockAddr took 0.003 sec
Caused an ERROR
expected:<[127.0.0.1]:123> but was:<[localhost]:123>
at org.apache.hadoop.security.TestSecurityUtil.testBuildTokenServiceSockAddr(TestSecurityUtil.java:133)

Similar bug exists in TestSecurityUtil.testBuildDTServiceName.

The root cause is that a helper routine (verifyAddress) used by some test cases has a side effect. It resets a static variable (SecurityUtil.useIpForTokenService).

The broken test cases assume that the flag will be set to true when they are invoked. The fix is to explicitly initialize the flag to its expected value instead of depending on the execution order.

Issue Links

• is related to: HADOOP-8693 TestSecurityUtil fails intermittently with JDK7