Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9174

TestSecurityUtil fails on Open JDK 7

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Test
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 1-win
    • 1.2.0
    • test
    • None
    • Reviewed

    Description

      TestSecurityUtil.TestBuildTokenServiceSockAddr fails due to implicit dependency on the test case execution order.

      Testcase: testBuildTokenServiceSockAddr took 0.003 sec
      Caused an ERROR
      expected:<[127.0.0.1]:123> but was:<[localhost]:123>
      at org.apache.hadoop.security.TestSecurityUtil.testBuildTokenServiceSockAddr(TestSecurityUtil.java:133)

      Similar bug exists in TestSecurityUtil.testBuildDTServiceName.

      The root cause is that a helper routine (verifyAddress) used by some test cases has a side effect. It resets a static variable (SecurityUtil.useIpForTokenService).

      The broken test cases assume that the flag will be set to true when they are invoked. The fix is to explicitly initialize the flag to its expected value instead of depending on the execution order.

      Attachments

        1. HADOOP-9174.patch
          0.8 kB
          Arpit Agarwal

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            arp Arpit Agarwal
            arp Arpit Agarwal
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment