Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1-win
    • Fix Version/s: 1.2.0
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      TestSecurityUtil.TestBuildTokenServiceSockAddr fails due to implicit dependency on the test case execution order.

      Testcase: testBuildTokenServiceSockAddr took 0.003 sec
      Caused an ERROR
      expected:<[127.0.0.1]:123> but was:<[localhost]:123>
      at org.apache.hadoop.security.TestSecurityUtil.testBuildTokenServiceSockAddr(TestSecurityUtil.java:133)

      Similar bug exists in TestSecurityUtil.testBuildDTServiceName.

      The root cause is that a helper routine (verifyAddress) used by some test cases has a side effect. It resets a static variable (SecurityUtil.useIpForTokenService).

      The broken test cases assume that the flag will be set to true when they are invoked. The fix is to explicitly initialize the flag to its expected value instead of depending on the execution order.

      1. HADOOP-9174.patch
        0.8 kB
        Arpit Agarwal

        Issue Links

          Activity

          Arpit Agarwal created issue -
          Arpit Agarwal made changes -
          Field Original Value New Value
          Attachment HADOOP-9174.patch [ 12562982 ]
          Arpit Agarwal made changes -
          Description TestSecurityUtil.TestBuildTokenServiceSockAddr fails due to implicit dependency on the test case execution order.

          Testcase: testBuildTokenServiceSockAddr took 0.003 sec
          Caused an ERROR
          expected:<[127.0.0.1]:123> but was:<[localhost]:123>
          at org.apache.hadoop.security.TestSecurityUtil.testBuildTokenServiceSockAddr(TestSecurityUtil.java:133)


          Similar bug exists in TestSecurityUtil.testBuildDTServiceName.
          TestSecurityUtil.TestBuildTokenServiceSockAddr fails due to implicit dependency on the test case execution order.

          Testcase: testBuildTokenServiceSockAddr took 0.003 sec
          Caused an ERROR
          expected:<[127.0.0.1]:123> but was:<[localhost]:123>
          at org.apache.hadoop.security.TestSecurityUtil.testBuildTokenServiceSockAddr(TestSecurityUtil.java:133)


          Similar bug exists in TestSecurityUtil.testBuildDTServiceName.

          The root cause is that a helper routine (verifyAddress) used by some test cases has a side effect. It resets a static variable (SecurityUtil.useIpForTokenService).

          The broken test cases assume that the flag will be set to true when they are invoked. The fix is to explicitly initialize the flag to its expected value instead of depending on the execution order.
          Suresh Srinivas made changes -
          Target Version/s 1-win [ 12320361 ] 1.2.0 [ 12321659 ]
          Component/s test [ 12311440 ]
          Suresh Srinivas made changes -
          Link This issue is related to HADOOP-8693 [ HADOOP-8693 ]
          Suresh Srinivas made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 1.2.0 [ 12321659 ]
          Resolution Fixed [ 1 ]
          Suresh Srinivas made changes -
          Summary TestSecurityUtil failure on Windows with Open JDK 7 TestSecurityUtil fails on Open JDK 7
          Matt Foley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Arpit Agarwal
              Reporter:
              Arpit Agarwal
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development