Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1-win
    • Fix Version/s: 1.2.0
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      TestSecurityUtil.TestBuildTokenServiceSockAddr fails due to implicit dependency on the test case execution order.

      Testcase: testBuildTokenServiceSockAddr took 0.003 sec
      Caused an ERROR
      expected:<[127.0.0.1]:123> but was:<[localhost]:123>
      at org.apache.hadoop.security.TestSecurityUtil.testBuildTokenServiceSockAddr(TestSecurityUtil.java:133)

      Similar bug exists in TestSecurityUtil.testBuildDTServiceName.

      The root cause is that a helper routine (verifyAddress) used by some test cases has a side effect. It resets a static variable (SecurityUtil.useIpForTokenService).

      The broken test cases assume that the flag will be set to true when they are invoked. The fix is to explicitly initialize the flag to its expected value instead of depending on the execution order.

      1. HADOOP-9174.patch
        0.8 kB
        Arpit Agarwal

        Issue Links

          Activity

          Hide
          Arpit Agarwal added a comment -

          Fix to reset SecurityUtil.setTokenServiceUseIp to a predictable value before running the tests.

          Show
          Arpit Agarwal added a comment - Fix to reset SecurityUtil.setTokenServiceUseIp to a predictable value before running the tests.
          Hide
          Brandon Li added a comment -

          +1. The patch looks good.
          Please update the JIRA description with the root cause you mentioned offline.

          Show
          Brandon Li added a comment - +1. The patch looks good. Please update the JIRA description with the root cause you mentioned offline.
          Hide
          Arpit Agarwal added a comment -

          Thanks Brandon, updated as suggested.

          Show
          Arpit Agarwal added a comment - Thanks Brandon, updated as suggested.
          Hide
          Suresh Srinivas added a comment -

          +1. There were similar test failures fixed in trunk. Is this change also required for trunk?

          Show
          Suresh Srinivas added a comment - +1. There were similar test failures fixed in trunk. Is this change also required for trunk?
          Hide
          Suresh Srinivas added a comment -

          A similar change for JDK7 was made in trunk in HADOOP-8693.

          Show
          Suresh Srinivas added a comment - A similar change for JDK7 was made in trunk in HADOOP-8693 .
          Hide
          Suresh Srinivas added a comment -

          I committed this to branch-1.

          Show
          Suresh Srinivas added a comment - I committed this to branch-1.
          Hide
          Arpit Agarwal added a comment -

          Thanks Suresh, and for the linking the related fix in trunk.

          Show
          Arpit Agarwal added a comment - Thanks Suresh, and for the linking the related fix in trunk.
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop 1.2.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.

            People

            • Assignee:
              Arpit Agarwal
              Reporter:
              Arpit Agarwal
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development