[HADOOP-9154] SortedMapWritable#putAll() doesn't add key/value classes to the map

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.1, 2.0.2-alpha
• Fix Version/s: 1.2.0, 0.23.7, 2.1.0-beta
• Component/s: io
• Target Version/s: 1.2.0, 2.0.3-alpha
• Hadoop Flags: Reviewed
• Assignee: Karthik Kambatla
• Reporter: Karthik Kambatla
• Created: 18/Dec/12 04:37
• Updated: 03/Nov/14 18:33
• Resolved: 14/Feb/13 14:10

Description

In the following code from SortedMapWritable, #putAll() doesn't add key/value classes to the class-id maps.

  @Override
  public Writable put(WritableComparable key, Writable value) {
    addToMap(key.getClass());
    addToMap(value.getClass());
    return instance.put(key, value);
  }

  @Override
  public void putAll(Map<? extends WritableComparable, ? extends Writable> t){
    for (Map.Entry<? extends WritableComparable, ? extends Writable> e:
      t.entrySet()) {
      
      instance.put(e.getKey(), e.getValue());
    }
  }

Issue Links

• is blocked by: HADOOP-9124 SortedMapWritable violates contract of Map interface for equals() and hashCode()