Hadoop Common
  1. Hadoop Common
  2. HADOOP-9111

Fix failed testcases with @ignore annotation In branch-1

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0
    • Fix Version/s: 1-win, 1.1.2
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently in branch-1, several failed testcases have @ignore annotation which does not take effect because these testcases are still using JUnit3. This jira plans to change these testcases to JUnit4 to let @ignore work.

        Activity

        Hide
        Matt Foley added a comment -

        Closed upon successful release of 1.1.2.

        Show
        Matt Foley added a comment - Closed upon successful release of 1.1.2.
        Hide
        Suresh Srinivas added a comment -

        I merged this patch to 1.1.2.

        Show
        Suresh Srinivas added a comment - I merged this patch to 1.1.2.
        Hide
        Suresh Srinivas added a comment -

        Nicholas, can you please merge this to 1.1.2 as well. That way annoying test failures on new ant versions is a thing of past.

        Show
        Suresh Srinivas added a comment - Nicholas, can you please merge this to 1.1.2 as well. That way annoying test failures on new ant versions is a thing of past.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Jing!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Jing!
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I tested it manually. It worked well with @Ignore and ant 1.8.2.

        Show
        Tsz Wo Nicholas Sze added a comment - I tested it manually. It worked well with @Ignore and ant 1.8.2.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Jing Zhao added a comment -

        All the testcases passed and the test-patch result is:

        -1 overall.  
            +1 @author.  The patch does not contain any @author tags.
            +1 tests included.  The patch appears to include 36 new or modified tests.
            +1 javadoc.  The javadoc tool did not generate any warning messages.
            +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
            -1 findbugs.  The patch appears to introduce 225 new Findbugs (version 2.0.1) warnings.
        
        Show
        Jing Zhao added a comment - All the testcases passed and the test-patch result is: -1 overall. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 36 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 225 new Findbugs (version 2.0.1) warnings.
        Hide
        Jing Zhao added a comment -

        With the patch the @ignore seems to work when testing individual testcases. Will run ant test and test-patch to verify.

        Show
        Jing Zhao added a comment - With the patch the @ignore seems to work when testing individual testcases. Will run ant test and test-patch to verify.
        Hide
        Jing Zhao added a comment -

        Initial patch.

        Show
        Jing Zhao added a comment - Initial patch.

          People

          • Assignee:
            Jing Zhao
            Reporter:
            Jing Zhao
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development