Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 2.0.0-alpha, 3.0.0
    • Fix Version/s: 2.0.3-alpha
    • Component/s: ipc
    • Labels:
      None

      Description

      To ease adding additional SASL support, need to merge the multiple switches for mechanism type and server creation into a single switch with a single call to createSaslServer.

        Issue Links

          Activity

          Hide
          Daryn Sharp added a comment -

          Instead of having two switches and deferred instantiation of the sasl server, merge the two and immediately create the server once it's known to be needed.

          Show
          Daryn Sharp added a comment - Instead of having two switches and deferred instantiation of the sasl server, merge the two and immediately create the server once it's known to be needed.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12552543/HADOOP-9015.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1720//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1720//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12552543/HADOOP-9015.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1720//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1720//console This message is automatically generated.
          Hide
          Robert Joseph Evans added a comment -

          The changes look OK to me. I am +1. I'll check them in.

          Show
          Robert Joseph Evans added a comment - The changes look OK to me. I am +1. I'll check them in.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #2976 (See https://builds.apache.org/job/Hadoop-trunk-Commit/2976/)
          HADOOP-9015. Standardize creation of SaslRpcServers (daryn via bobby) (Revision 1406851)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406851
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          Show
          Hudson added a comment - Integrated in Hadoop-trunk-Commit #2976 (See https://builds.apache.org/job/Hadoop-trunk-Commit/2976/ ) HADOOP-9015 . Standardize creation of SaslRpcServers (daryn via bobby) (Revision 1406851) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406851 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          Hide
          Robert Joseph Evans added a comment -

          Thanks Daryn,

          I put this into trunk and branch-2

          Show
          Robert Joseph Evans added a comment - Thanks Daryn, I put this into trunk and branch-2
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #30 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/30/)
          HADOOP-9015. Standardize creation of SaslRpcServers (daryn via bobby) (Revision 1406851)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406851
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          Show
          Hudson added a comment - Integrated in Hadoop-Yarn-trunk #30 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/30/ ) HADOOP-9015 . Standardize creation of SaslRpcServers (daryn via bobby) (Revision 1406851) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406851 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1220 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1220/)
          HADOOP-9015. Standardize creation of SaslRpcServers (daryn via bobby) (Revision 1406851)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406851
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1220 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1220/ ) HADOOP-9015 . Standardize creation of SaslRpcServers (daryn via bobby) (Revision 1406851) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406851 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1250 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1250/)
          HADOOP-9015. Standardize creation of SaslRpcServers (daryn via bobby) (Revision 1406851)

          Result = FAILURE
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406851
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1250 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1250/ ) HADOOP-9015 . Standardize creation of SaslRpcServers (daryn via bobby) (Revision 1406851) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1406851 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestSaslRPC.java

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development