Hadoop Common
  1. Hadoop Common
  2. HADOOP-8932

JNI-based user-group mapping modules can be too chatty on lookup failures

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.3-alpha, 0.23.5, 3.0.0
    • Fix Version/s: 2.0.3-alpha, 0.23.5
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      On a user/group lookup failure, JniBasedUnixGroupsMapping and JniBasedUnixGroupsNetgroupMapping are logging the
      full stack trace at WARN level. Since the caller of these methods is already logging errors, this is not needed. In branch-1, just one line is logged, so we don't need this change there.

        Issue Links

          Activity

          Kihwal Lee created issue -
          Kihwal Lee made changes -
          Field Original Value New Value
          Project Hadoop HDFS [ 12310942 ] Hadoop Common [ 12310240 ]
          Key HDFS-4064 HADOOP-8932
          Affects Version/s 3.0.0 [ 12320357 ]
          Affects Version/s 2.0.3-alpha [ 12323273 ]
          Affects Version/s 0.23.5 [ 12323314 ]
          Affects Version/s 3.0.0 [ 12320356 ]
          Affects Version/s 2.0.3-alpha [ 12323274 ]
          Affects Version/s 0.23.5 [ 12323313 ]
          Target Version/s 3.0.0, 2.0.3-alpha, 0.23.5 [ 12320356, 12323274, 12323313 ]
          Component/s security [ 12312526 ]
          Component/s security [ 12313400 ]
          Kihwal Lee made changes -
          Attachment hadoop-8932.patch.txt [ 12549319 ]
          Kihwal Lee made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12549319/hadoop-8932.patch.txt
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1633//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1633//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12549319/hadoop-8932.patch.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1633//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1633//console This message is automatically generated.
          Hide
          Kihwal Lee added a comment -

          No test is included since the change is about log message.

          Show
          Kihwal Lee added a comment - No test is included since the change is about log message.
          Hide
          Suresh Srinivas added a comment -

          +1 for the change.

          Show
          Suresh Srinivas added a comment - +1 for the change.
          Hide
          Suresh Srinivas added a comment -

          I will commit this patch soon.

          Show
          Suresh Srinivas added a comment - I will commit this patch soon.
          Hide
          Suresh Srinivas added a comment -

          I committed the patch to branch-2, 0.23 and trunk. Thank you Kihwal.

          Show
          Suresh Srinivas added a comment - I committed the patch to branch-2, 0.23 and trunk. Thank you Kihwal.
          Suresh Srinivas made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 3.0.0 [ 12320357 ]
          Fix Version/s 2.0.3-alpha [ 12323273 ]
          Fix Version/s 0.23.5 [ 12323314 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #407 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/407/)
          HADOOP-8932. Merging change 1398883 from trunk. (Revision 1398886)

          Result = UNSTABLE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1398886
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/JniBasedUnixGroupsMapping.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/JniBasedUnixGroupsNetgroupMapping.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #407 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/407/ ) HADOOP-8932 . Merging change 1398883 from trunk. (Revision 1398886) Result = UNSTABLE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1398886 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/JniBasedUnixGroupsMapping.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/JniBasedUnixGroupsNetgroupMapping.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #2903 (See https://builds.apache.org/job/Hadoop-trunk-Commit/2903/)
          Change incorrect jira number HADOOP-8923 to HADOOP-8932 introduced in commit r1398883. (Revision 1400552)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1400552
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-trunk-Commit #2903 (See https://builds.apache.org/job/Hadoop-trunk-Commit/2903/ ) Change incorrect jira number HADOOP-8923 to HADOOP-8932 introduced in commit r1398883. (Revision 1400552) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1400552 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #10 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/10/)
          Change incorrect jira number HADOOP-8923 to HADOOP-8932 introduced in commit r1398883. (Revision 1400552)

          Result = FAILURE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1400552
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Yarn-trunk #10 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/10/ ) Change incorrect jira number HADOOP-8923 to HADOOP-8932 introduced in commit r1398883. (Revision 1400552) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1400552 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #411 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/411/)
          Merge 1400552 from trunk to change incorrect jira number HADOOP-8923 to HADOOP-8932 introduced in commit r1398883. (Revision 1400554)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1400554
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #411 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/411/ ) Merge 1400552 from trunk to change incorrect jira number HADOOP-8923 to HADOOP-8932 introduced in commit r1398883. (Revision 1400554) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1400554 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1202 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1202/)
          Change incorrect jira number HADOOP-8923 to HADOOP-8932 introduced in commit r1398883. (Revision 1400552)

          Result = FAILURE
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1400552
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1202 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1202/ ) Change incorrect jira number HADOOP-8923 to HADOOP-8932 introduced in commit r1398883. (Revision 1400552) Result = FAILURE suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1400552 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1232 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1232/)
          Change incorrect jira number HADOOP-8923 to HADOOP-8932 introduced in commit r1398883. (Revision 1400552)

          Result = SUCCESS
          suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1400552
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1232 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1232/ ) Change incorrect jira number HADOOP-8923 to HADOOP-8932 introduced in commit r1398883. (Revision 1400552) Result = SUCCESS suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1400552 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Kihwal Lee made changes -
          Link This issue duplicates HADOOP-9039 [ HADOOP-9039 ]
          Thomas Graves made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Allen Wittenauer made changes -
          Fix Version/s 3.0.0 [ 12320357 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          8m 51s 1 Kihwal Lee 16/Oct/12 15:58
          Patch Available Patch Available Resolved Resolved
          1h 59m 1 Suresh Srinivas 16/Oct/12 17:58
          Resolved Resolved Closed Closed
          113d 7m 1 Thomas Graves 06/Feb/13 17:05

            People

            • Assignee:
              Kihwal Lee
              Reporter:
              Kihwal Lee
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development